[PATCH 1/2] staging: ccree: remove unnecessary cast on kmalloc

2017-07-09 Thread Gustavo A. R. Silva
A. R. Silva <garsi...@embeddedor.com> --- drivers/staging/ccree/ssi_buffer_mgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index b35871e..18a8694 100644 --- a/drivers/staging

[PATCH 2/2] staging: ccree: use sizeof(*var) in kmalloc

2017-07-08 Thread Gustavo A. R. Silva
Fix the following checkpatch warning: CHECK: Prefer kmalloc(sizeof(*buff_mgr_handle)...) over kmalloc(sizeof(struct buff_mgr_handle)...) Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/staging/ccree/ssi_buffer_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] crypto: omap-sham: remove unnecessary static in omap_sham_remove()

2017-07-18 Thread Gustavo A. R. Silva
11944 128 38207953f drivers/crypto/omap-sham.o after: textdata bss dec hex filename 26084 11856 64 380049474 drivers/crypto/omap-sham.o Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/crypto/omap-sham.c | 2 +- 1 file chan

[PATCH] crypto: img-hash: remove unnecessary static in img_hash_remove()

2017-07-18 Thread Gustavo A. R. Silva
filename 148426464 128 2143453ba drivers/crypto/img-hash.o after: textdata bss dec hex filename 147896376 64 2122952ed drivers/crypto/img-hash.o Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/crypto/img-hash.c | 2 +-

[PATCH] crypto: atmel-sha: remove unnecessary static in atmel_sha_remove()

2017-07-18 Thread Gustavo A. R. Silva
filename 30005 10264 128 403979dcd drivers/crypto/atmel-sha.o after: textdata bss dec hex filename 29934 10208 64 402069d0e drivers/crypto/atmel-sha.o Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/crypto/atmel-sha.c | 2

[PATCH] crypto: atmel-tdes: remove unnecessary static in atmel_tdes_remove()

2017-07-18 Thread Gustavo A. R. Silva
filename 170798704 128 259116537 drivers/crypto/atmel-tdes.o after: textdata bss dec hex filename 170398616 64 257196477 drivers/crypto/atmel-tdes.o Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/crypto/atmel-tdes

[PATCH] crypto: mediatek: fix error return code in mtk_crypto_probe()

2017-06-30 Thread Gustavo A. R. Silva
Propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/mediatek/mtk-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/me

[PATCH] crypto: ccp-platform: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/ccp/ccp-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp-platform.c b/drivers/crypto/c

[PATCH] crypto: omap-aes: fix error return code in omap_aes_probe()

2017-06-30 Thread Gustavo A. R. Silva
Propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/omap-aes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 5120a17..c376a3e

[PATCH] crypto: mxc-scc: fix error code in mxc_scc_probe()

2017-06-30 Thread Gustavo A. R. Silva
Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/mxc-scc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mxc-scc.c b/drivers/crypto/mxc-scc.c

[PATCH] crypto: omap-des: fix error return code in omap_des_probe()

2017-06-30 Thread Gustavo A. R. Silva
Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/omap-des.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c

[PATCH] crypto: mxs-dcp: print error message on platform_get_irq failure

2017-06-30 Thread Gustavo A. R. Silva
Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/mxs-dcp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c index 6

[PATCH] crypto: brcm: add NULL check on of_match_device() return value

2017-07-07 Thread Gustavo A. R. Silva
Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/bcm/cipher.c | 5 + 1 file changed, 5 insertions(+)

[PATCH] crypto: tcrypt: mark expected switch fall-throughs in do_test()

2017-10-09 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-crypto@vger.kernel.org Signed-off-by: Gustavo A. R. Silva &

[PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

2017-10-12 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/qat/qat_common/qat_uclo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cryp

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

2017-11-03 Thread Gustavo A. R. Silva
Quoting Herbert Xu <herb...@gondor.apana.org.au>: On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <garsi...@embed

[PATCH] crypto: chcr - Replace _manual_ swap with swap macro

2017-11-03 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable temp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/crypto/chelsio/chcr_algo.c | 5 + 1 file chan

Re: [RESEND] SHASH_DESC_ON_STACK macro

2018-04-05 Thread Gustavo A. R. Silva
Hi Herbert, On 03/27/2018 05:07 AM, Herbert Xu wrote: On Fri, Mar 23, 2018 at 02:09:46PM -0500, Gustavo A. R. Silva wrote: Hi Herbert, There is an ongoing effort to remove all VLAs from the code base [1] and while working on that I came across the following macro at include/crypto/hash.h:154

[PATCH] crypto : chtls_cm - Fix potential NULL pointer dereferences

2018-04-03 Thread Gustavo A. R. Silva
return value") Addresses-Coverity-ID: 1467449 ("Dereference null return value") Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/crypto/chelsio/chtls/chtls_cm.c | 16 ++

[crypto-chtls] Supicious code in chtls_io

2018-04-03 Thread Gustavo A. R. Silva
Hi all, While doing some static analysis I came across the following piece of code at drivers/crypto/chelsio/chtls/chtls_io.c:1203: 1203 if (!size) 1204 break; 1205 1206 if (unlikely(ULP_SKB_CB(skb)->flags & ULPCB_FLAG_NO_APPEND)) 1207

[RESEND] SHASH_DESC_ON_STACK macro

2018-03-23 Thread Gustavo A. R. Silva
Hi Herbert, There is an ongoing effort to remove all VLAs from the code base [1] and while working on that I came across the following macro at include/crypto/hash.h:154: #define SHASH_DESC_ON_STACK(shash, ctx) \ char __##shash##_desc[sizeof(struct

[RFC] SHASH_DESC_ON_STACK macro

2018-03-21 Thread Gustavo A. R. Silva
Hi Herbert, There is an ongoing effort to remove all VLAs from the code base [1] and while working on that I came across the following macro at include/crypto/hash.h:154: #define SHASH_DESC_ON_STACK(shash, ctx) \ char __##shash##_desc[sizeof(struct