Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver

On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote: This patch adds the driver for interacting with the 842 compression accelerator on IBM Power7+ systems. ... +struct nx842_slentry { + unsigned long ptr; /* Absolute address (use virt_to_abs()) */ /+unsigned long len; +};

Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver

On Fri, 2012-07-20 at 09:01 -0500, Seth Jennings wrote: On 07/20/2012 12:33 AM, Michael Ellerman wrote: On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote: This patch adds the driver for interacting with the 842 compression accelerator on IBM Power7+ systems. ... +struct

[PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c

of the includes. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- drivers/crypto/nx/nx-842.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c index 9da0fb2..0ce6257 100644 --- a/drivers

Re: [PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c

Hi Herbert, We're planning on removing virt_to_abs() from the powerpc tree this cycle. So if you can take this patch in your tree everything should continue building when the two trees merge. cheers -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

Hi Fin, I don't know anything about crypto so I can only critique you on your patch submission technique :) ... On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote: This patch fixes a bug that is triggered when cts(cbc(aes)) is used with nx-crypto driver on input larger than 32

Re: [PATCH 6/8 v2] crypto: replace memset by memzero_explicit

patch that makes this Signed-off-by: Julia Lawall julia.law...@lip6.fr --- Daniel Borkmann suggested that these patches could go through Herbert Xu's cryptodev tree. That's fine by me: Acked-by: Michael Ellerman m...@ellerman.id.au cheers -- To unsubscribe from this list: send the line

Re: [PATCH 4/6] crypto/nx-842-{powerpc,pseries}: only load on the appropriate machine type

On Thu, 2015-07-02 at 15:40 -0700, Nishanth Aravamudan wrote: While we never would successfully load on the wrong machine type, there is extra output by default regardless of machine type. For instance, on a PowerVM LPAR, we see the following: nx_compress_powernv: loading

Re: [PATCH v2] crypto/nx-842-{powerpc,pseries}: reduce chattiness of platform drivers

On Mon, 2015-07-06 at 10:06 -0700, Nishanth Aravamudan wrote: On 03.07.2015 [11:30:32 +1000], Michael Ellerman wrote: On Thu, 2015-07-02 at 15:40 -0700, Nishanth Aravamudan wrote: While we never would successfully load on the wrong machine type, there is extra output by default regardless

[PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX

): undefined reference to `.enable_kernel_altivec' aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- v2: Spell out VSX, and CC linux-crypto. drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2] crypto: vmx - VMX crypto should depend on CONFIG_VSX

On Thu, 2015-09-10 at 17:26 +0800, Herbert Xu wrote: > On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote: > > This code uses FP (floating point), Altivec and VSX (Vector-Scalar > > Extension). It can just depend on CONFIG_VSX though, because that > >

[PATCH stable 1/2] powerpc: Uncomment and make enable_kernel_vsx() routine available

erwise it rises an exception oops. This patch uncomment enable_kernel_vsx() routine and makes it available. Signed-off-by: Leonidas S. Barbosa <leosi...@linux.vnet.ibm.com> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Cc: sta...@vger.kernel.org # 4.2 Signed-off-by: M

[PATCH stable 2/2] crypto: vmx - Adding enable_kernel_vsx() to access VSX instructions

or VMX module") Cc: sta...@vger.kernel.org # 4.2 Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- drivers/crypto/vmx/aes.c | 3 +++ drivers/crypto/vmx/aes_cbc.c | 3 +++ drivers/crypto/vmx/aes_ctr.c | 3 +++ drivers/crypto/vmx/ghash.c | 4 4 files changed, 13 insert

[PATCH stable 1/2] powerpc: Uncomment and make enable_kernel_vsx() routine available

erwise it rises an exception oops. This patch uncomment enable_kernel_vsx() routine and makes it available. Signed-off-by: Leonidas S. Barbosa <leosi...@linux.vnet.ibm.com> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Cc: sta...@vger.kernel.org # 4.1 Signed-off-by: M

[PATCH stable 2/2] crypto: vmx - Adding enable_kernel_vsx() to access VSX instructions

on VSX instructions for vmx-crypto. Signed-off-by: Leonidas S. Barbosa <leosi...@linux.vnet.ibm.com> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Fixes: 8676590a1593 ("crypto: vmx - Adding AES routines for VMX module") Cc: sta...@vger.kernel.org # 4.1 Signed-off-b

Re: [PATCH v2 4/8] powerpc: add io{read,write}64 accessors

a cryptodev-2.6 tree. > > It looks good to me. Michael? I didn't get the cover letter, or any of the rest of the series, so although I saw the patch I had no context. And I didn't have time to chase it up. At a glance it seems fine, so: Acked-by: Michael Ellerman <m...@ellerman

Re: [V2,1/2] powerpc: Add module autoloading based on CPU features

On Tue, 2016-19-07 at 04:03:52 UTC, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch provides the necessary infrastructure to allow drivers > to be automatically loaded via UDEV. It implements the minimum > required to be able to use module_cpu_feature_match

Re: [V2, 2/2] crypto: vmx - Convert to CPU feature based module autoloading

On Tue, 2016-19-07 at 04:03:53 UTC, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure > to automatically load the vmx_crypto module if the CPU supports > it. > > Signed-off-by: Alastair D'Silva

Re: [PATCH] crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

Anton Blanchard writes: > From: Anton Blanchard > > This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure > to automatically load the crc32c-vpmsum module if the CPU supports > it. > > Signed-off-by: Anton Blanchard > --- >

Re: [PATCH] crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

Anton Blanchard writes: > Hi Michael, > >> Is VEC_CRYPTO the right feature? >> >> That's new power8 crypto stuff. > > The vpmsum* instructions are part of the same pipeline as the vcipher* > instructions, introduced in POWER8. OK. >> I thought this only used VMX? (but I

[PATCH v2] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC

g> Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2: No change. Send to linux-crypto. diff --git a/crypto/Kconfig b/crypto/Kconfig index a9377bef25e3..84d71482bf08 100644 --- a/crypto/Kconfig +++ b/crypto/Kc

Re: crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

On Thu, 2016-04-08 at 06:38:15 UTC, Anton Blanchard wrote: > From: Anton Blanchard > > This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure > to automatically load the crc32c-vpmsum module if the CPU supports > it. > > Signed-off-by: Anton Blanchard

Re: [PATCH] hwrng: pasemi-rng - Use linux/io.h instead of asm/io.h

Herbert Xu writes: > On Tue, Sep 06, 2016 at 01:58:39PM +0530, PrasannaKumar Muralidharan wrote: >> Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead. >> >> Signed-off-by: PrasannaKumar Muralidharan > > Patch applied.

Re: hwrng: pasemi-rng - Use linux/io.h instead of asm/io.h

On Tue, 2016-06-09 at 08:28:39 UTC, PrasannaKumar Muralidharan wrote: > Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead. > > Signed-off-by: PrasannaKumar Muralidharan Applied to powerpc next, thanks.

Re: [PATCH] crypto: sha1-powerpc: little-endian support

Marcelo Cerri writes: > [ Unknown signature status ] > On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote: >> On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote: >> > Hi Herbert, >> > >> > Any thoughts on this one? >> >> Can this patch wait until

Re: [PATCH] powerpc: crypto/vmx: various build fixes

new > files in the build tree, rather than the source tree. > > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> > --- > Michael, > I've added your SOB here though you didn't explicitly include it

Re: [RFC PATCH] powerpc: crypto/vmx: clean up generated files

"Naveen N. Rao" writes: > ..as stray .S files result in build errors, especially when using > cross-compilers. They should be cleaned on make clean, so adding them to clean-files seems correct. > More specifically, the generated .S files are endian-specific and

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

Daniel Axtens writes: > The core nuts and bolts of the crc32c vpmsum algorithm will > also work for a number of other CRC algorithms with different > polynomials. Factor out the function into a new asm file. > > To handle multiple users of the function, a user simply > provides

Re: [PATCH 2/4] crypto: powerpc - Re-enable non-REFLECTed CRCs

Daniel Axtens writes: > When CRC32c was included in the kernel, Anton ripped out > the #ifdefs around reflected polynomials, because CRC32c > is always reflected. However, not all CRCs use reflection > so we'd like to make it optional. > > Restore the REFLECT parts from Anton's

Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms

Laurentiu Tudor writes: > Hi Michael, > > Just a couple of basic things to check: > - was the dtb updated to the newest? Possibly not, it's an automated build/boot, I'll have to check what it does with the dtb. > - is the qman node present? This should be easily

Re: [PATCH 2/5] crypto/nx: Create nx842_cfg_crb function

Haren Myneni writes: > [PATCH 2/5] crypto/nx: Create nx842_cfg_crb function > > Configure CRB is moved to nx842_cfg_crb() so that it can be > used for icswx function and VAS function which will be added > later. Buy a vowel! :) nx842_configure_crb() is fine. cheers

Re: [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function

Haren Myneni writes: > [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function > > nx842_powernv_function is points to nx842_icswx_function and > will be point to VAS function which will be added later for > P9 NX support. I know it's nit-picking but can

Re: [PATCH 5/5] crypto/nx: Add P9 NX specific error codes for 842 engine

Haren Myneni writes: > [PATCH 5/5] crypto/nx: Add P9 NX specific error codes for 842 engine > > This patch adds changes for checking P9 specific 842 engine > error codes. These errros are reported in co-processor status > block (CSB) for failures. But you just enabled

Re: [PATCH 3/5] crypto/nx: Create nx842_delete_coproc function

Haren Myneni writes: > [PATCH 3/5] crypto/nx: Create nx842_delete_coproc function > > Move deleting coprocessor info upon exit or failure to > nx842_delete_coproc(). Naming again, this deletes *all* the coprocs, so the name should be plural. cheers

Re: [PATCH 4/5] crypto/nx: Add P9 NX support for 842 compression engine.

Hi Haren, A few comments ... Haren Myneni writes: > diff --git a/arch/powerpc/include/asm/vas.h b/arch/powerpc/include/asm/vas.h > index 4e5a470..7315621 100644 > --- a/arch/powerpc/include/asm/vas.h > +++ b/arch/powerpc/include/asm/vas.h > @@ -19,6 +19,8 @@ >

Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms

Laurentiu Tudor <laurentiu.tu...@nxp.com> writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor <laurentiu.tu...@nxp.com> writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>>

[PATCH v2] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

bug switch to make it active and all enables should be paired with disables. Fixes: b01df1c16c9a ("crypto: powerpc - Add CRC-T10DIF acceleration") Acked-by: Daniel Axtens <d...@axtens.net> Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- arch/powerpc/crypto/crct10d

Re: [PATCH] crypto: powerpc - Fix initialisation of crc32c context

Daniel Axtens writes: > Turning on crypto self-tests on a POWER8 shows: > > alg: hash: Test 1 failed for crc32c-vpmsum > : ff ff ff ff > > Comparing the code with the Intel CRC32c implementation on which > ours is based shows that we are doing an init with 0, not

Re: [PATCH V3 2/6] crypto/nx: Create nx842_configure_crb function

Herbert Xu writes: > On Fri, Jul 21, 2017 at 09:57:39PM -0700, Haren Myneni wrote: >> >> Configure CRB is moved to nx842_configure_crb() so that it can >> be used for icswx and VAS exec functions. VAS function will be >> added later with P9 support. >> >>

Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

nclude down to fix this. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: Nicholas Piggin <npig...@gmail.com&g

Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

Logan Gunthorpe <log...@deltatee.com> writes: > On 18/07/17 11:57 PM, Michael Ellerman wrote: >> Seems fair enough, have you tested it at all? > > It's only been compile tested and the kbuild robot has beat up on it a bit. OK. I don't think I see any way it can break a

Re: [PATCH v2 0/6] Appended signatures support for IMA appraisal

Thiago Jung Bauermann writes: > On the OpenPOWER platform, secure boot and trusted boot are being > implemented using IMA for taking measurements and verifying signatures. I still want you to implement arch_kexec_kernel_verify_sig() as well :) cheers

Re: [kernel-hardening] [PATCH] random: warn when kernel uses unseeded randomness

"Jason A. Donenfeld" writes: > This enables an important dmesg notification about when drivers have > used the crng without it being seeded first. Prior, these errors would > occur silently, and so there hasn't been a great way of diagnosing these > types of bugs for obscure

Re: [kernel-hardening] Re: [PATCH] random: silence compiler warnings and fix race

Theodore Ts'o writes: > On Mon, Jun 19, 2017 at 10:57:18PM +0200, Jason A. Donenfeld wrote: >> >> With rc6 already released and rc7 coming up, I'd really appreciate you >> stepping in here and either ACKing the above commit, or giving your >> two cents about it in case I need to

Re: [PATCH v2 0/6] Appended signatures support for IMA appraisal

Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: > Michael Ellerman <m...@ellerman.id.au> writes: > >> Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> writes: >> >>> On the OpenPOWER platform, secure boot and trusted boot are being >

Re: [kernel-hardening] Re: [PATCH v4 13/13] random: warn when kernel uses unseeded randomness

Theodore Ts'o writes: > On Tue, Jun 06, 2017 at 07:48:04PM +0200, Jason A. Donenfeld wrote: >> This enables an important dmesg notification about when drivers have >> used the crng without it being seeded first. Prior, these errors would >> occur silently, and so there hasn't been

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Hi Haren, Some comments inline ... Haren Myneni writes: > diff --git a/drivers/crypto/nx/nx-842-powernv.c > b/drivers/crypto/nx/nx-842-powernv.c > index c0dd4c7e17d3..13089a0b9dfa 100644 > --- a/drivers/crypto/nx/nx-842-powernv.c > +++

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Hi Dan, Thanks for reviewing this series. Dan Streetman writes: > On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni > wrote: >> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: > +

Re: [V4,1/7] crypto/nx: Rename nx842_powernv_function as icswx function

On Thu, 2017-08-31 at 07:11:29 UTC, Haren Myneni wrote: > Rename nx842_powernv_function to nx842_powernv_exec. > nx842_powernv_exec points to nx842_exec_icswx and > will be point to VAS exec function which will be added later > for P9 NX support. > > Signed-off-by: Haren Myneni

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Haren Myneni <ha...@linux.vnet.ibm.com> writes: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman <m...@ellerman.id.au> >> wrote: >>> Hi Haren, >>> >>> Some comments inline ... >>> >>> Haren Myneni <ha...@linux.vnet.i

Re: [1/2] crypto/nx: Use percpu send window for NX requests

On Mon, 2017-09-25 at 06:43:02 UTC, Haren Myneni wrote: > [PATCH 1/2] crypto/nx: Use percpu send window for NX requests > > For P9 NX, the send window is opened for each crypto session and closed > upon free. But VAS supports 64K windows per chip for all coprocessors > including in user space

Re: [PATCH 1/2] crypto: vmx - Remove overly verbose printk from AES init routines

Herbert Xu <herb...@gondor.apana.org.au> writes: > On Thu, May 03, 2018 at 10:29:29PM +1000, Michael Ellerman wrote: >> In the vmx AES init routines we do a printk(KERN_INFO ...) to report >> the fallback implementation we're using. >> >> However with a slow cons

[PATCH 2/2] crypto: vmx - Remove overly verbose printk from AES XTS init

kernel.org # v4.8+ Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- drivers/crypto/vmx/aes_xts.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c index 8cd6e62e4c90..8bd9aff0f55f 100644 --- a/drivers/crypto/vmx/aes_xts

[PATCH 1/2] crypto: vmx - Remove overly verbose printk from AES init routines

a ("crypto: vmx - Adding GHASH routines for VMX module") Cc: sta...@vger.kernel.org # v4.1+ Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- drivers/crypto/vmx/aes.c | 2 -- drivers/crypto/vmx/aes_cbc.c | 3 --- drivers/crypto/vmx/aes_ctr.c | 2 -- drivers/crypto/vmx/

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

Logan Gunthorpe writes: > This is v14 of my cleanup series to push a number of instances of people > defining their own io{read|write}64 functions into common headers seing > they don't exist in non-64bit systems. This series adds inline functions to > the > io-64-nonatomic

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

Logan Gunthorpe <log...@deltatee.com> writes: > On 4/4/2018 4:38 AM, Michael Ellerman wrote: ... >> eg. It looks like I could take the two powerpc patches on their own for >> 4.17, and then the rest could go via other trees? > > Yup! If you can take the powerpc patch