Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Herbert Xu
On Mon, Jul 10, 2017 at 11:51:42AM -0700, Linus Torvalds wrote: > Heh, I already did this in commit b4b8cbf679c4. > > I complained because I want maintainers to be aware of this issue - > adding Kconfig options with defaults that don't make sense should be > caught earlier than when I do a test

Re: [PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Linus Torvalds
Heh, I already did this in commit b4b8cbf679c4. I complained because I want maintainers to be aware of this issue - adding Kconfig options with defaults that don't make sense should be caught earlier than when I do a test built.. Linus On Mon, Jul 10, 2017 at 3:15 AM, Herbert

[PATCH] crypto: cavium/nitrox - Remove default m setting from Kconfig

2017-07-10 Thread Herbert Xu
Drivers should not enable themselves by default, unless they're an integral part of the platform. Reported-by: Linus Torvalds Signed-off-by: Herbert Xu diff --git a/drivers/crypto/cavium/nitrox/Kconfig