Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

Daniel Axtens wrote: > The core nuts and bolts of the crc32c vpmsum algorithm will > also work for a number of other CRC algorithms with different > polynomials. Factor out the function into a new asm file. > > To handle multiple users of the function, a user simply > provides

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

> So although this sits in arch/powerpc, it's heavy on the crypto which is > not my area of expertise (to say the least!), so I think it should > probably go via Herbert and the crypto tree? That was my thought as well. Sorry - probably should have put that in the comments somewhere. Regards,

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

Hi David, > While not part of this change, the unrolled loops look as though > they just destroy the cpu cache. > I'd like be convinced that anything does CRC over long enough buffers > to make it a gain at all. btrfs data checksumming is one area. > With modern (not that modern now)

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

Daniel Axtens writes: > The core nuts and bolts of the crc32c vpmsum algorithm will > also work for a number of other CRC algorithms with different > polynomials. Factor out the function into a new asm file. > > To handle multiple users of the function, a user simply > provides

RE: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

From: Daniel Axtens > Sent: 15 March 2017 22:30 > Hi David, > > > While not part of this change, the unrolled loops look as though > > they just destroy the cpu cache. > > I'd like be convinced that anything does CRC over long enough buffers > > to make it a gain at all. > > > > With modern (not

RE: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

Hi David, > While not part of this change, the unrolled loops look as though > they just destroy the cpu cache. > I'd like be convinced that anything does CRC over long enough buffers > to make it a gain at all. > > With modern (not that modern now) superscalar cpus you can often > get the loop

RE: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

From: Linuxppc-dev Daniel Axtens > Sent: 15 March 2017 12:38 > The core nuts and bolts of the crc32c vpmsum algorithm will > also work for a number of other CRC algorithms with different > polynomials. Factor out the function into a new asm file. > > To handle multiple users of the function, a