From: Eric Biggers <ebigg...@google.com>
The Blackfin CRC driver was removed by commit 9678a8dc53c1 ("crypto:
bfin_crc - remove blackfin CRC driver"), but it was forgotten to remove
the corresponding "hmac(crc32)" test vectors. I see no point in keeping
them
On Wed, Mar 08, 2017 at 09:20:08AM +0100, Stephan Müller wrote:
> Hi Herbert,
>
> hmac(crc32) is defined in testmgr.c and tcrypt.c. Yet, when using that
> cipher,
> I get an ENOENT:
>
> alg: hash: Failed to load transform for hmac(crc32): -2
>
>
> Is there suc
Hi Herbert,
hmac(crc32) is defined in testmgr.c and tcrypt.c. Yet, when using that cipher,
I get an ENOENT:
alg: hash: Failed to load transform for hmac(crc32): -2
Is there such a thing as hmac(crc32)?
Ciao
Stephan
Am Freitag, 27. Mai 2016, 11:19:32 schrieb Marcus Meissner:
Hi Marcus,
>
> And it actually is:
>
> [ 180.942532] hmac: blocksize check failed, ds=4, cra_blocksize=1, ss=4
> [ 180.942541] alg: hash: Failed to load transform for hmac(crc32): -2
> [ 180.989191] tcrypt: one or
; > >
> > > > > when enabling the testmgr framework and FIPS in 4.6 and 4.4 and
> > > > > running
> > > > > "modprobe tcrypt"
> > > > >
> > > > }, {
> > > >
> > > > .alg = "hmac(
2016, 09:07:52 schrieb Marcus Meissner:
> > >
> > > Hi Marcus,
> > >
> > > > Hi,
> > > >
> > > > when enabling the testmgr framework and FIPS in 4.6 and 4.4 and running
> > > > "modprobe tcrypt"
> &
gt; >
> > > when enabling the testmgr framework and FIPS in 4.6 and 4.4 and running
> > > "modprobe tcrypt"
> > >
> > }, {
> >
> > .alg = "hmac(crc32)",
> > .test = alg_t
Am Mittwoch, 25. Mai 2016, 09:07:52 schrieb Marcus Meissner:
Hi Marcus,
> Hi,
>
> when enabling the testmgr framework and FIPS in 4.6 and 4.4 and running
> "modprobe tcrypt"
}, {
.alg = "hmac(crc32)",
.test = alg_test_has
test vector. The
other is to keep the Blackfin specific test vector. However, neither meets
Broz's expectation of a generic crc32 test vector.
Any idea?
I think we should just remove the blackfin crc driver altogether
as nothing in the kernel ever uses hmac(crc32).
Cheers,
--
Email: Herbert
-Original Message-
From: Herbert Xu [mailto:herb...@gondor.hengli.com.au]
Sent: Thursday, November 22, 2012 10:33 AM
To: Milan Broz
Cc: Zhang, Sonic; linux-crypto@vger.kernel.org
Subject: Re: Tcrypt hmac(crc32) test can work only on Blackfin
On Wed, Nov 21, 2012 at 01:01:49PM +0100
On Wed, Nov 21, 2012 at 01:01:49PM +0100, Milan Broz wrote:
On 11/21/2012 12:29 PM, Zhang, Sonic wrote:
Is there a policy that the CRC test vector
in testmgr.h should support all CRC drivers?
If so, I am fine to drop this test vector.
Question for Herbert...
But the problem I see is
-Original Message-
From: Milan Broz [mailto:mb...@redhat.com]
Sent: Tuesday, November 20, 2012 10:04 PM
To: linux-crypto@vger.kernel.org
Cc: Herbert Xu; Zhang, Sonic
Subject: Tcrypt hmac(crc32) test can work only on Blackfin
Hi,
commit a482b081a2d4d74d16bc9ea8779f9f6055f95852
Author
On 11/21/2012 12:29 PM, Zhang, Sonic wrote:
Is there a policy that the CRC test vector
in testmgr.h should support all CRC drivers?
If so, I am fine to drop this test vector.
Question for Herbert...
But the problem I see is that it confuses people, it simply
returns fail everytime (except
13 matches
Mail list logo
