Re: Proposal for proper durable fsync() and fdatasync()

2008-02-26 Thread Jamie Lokier
Andrew Morton wrote: On Tue, 26 Feb 2008 07:26:50 + Jamie Lokier [EMAIL PROTECTED] wrote: (It would be nicer if sync_file_range() took a vector of ranges for better elevator scheduling, but let's ignore that :-) Two passes: Pass 1: shove each of the segments into the queue with

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: Aloha, The ext2_readdir() filp-f_pos fix patch looks weird... Perhaps the filp-f_pos += le16_to_cpu(de-rec_len); line should be outside of the if statement like the indentation implies? good catch! At least it's what is done in

Re: [PATCH] fbcon: replace mono_col macro with static inline

2008-02-26 Thread Geert Uytterhoeven
On Mon, 25 Feb 2008, Harvey Harrison wrote: Use __u32 for max_len to match the declaration of length in the struct fb_bitfield. Suppresses sparse shadowed variable warnings from the nested max() macros: drivers/video/console/fbcon.h:130:8: warning: symbol '_x' shadows an earlier one

[RFC] ext3 freeze feature ver 0.2

2008-02-26 Thread Takashi Sato
Hi, Takashi Sato wrote: Instead, I'd like the sec to timeout on freeze API in order to thaw the filesystem automatically. It can prevent a filesystem from staying frozen forever. (Because a freezer may cause a deadlock by accessing the frozen filesystem.) I'm still not very comfortable with

[BUG] using smp_processor_id() in preemptible as suspending

2008-02-26 Thread Dave Young
Hi, andrew I don't know whom I should mail to, could you cc the proper guy? Thanks. [ 118.331674] acpi LNXSYSTM:00: suspend [ 118.331674] Disabling non-boot CPUs ... [ 118.331674] CPU0 attaching NULL sched-domain. [ 118.331674] CPU1 attaching NULL sched-domain. [ 118.438750] CPU 1 is now

Re: 2.6.25-rc2 + smartd = hang

2008-02-26 Thread Anders Eriksson
[EMAIL PROTECTED] said: Could you try bisecting it down to the guilty commit using git-bisect? [ the old stuff got few hundred commits in 2.6.25 ] Thanks, Bart Ok, I got this: 852738f39258deafb3d89c187cb1a4050820d555 is first bad commit commit 852738f39258deafb3d89c187cb1a4050820d555

Re: [linux-pm] Fundamental flaw in system suspend, exposed by freezer removal

2008-02-26 Thread David Newall
David Brownell wrote: This flaw isn't a new thing, of course. I remember pointing out the rather annoying proclivity of the PM framework to deadlock when suspend() tried to remove USB devices ... back around 2.6.10 or so. Things have shuffled around a bit, and gotten better in some cases,

Re: [2.6.25-rc3] ACPI _PPC limiting processor speed...

2008-02-26 Thread Daniel J Blueman
On Mon, Feb 25, 2008 at 11:48 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:29:24 + Daniel J Blueman [EMAIL PROTECTED] wrote: My 2.2GHz [1] Thinkpad T61 is unable to get past 1.2GHz, seemingly because of the _PPC ACPI objects [2]. Given that the _PPC object

[PATCH] bluetooth: delete timer in l2cap_conn_del()

2008-02-26 Thread Thomas Gleixner
Delete a possibly armed timer before kfree'ing the connection object. Solves: http://lkml.org/lkml/2008/2/15/514 Reported-by:Quel Qun [EMAIL PROTECTED] Signed-off-by: Thomas Gleixner [EMAIL PROTECTED] --- net/bluetooth/l2cap.c |2 ++ 1 file changed, 2 insertions(+) Index:

Re: 2.6.24 new perfmon kernel code base + libpfm + pfmon finally available!

2008-02-26 Thread Ingo Molnar
* stephane eranian [EMAIL PROTECTED] wrote: I have done that in the past. I will do this again. But if you look at the patch as it is released, you will see that it is very large. Not that easy to split for LKML review. If you want a feature merged upstream it is in your basic interest to

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

2008-02-26 Thread Brad Rosser
Hello Boris, Bart, On Tue, Feb 26, 2008 at 12:45 AM, Borislav Petkov [EMAIL PROTECTED] wrote: On Mon, Feb 25, 2008 at 03:57:06PM +1000, Brad Rosser wrote: ... it would suggest the option 'hda=noprobe' was entered correctly? ok, let's try something else: change the line #if 0 to #if 1 at

Re: iwl4965 dropping packets and __dev_addr_discard: address leakage! da_users=1

2008-02-26 Thread Johannes Berg
Possibly because of the frequent renegotiating my iwl4965 card has been making, it has now decided it's not going to pass packets reliably until presumably next time I reboot. Can't say anything about that. I've noticed messages in syslog that I hadn't seen when things were working

Re: 2.6.24-git: kmap_atomic() WARN_ON()

2008-02-26 Thread Ingo Molnar
* Jeff Garzik [EMAIL PROTECTED] wrote: + unsigned long flags; + + local_irq_save(flags); hm, couldnt we attach the irq disabling to some spinlock, in a natural way? Explicit flags fiddling is a PITA once we do things like threaded irq handlers, -rt, etc. Ingo -- To

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-26 Thread Klaus S. Madsen
On Mon, Feb 25, 2008 at 11:46:11 -0800, Andrew Morton wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts

Re: 2.6.24-git: kmap_atomic() WARN_ON()

2008-02-26 Thread Thomas Gleixner
On Mon, 25 Feb 2008, Jeff Garzik wrote: Welcome to test this... (attached, not tested nor even compiled, really) Works, but I agree with Ingo vs. the stand alone irq_en/disable. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5

2008-02-26 Thread Mikael Pettersson
Mikael Pettersson writes: Booting 2.6.25-rc3 on my Ultra5 causes a hang before or as the console is switched over to the framebuffer. The console output is (extrapolated from dmesg in -rc2 and handwritten notes, as I don't have a serial cable to my U5): PROMLIB: Sun IEEE Boot Prom

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-26 Thread Ingo Molnar
* Pekka Enberg [EMAIL PROTECTED] wrote: Hi, On Tue, Feb 26, 2008 at 8:27 AM, Pekka Enberg [EMAIL PROTECTED] wrote: You could try passing the --callgraph option to opcontrol. Hmm, perhaps I am missing something but I don't think that does what sysprof does. At least I can't find

Re: [RFC] mmiotrace full patch, preview 1

2008-02-26 Thread Andy Whitcroft
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote: Quoting Christoph Hellwig [EMAIL PROTECTED]: On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote: the things which it finds. +static DECLARE_MUTEX(kmmio_init_mutex); That's not a mutex. +

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-26 Thread Ingo Molnar
* Anton Blanchard [EMAIL PROTECTED] wrote: thanks, looks good to me - applied. Woah slow down guys. Did I miss the review? note that it was applied to x86.git#testing. It's as if Andrew applied something to -mm. This is not a guarantee of upstream merging (at all). Ingo -- To

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-26 Thread Paul Menage
On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan [EMAIL PROTECTED] wrote: - foo doesn't show up in /proc/cgroups Or we can print out the disable flag, maybe this will be better? Because we can distinguish from disabled and not compiled in from /proc/cgroups. Certainly possible, if people

Re: [PATCH] x86: add the debugfs interface for the sysprof tool

2008-02-26 Thread Ingo Molnar
* Anton Blanchard [EMAIL PROTECTED] wrote: This surprises me. Can you please elaborate on why oprofile is much less useful than sysprof? see the thread you are replying to. Anton - who has used oprofile to analyse and tune databases, JVMs, compilers and operating systems. Maybe I've

Re: boot_delay broken ?

2008-02-26 Thread Dave Young
On Tue, Feb 26, 2008 at 01:59:31PM +0800, Dave Young wrote: On Tue, Feb 26, 2008 at 1:48 PM, Dave Young [EMAIL PROTECTED] wrote: On Tue, Feb 26, 2008 at 1:22 PM, Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 10:14:36 +0800 Dave Young wrote: On Sun, Feb 24, 2008 at 8:46

Re: [PATCH] Memory Resource Controller Add Boot Option

2008-02-26 Thread Li Zefan
Paul Menage wrote: On Mon, Feb 25, 2008 at 7:01 PM, Li Zefan [EMAIL PROTECTED] wrote: - foo doesn't show up in /proc/cgroups Or we can print out the disable flag, maybe this will be better? Because we can distinguish from disabled and not compiled in from /proc/cgroups. Certainly

Re: Sata-MV, Intergated Sata Device Support

2008-02-26 Thread saeed
On Mon, 25 Feb 2008, Jeff Garzik wrote: ... Saeed: isn't this what your SOC patches already implemented for us? As near as I can tell, sata_mv now already has support for the 60x1C0. Saeed's stuff didn't support PCI though, and Jon Li is definitely talking about PCI... yes, my

Re: [patch 2.6.25-rc2-git 1/2] atmel_tc library

2008-02-26 Thread Haavard Skinnemoen
On Mon, 25 Feb 2008 10:06:44 -0800 David Brownell [EMAIL PROTECTED] wrote: Which reminds me...you were talking about a patch that adds oneshot support for the count/compare clocksource and more cleanups, but I don't think I've seen it...? I avoid sending non-working patches,

SMACK or SELinux, but not both

2008-02-26 Thread Alexey Dobriyan
If SELinux is registered before SMACK, SMACK panics after register_security() call. If SMACK is registered before SELinux, SELinux panics after register_security() call. Consequently allmodconfig kernel doesn't boot. It would be nice if some Kconfig magic to exclude each other will be in place.

Re: [PATCH] Compress kernel modules on installation.

2008-02-26 Thread Adrian Bunk
On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote: On Mon, Feb 25, 2008 at 09:42:09PM +, Steve Brokenshire wrote: Hi, (I've sent this to the linux-kbuild and linux-kernel lists as this patch modifies the Makefile.modinst file. I also don't subscribe to the linux-kbuild

Re: [linux-pm] Fundamental flaw in system suspend, exposed by freezer removal

2008-02-26 Thread David Brownell
On Tuesday 26 February 2008, David Newall wrote: Hardware can be inserted and removed while we're in a suspend state; and there's nothing that we can do about it until we resume. Is it fair to say, then, that having started suspend, we could reasonably ignore any device insertion and

Re: Proposal for proper durable fsync() and fdatasync()

2008-02-26 Thread Nick Piggin
On Tuesday 26 February 2008 18:59, Jamie Lokier wrote: Andrew Morton wrote: On Tue, 26 Feb 2008 07:26:50 + Jamie Lokier [EMAIL PROTECTED] wrote: (It would be nicer if sync_file_range() took a vector of ranges for better elevator scheduling, but let's ignore that :-) Two

Re: [patch 2.6.25-rc2-git 2/2] atmel_tc clocksource/clockevent code

2008-02-26 Thread Haavard Skinnemoen
On Mon, 25 Feb 2008 09:51:16 -0800 David Brownell [EMAIL PROTECTED] wrote: +static cycle_t tc_get_cycles(void) +{ + unsigned long flags; + u32 lower, upper; + + raw_local_irq_save(flags); Why do you need to use the raw version?

Re: [patch 2.6.25-rc2-git 1/2] atmel_tc library

2008-02-26 Thread David Brownell
On Tuesday 26 February 2008, Haavard Skinnemoen wrote: Ok. Let's drop the clock references...  and it will always need a pointer through which to access the registers, so the mid-layer might as well do those things. True about doing the ioremap. ...and keep the regs pointer,

Re: is pci_find_subsys safe to remove?

2008-02-26 Thread Adrian Bunk
On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote: it's not just that it falls under the category of PCI legacy but, if you look in drivers/pci/search.c near the bottom: ... #ifdef CONFIG_PCI_LEGACY EXPORT_SYMBOL(pci_find_device); EXPORT_SYMBOL(pci_find_slot); #endif /*

Re: [patch 1/2] x86, ptrace: support pebs in ds.c

2008-02-26 Thread Ingo Molnar
* Roland McGrath [EMAIL PROTECTED] wrote: Sorry I haven't replied in this thread sooner. I would like to see all the BTS and DS work wait until after 2.6.25. We have a lot of x86 churn in 2.6.25 already, and I think we'd do better without adding this wrinkle at the same time. The

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread Nick Piggin
On Tuesday 26 February 2008 18:21, Gleb Natapov wrote: On Tue, Feb 26, 2008 at 05:11:32PM +1100, Nick Piggin wrote: You are missing one point here. The MPI specifications that have been out there for decades do not require the process use a library for allocating the buffer. I realize

Re: include/linux/pcounter.h

2008-02-26 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Sat, 16 Feb 2008 11:26:18 -0800 On Sat, 16 Feb 2008 13:03:54 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: Yes, per connection basis. Some workloads want to open/close more than 1000 sockets per

Re: [patch 2.6.25-rc2-git 2/2] atmel_tc clocksource/clockevent code

2008-02-26 Thread David Brownell
On Tuesday 26 February 2008, Haavard Skinnemoen wrote: Another way to address that rm9200 issue would be to just rate the TC clockevent source lower than the one based on the system timer, so it's set up but never enabled ... and remember t2_clk, calling clk_enable() only when that

Re: Proposal for proper durable fsync() and fdatasync()

2008-02-26 Thread Jamie Lokier
Jeff Garzik wrote: [snip huge long proposal] Rather than invent new APIs, we should fix the existing ones to _really_ flush data to physical media. Btw, one reason for the length is the current block request API isn't sufficient even to make fsync() durable with _no_ new APIs. It offers

[PATCH] Generalize asm-generic/ioctl.h to allow overriding values.

2008-02-26 Thread Robert P. J. Day
In the spirit of a number of other asm-generic header files, generalize asm-generic/ioctl.h to allow arch-specific ioctl.h headers to simply override _IOC_SIZEBITS and/or _IOC_DIRBITS before including this header file, allowing a number of ioctl.h header files to be shortened considerably.

[PATCH] sata_nv: fix nmi intr or system hanging in rhel4u6 adma.

2008-02-26 Thread Kuan Luo
Hi, robert One customer reported that their system received a nmi interrupt after issuing dd if=/dev/sdb of=/dev/null on a defective disk in rhel4u6. I tested it and found that my system hung both in rhel4u6(2.6.9-67) and 2.6.24-rc7. The patch can work well, but I am not sure if the patch has

Re: is pci_find_subsys safe to remove?

2008-02-26 Thread Robert P. J. Day
On Tue, 26 Feb 2008, Adrian Bunk wrote: On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote: it's not just that it falls under the category of PCI legacy but, if you look in drivers/pci/search.c near the bottom: ... #ifdef CONFIG_PCI_LEGACY

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-26 Thread Jean Delvare
On Mon, 25 Feb 2008 23:39:17 +0100, Martin Michlmayr wrote: * Linus Torvalds [EMAIL PROTECTED] [2008-02-23 12:31]: I'm personally of the opinion that a new driver that doesn't add anything but itself (ie no infrastructure changes etc) is fine. I'd rather have a new, rough driver that might

Re: SMACK or SELinux, but not both

2008-02-26 Thread James Morris
On Tue, 26 Feb 2008, Alexey Dobriyan wrote: If SELinux is registered before SMACK, SMACK panics after register_security() call. If SMACK is registered before SELinux, SELinux panics after register_security() call. Consequently allmodconfig kernel doesn't boot. It would be nice if some

Re: [PATCH] reserve_early end-of-conventional-memory to 1MB

2008-02-26 Thread Ingo Molnar
* Alexander van Heukelum [EMAIL PROTECTED] wrote: Either way, the code should be shared between 32 and 64 bits. There is nothing bitsize-specific about it! Of course. That's also why I already added the old-Dell case ;). But one problem at a time, please! i've applied your patch to

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread Gleb Natapov
On Tue, Feb 26, 2008 at 07:52:41PM +1100, Nick Piggin wrote: On Tuesday 26 February 2008 18:21, Gleb Natapov wrote: On Tue, Feb 26, 2008 at 05:11:32PM +1100, Nick Piggin wrote: You are missing one point here. The MPI specifications that have been out there for decades do not require

Re: [PATCH] Add rdc321x defconfig file

2008-02-26 Thread Ingo Molnar
* Sam Ravnborg [EMAIL PROTECTED] wrote: And asking me to do randconfig is not an option. I have only this machine to work on and with a -j8 build it gets unresponsive at least so much that it irritates me. More defconfigs would just be a constant maintenance drag, they are rather

Re: arcmsr areca-1660 - strange behaviour under heavy load

2008-02-26 Thread Nikola Ciprich
Hi On Sun, 24 Feb 2008, Andrew Morton wrote: Hi Andrew, thanks a lot for reply, I'm attaching requested information. please let me know if You need more information/testing, whatever. I'll be glad to help. BR nik Areca support doesn't seem to be very interested in the problem :-( (cc's

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-26 Thread Ingo Molnar
* H. Peter Anvin [EMAIL PROTECTED] wrote: Yinghai Lu wrote: which is the same. set_cpu_cap() is indeed the cleaner form to do this so your patch is correct as a cleanup. set_cpu_cap is right == set_bit(X86_FEATURE_CONSTANT_TSC, c-x86_capability); === is wrong should be

Re: regression: CD burning (k3b) went broke

2008-02-26 Thread Mike Galbraith
Greetings, I straced both a good and a bad kernel (good being .git with attached revert patch applied) and filtered/diffed/merged the output. Scroll down to HERE to see the problem (resid). I'm poking around, but not having much luck. --- good2008-02-26 09:11:08.0 +0100 +++ bad

[PATCH] [IPMI] remove unused target and action in Makefile

2008-02-26 Thread Denis Cheng
Kbuild system handle this automatically. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- drivers/char/ipmi/Makefile |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile index 553f0a4..eb8a1a8 100644 ---

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread KOSAKI Motohiro
Can you change the spec? Not really. It will break all existing codes. I meant as in eg. submit changes to MPI-3 MPI spec tries to be backward compatible. And MPI-2 spec is 10 years old, but MPI-1 is still in a wider use. HPC is moving fast in terms of HW technology, but slow in

Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

2008-02-26 Thread Pavel Machek
Hi! Andrew is trying to get s2ram to work on Fedora: Please try s2ram, there's good chance it will just work. configure: error: Required libx86 was not found apt-get install libx86-dev? Alternatively, can you post dmidecode? Thinkpads usually work with acpi_sleep=s3_bios,s3_mode ;

Re: [patch 2.6.25-rc3] lockdep: add spin_lock_irq_nested()

2008-02-26 Thread Peter Zijlstra
On Mon, 2008-02-25 at 14:33 -0800, David Brownell wrote: +#ifdef CONFIG_LOCKDEP + +/* tell lockdep that this IRQ's locks and its parent's locks are in + * different categories, so that it won't detect false recursion. + */ +static struct lock_class_key gpio_lock_class; + +static

Re: [PATCH] Compress kernel modules on installation.

2008-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2008 at 11:14:55AM +0200, Adrian Bunk wrote: On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote: On Mon, Feb 25, 2008 at 09:42:09PM +, Steve Brokenshire wrote: Hi, (I've sent this to the linux-kbuild and linux-kernel lists as this patch modifies the

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread dann frazier
On Tue, Feb 26, 2008 at 09:16:25AM +0100, Willy Tarreau wrote: On Mon, Feb 25, 2008 at 09:36:12PM -1000, Glen Nakamura wrote: Aloha, The ext2_readdir() filp-f_pos fix patch looks weird... Perhaps the filp-f_pos += le16_to_cpu(de-rec_len); line should be outside of the if statement like

Re: [PATCH] libata: Register for dock events when the drive is inside a dock station

2008-02-26 Thread Holger Macht
On Fri 22. Feb - 10:34:24, Tejun Heo wrote: If a device/bay is inside a docking station, we need to register for dock events additionally to bay events. If a dock event occurs, the dock driver will call the appropriate handler (ata_acpi_ap_notify() or ata_acpi_dev_notify()) for us.

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2008 at 03:13:46AM -0700, dann frazier wrote: I'm now able to reliably reproduce it by creating/removing a chroot (pbuilder create on a Debian system, though I'm sure a simpler test exists). Correcting the le16_to_cpu placement as Glen described fixes the issue for me. OK

Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

2008-02-26 Thread Alessandro Zummo
On Tue, 26 Feb 2008 10:28:35 +0100 Jean Delvare [EMAIL PROTECTED] wrote: * Linus Torvalds [EMAIL PROTECTED] [2008-02-23 12:31]: I'm personally of the opinion that a new driver that doesn't add anything but itself (ie no infrastructure changes etc) is fine. I'd rather have a new, rough

Re: [RFC] mmiotrace full patch, preview 1

2008-02-26 Thread Ingo Molnar
* Andy Whitcroft [EMAIL PROTECTED] wrote: Ok, so that would be the following, work for everyone? WARNING: mutexes are preferred for single holder semaphores #1: FILE: Z95.c:1: + DECLARE_MUTEX(foo); WARNING: mutexes are preferred for single holder semaphores #3: FILE: Z95.c:3: +

RE: arcmsr areca-1660 - strange behaviour under heavy load

2008-02-26 Thread nickcheng
Hi Nikola, As I said, we will test on our site. Our support team will help you to settle the issue. Sorry for your inconvenience, -Original Message- From: Nikola Ciprich [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 26, 2008 5:36 PM To: Andrew Morton Cc: linux-kernel@vger.kernel.org;

Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount - stack overflow: ide-cd related? dm-related?

2008-02-26 Thread Jiri Kosina
On Mon, 25 Feb 2008, Jan Kara wrote: Yes, exactly two of them. One is non-trivial to get rid of - it's used for encoding of filename before we write it, Why can't we do just UDF: Optimize stack usage Signed-off-by: Jiri Kosina [EMAIL PROTECTED] diff --git a/fs/udf/namei.c

Re: 2.6.24.2-rt2

2008-02-26 Thread Jan Kiszka
Steven Rostedt wrote: We are pleased to announce the 2.6.24.2-rt2 tree, which can be downloaded from the location: http://rt.et.redhat.com/download/ Information on the RT patch can be found at: http://rt.wiki.kernel.org/index.php/Main_Page Changes since 2.6.24-rt1 - ported

Re: [patch 2.6.25-rc3] lockdep: add spin_lock_irq_nested()

2008-02-26 Thread David Brownell
On Tuesday 26 February 2008, Peter Zijlstra wrote: On Mon, 2008-02-25 at 14:33 -0800, David Brownell wrote: +#ifdef CONFIG_LOCKDEP + +/* tell lockdep that this IRQ's locks and its parent's locks are in + * different categories, so that it won't detect false recursion. + */

[PATCH] crypto: switch to proc_create()

2008-02-26 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- crypto/proc.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/crypto/proc.c +++ b/crypto/proc.c @@ -99,11 +99,7 @@ static const struct file_operations proc_crypto_ops = { void __init crypto_init_proc(void) { -

[PATCH] proc: switch to proc_create()

2008-02-26 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- fs/proc/internal.h |2 - fs/proc/nommu.c |2 - fs/proc/proc_misc.c | 66 +--- fs/proc/proc_tty.c |5 --- 4 files changed, 24 insertions(+), 51 deletions(-) ---

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
Hi Neil, On Tue, 2008-02-26 at 17:03 +1100, Neil Brown wrote: On Saturday February 23, [EMAIL PROTECTED] wrote: What is the NFS and net people's take on all of this? Well I'm only vaguely an NFS person, barely a net person, sporadically an mm person, but I've had a look and it seems to

[PATCH] keys: switch to proc_create()

2008-02-26 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- security/keys/proc.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) --- a/security/keys/proc.c +++ b/security/keys/proc.c @@ -70,19 +70,15 @@ static int __init key_proc_init(void) struct proc_dir_entry *p; #ifdef

[PATCH] I found a type miss in fs/ext2/ext2

2008-02-26 Thread ohyama_sec
Hiroyasu Ohyama == Maybe I found a type miss in fs/ext2/ext2.h which is in linux-2.6.24.3, and write difference below. --- *** fs/ext2/ext2.h 2008-02-26 09:20:20.0 +0900 --- fs/ext2/ext2_correct.h 2008-02-26 19:12:55.0 +0900 *** *** 27,33

Re: [RFC] mmiotrace full patch, preview 1

2008-02-26 Thread Andy Whitcroft
On Mon, Feb 25, 2008 at 06:34:49PM -0500, Christoph Hellwig wrote: On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote: the things which it finds. +static DECLARE_MUTEX(kmmio_init_mutex); That's not a mutex. + down(kmmio_init_mutex); It's a semaphore. Please do

[PATCH] proc: switch to proc_create()

2008-02-26 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- fs/proc/internal.h |2 - fs/proc/nommu.c |2 - fs/proc/proc_misc.c | 66 +--- fs/proc/proc_tty.c |5 --- 4 files changed, 24 insertions(+), 51 deletions(-) ---

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-26 Thread Daniel Phillips
I need to respond to this in pieces... first the bit that is bugging me: * two new page flags I need to keep track of two bits of per-cached-page information: (1) This page is known by the cache, and that the cache must be informed if the page is going to go away. I still do not

[PATCH] arch/x86/: switch to proc_create()

2008-02-26 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- arch/x86/kernel/apm_32.c |5 + arch/x86/kernel/cpu/mtrr/if.c |6 ++ 2 files changed, 3 insertions(+), 8 deletions(-) --- a/arch/x86/kernel/apm_32.c +++ b/arch/x86/kernel/apm_32.c @@ -2217,7 +2217,6 @@ static struct

Re: 2.6.25-rc2-mm1 - boot hangs on ia64

2008-02-26 Thread KOSAKI Motohiro
Hi Fujitsu machine can't boot too. my bisect indicate git-sched.patch cause regression too. Thanks. 25-rc2-mm1 is hanging early in boot on my HP ia64 numa platform. I saw the Strange hang on ia64 with CONFIG_PRINTK_TIME=y thread on lkml: http://marc.info/?t=12028839681r=1w=4

Re: [PATCH] Compress kernel modules on installation.

2008-02-26 Thread Sam Ravnborg
On Mon, Feb 25, 2008 at 09:42:09PM +, Steve Brokenshire wrote: Hi, (I've sent this to the linux-kbuild and linux-kernel lists as this patch modifies the Makefile.modinst file. I also don't subscribe to the linux-kbuild and linux-kernel mailing lists so can I have any replies CC'ed to

Re: [PATCH] arch/x86/: switch to proc_create()

2008-02-26 Thread Ingo Molnar
* Alexey Dobriyan [EMAIL PROTECTED] wrote: + proc_create(apm, 0, NULL, apm_file_ops); + proc_create(mtrr, S_IWUSR | S_IRUGO, proc_root, mtrr_fops); thanks, applied. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount - stack overflow: ide-cd related? dm-related?

2008-02-26 Thread Ingo Molnar
* Jiri Kosina [EMAIL PROTECTED] wrote: + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + + if (!name || !fname) { + *err = -ENOMEM; + return NULL; + } + if (dentry) {

Re: 2.6.25-rc2-mm1 - boot hangs on ia64

2008-02-26 Thread Ingo Molnar
* KOSAKI Motohiro [EMAIL PROTECTED] wrote: Fujitsu machine can't boot too. my bisect indicate git-sched.patch cause regression too. hm, that's a bit weird - nothing really should have broken it. Could you try to do a specific bisection of sched-devel.git:

Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount - stack overflow: ide-cd related? dm-related?

2008-02-26 Thread Jiri Kosina
On Tue, 26 Feb 2008, Ingo Molnar wrote: + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + + if (!name || !fname) { + *err = -ENOMEM; + return NULL; + } + if (dentry) {

Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

2008-02-26 Thread Josh Triplett
[I did not see this patch go by on any mailing list, so I replied to the -mm mail and CCed LKML.] [EMAIL PROTECTED] wrote: The patch titled rcu: split list.h and move rcu-protected lists into rculist.h has been added to the -mm tree. Its filename is

Re: [xfs-masters] Re: filesystem corruption on xfs after 2.6.25-rc1 (bisected, powerpc related?)

2008-02-26 Thread Gaudenz Steinlin
On Tue, Feb 26, 2008 at 01:13:56AM +0100, Rafael J. Wysocki wrote: On Tuesday, 26 of February 2008, Christoph Hellwig wrote: On Tue, Feb 26, 2008 at 12:52:56AM +0100, Rafael J. Wysocki wrote: I'm not suggesting a partial revert; I just wonder which part of the change is causing the

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 11:50 +0100, Peter Zijlstra wrote: mm-reserve.patch I'm confused by __mem_reserve_add. + reserve = mem_reserve_root.pages; + __calc_reserve(res, pages, 0); + reserve = mem_reserve_root.pages - reserve; __calc_reserve will always add 'pages'

Re: 2.6.24.2-rt2

2008-02-26 Thread Jan Kiszka
Jan Kiszka wrote: At this chance: We still see the same unbalanced sched-other load on our NUMA box as Gernot once reported [1]: top - 11:19:20 up 4 min, 1 user, load average: 29.52, 9.54, 3.37 Tasks: 502 total, 41 running, 461 sleeping, 0 stopped, 0 zombie Cpu0 :100.0%us, 0.0%sy,

Re: problem with starting 2.5.26-rc1 and latest git

2008-02-26 Thread Jean Delvare
On Mon, 18 Feb 2008 14:28:32 +0100, Jean Delvare wrote: On Thu, 14 Feb 2008 00:27:34 +0100, Mariusz Kozlowski wrote: Of course there is a typo in the subject :) 2.5.25-rc1 - 2.6.25-rc1 Hello, I tried 2.6.25-rc1 and latest git on my laptop (x86 32bit) and have a problem.

2.6.25-rc3: __divdi3 [drivers/crypto/hifn_795x.ko] undefined!

2008-02-26 Thread Martin Michlmayr
With 2.6.25-rc3 and a config file with CONFIG_CRYPTO_DEV_HIFN_795X=m CONFIG_CRYPTO_DEV_HIFN_795X_RNG=y I get the following build error on at least ARM and MIPS: Building modules, stage 2. MODPOST 759 modules ERROR: __divdi3 [drivers/crypto/hifn_795x.ko] undefined! -- Martin Michlmayr

Re: [ofa-general] Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread Robin Holt
On Tue, Feb 26, 2008 at 07:52:41PM +1100, Nick Piggin wrote: On Tuesday 26 February 2008 18:21, Gleb Natapov wrote: On Tue, Feb 26, 2008 at 05:11:32PM +1100, Nick Piggin wrote: You are missing one point here. The MPI specifications that have been out there for decades do not require

Re: 2.6.25-rc3: __divdi3 [drivers/crypto/hifn_795x.ko] undefined!

2008-02-26 Thread Patrick McHardy
Martin Michlmayr wrote: With 2.6.25-rc3 and a config file with CONFIG_CRYPTO_DEV_HIFN_795X=m CONFIG_CRYPTO_DEV_HIFN_795X_RNG=y I get the following build error on at least ARM and MIPS: Building modules, stage 2. MODPOST 759 modules ERROR: __divdi3 [drivers/crypto/hifn_795x.ko] undefined!

Re: [patch 5/6] mmu_notifier: Support for drivers with revers maps (f.e. for XPmem)

2008-02-26 Thread Robin Holt
That is it. That is all our allowed interaction with the users process. OK, when you said something along the lines of the MPT library has control of the comm buffer, then I assumed it was an area of virtual memory which is set up as part of initialization, rather than during runtime. I

Re: [PATCH] Compress kernel modules on installation.

2008-02-26 Thread Adrian Bunk
On Tue, Feb 26, 2008 at 11:22:03AM +0100, Willy Tarreau wrote: On Tue, Feb 26, 2008 at 11:14:55AM +0200, Adrian Bunk wrote: On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote: ... Have you tried keeping the module names intact (.ko, not .ko.gz) ? It's what I was doing with

Re: [PATCH] video: limit stack usage of ir-kbd-i2c.c

2008-02-26 Thread Jean Delvare
Hi Marcin, On Mon, 25 Feb 2008 21:51:00 +0100, Marcin Slusarz wrote: ir_probe allocated struct i2c_client on stack; it's pretty big structure, so allocate it with kzalloc make checkstack output without this patch: x059d ir_probe [ir-kbd-i2c]: 1000 compile tested

[PATCH try #1] Kconfig: cleanup block/Kconfig.iosched help descriptions

2008-02-26 Thread Nick Andrew
Modify the help descriptions of block/Kconfig.iosched for clarity, accuracy and consistency. More information is added to each of the I/O scheduler choices and they are also reordered to improve the flow of information to the user. IOSCHED_CFQ is the default because it distributes the bandwidth

Re: SMACK or SELinux, but not both

2008-02-26 Thread Stephen Smalley
On Tue, 2008-02-26 at 20:28 +1100, James Morris wrote: On Tue, 26 Feb 2008, Alexey Dobriyan wrote: If SELinux is registered before SMACK, SMACK panics after register_security() call. If SMACK is registered before SELinux, SELinux panics after register_security() call.

Re: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.

2008-02-26 Thread Alan Cox
I don't know who told you that or why, but it's obvious nonsense, as this issue shows. Exports should be marked GPL if and only if they cannot be used except in a derivative work. If it is possible to use them without taking sufficient protectable expression, they should not be marked GPL.

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so much cleaner IMO. Also is there a reason why 'struct file *' cannot

Re: [RFC] Disk shock protection (revisited)

2008-02-26 Thread Alan Cox
The general idea: A daemon running in user space monitors input data from an accelerometer. When the daemon detects a critical condition, That sounds like a non starter. What if the box is busy, what if the daemon or something you touch needs memory and causes paging ? Given the accelerometer

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-26 Thread Alan Cox
I agree. I [obviously] missed this when I ack'd, mainly ack'ing the overall change. BIOS certainly may modify that PCI config register, but that's before the kernel boots. So, using pdev-class is fine. I don't think the resume quirk is needed either as the core PCI save/restore code

Re: Print long messages to console from kernel module

2008-02-26 Thread Arvid Brodin
On 2008-02-25 23:27, linux-os (Dick Johnson) wrote: On Mon, 25 Feb 2008, Arvid Brodin wrote: I need to write messages 1023 characters long to the console from a module*. printk() is limited to 1023 characters, and splitting the message over several printk()'s results in a line break and

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 13:45 +0100, Miklos Szeredi wrote: Starting review in the middle, because this is the part I'm most familiar with. New addres_space_operations methods are added: int swapfile(struct address_space *, int); Separate -swapon() and -swapoff() methods would be so

Re: [PATCH] Compress kernel modules on installation.

2008-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2008 at 02:30:16PM +0200, Adrian Bunk wrote: On Tue, Feb 26, 2008 at 11:22:03AM +0100, Willy Tarreau wrote: On Tue, Feb 26, 2008 at 11:14:55AM +0200, Adrian Bunk wrote: On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote: ... Have you tried keeping the module

Doesn't work in 2.6.24.3 either - Was: Re: cd/dvd inaccessible in 2.6.24-rc2

2008-02-26 Thread Felix Homann
Hi, it's still an issue in 2.6.24.3. Syslog looks just like in 2.6.24.2, look here: http://lkml.org/lkml/2008/2/21/241 Latest kernel I've tried with working CD/DVD access was 2.6.23.14. Kind regards, Felix -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

oops when using git gc --auto

2008-02-26 Thread Otavio Salvador
Hello, Today I got this oops, someone has an idea of what's going wrong? Unable to handle kernel paging request at 0200 RIP: [802735c3] find_get_pages+0x3c/0x69 PGD 0 Oops: [1] SMP CPU 3 Modules linked in: sha256_generic aes_generic aes_x86_64 cbc blkcipher

Re: Please, put 64-bit counter per task and incr.by.one each ctxt switch.

2008-02-26 Thread J.C. Pizarro
On 2008/2/25, Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 24 Feb 2008 14:12:47 +0100 J.C. Pizarro [EMAIL PROTECTED] wrote: It's statistic, yes, but it's a very important parameter for the CPU-scheduler. The CPU-scheduler will know the number of context switches of each task before

  1   2   3   4   5   6   >