On Fri, May 05, 2017 at 11:16:59AM -0700, Ricardo Neri wrote: > In its current form, user_64bit_mode() can only be used when CONFIG_X86_64 > is selected. This implies that code built with CONFIG_X86_64=n cannot use > it. If a piece of code needs to be built for both CONFIG_X86_64=y and > CONFIG_X86_64=n and wants to use this function, it needs to wrap it in > an #ifdef/#endif; potentially, in multiple places. > > This can be easily avoided with a single #ifdef/#endif pair within > user_64bit_mode() itself. > > Suggested-by: Borislav Petkov <b...@suse.de> > Cc: Dave Hansen <dave.han...@linux.intel.com> > Cc: Adam Buchbinder <adam.buchbin...@gmail.com> > Cc: Colin Ian King <colin.k...@canonical.com> > Cc: Lorenzo Stoakes <lstoa...@gmail.com> > Cc: Qiaowei Ren <qiaowei....@intel.com> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Cc: Masami Hiramatsu <mhira...@kernel.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Kees Cook <keesc...@chromium.org> > Cc: Thomas Garnier <thgar...@google.com> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Borislav Petkov <b...@suse.de> > Cc: Dmitry Vyukov <dvyu...@google.com> > Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> > Cc: x...@kernel.org > Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> > --- > arch/x86/include/asm/ptrace.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Borislav Petkov <b...@suse.de> -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- -- To unsubscribe from this list: send the line "unsubscribe linux-msdos" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html