Re: [v6 PATCH 05/21] x86/insn-eval: Add utility functions to get register offsets

2017-04-28 Thread Borislav Petkov
On Wed, Apr 26, 2017 at 11:13:44AM -0700, Ricardo Neri wrote: > Masami Hiramatsu had originally requested to add the two functions. I > suppose the unneeded functions could be added if/when needed. Yap, exactly. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane

Re: [v6 PATCH 05/21] x86/insn-eval: Add utility functions to get register offsets

2017-04-26 Thread Ricardo Neri
On Wed, 2017-04-12 at 18:28 +0200, Borislav Petkov wrote: > On Tue, Mar 07, 2017 at 04:32:38PM -0800, Ricardo Neri wrote: > > The function insn_get_reg_offset takes as argument an enumeration that > > Please end function names with parentheses. Will do! > > And do you mean get_reg_offset(),

Re: [v6 PATCH 05/21] x86/insn-eval: Add utility functions to get register offsets

2017-04-12 Thread Borislav Petkov
On Tue, Mar 07, 2017 at 04:32:38PM -0800, Ricardo Neri wrote: > The function insn_get_reg_offset takes as argument an enumeration that Please end function names with parentheses. And do you mean get_reg_offset(), per chance? > indicates the type of offset that is returned: the R/M part of the