Re: [PATCH 0/2] bidi support

2007-05-07 Thread Benny Halevy
Tomo, Thanks for quickly crafting this patchset. Please see my comments in-line below. Putting aside the controversial design issues, we need to carefully compare our patches against yours to make sure no functional issues have been overlooked. Benny FUJITA Tomonori wrote: From: FUJITA

Re: [PATCH 0/2] bidi support

2007-05-07 Thread FUJITA Tomonori
From: Benny Halevy [EMAIL PROTECTED] Subject: Re: [PATCH 0/2] bidi support Date: Mon, 07 May 2007 09:05:37 +0300 Tomo, Thanks for quickly crafting this patchset. Please see my comments in-line below. Putting aside the controversial design issues, we need to carefully compare our patches

[PATCH] zfcp: Stop system after memory corruption

2007-05-07 Thread Swen Schillig
From: Christof Schmitt [EMAIL PROTECTED] For each request that is sent to the FCP adapter, zfcp allocates memory. Status information and data that is being read from the device is written to this memory by the hardware. After that, the hardware signals this via the response queue and zfcp

[PATCH 0/6] qla2xxx: updates for 2.6.22 [8.01.07-k7].

2007-05-07 Thread Andrew Vasquez
This patchset updates the qla2xxx driver to 8.01.07-k7. drivers/scsi/qla2xxx/qla_init.c| 33 - drivers/scsi/qla2xxx/qla_isr.c | 15 ++- drivers/scsi/qla2xxx/qla_os.c |6 ++ drivers/scsi/qla2xxx/qla_version.h |2 +- 4 files

[PATCH 1/6] qla2xxx: Error-out during probe() if we're unable to complete HBA initialization.

2007-05-07 Thread Andrew Vasquez
Remove a stale check against ha-device_flags (DFLG_NO_CABLE) as topology scanning is performed within the DPC-thread context. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git

[PATCH 2/6] qla2xxx: Honor NVRAM port-down-retry-count settings.

2007-05-07 Thread Andrew Vasquez
Hardcoding the qlport_down_retry module-parameter effectively disallowed any user-defined NVRAM setting to go into effect. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 3/6] qla2xxx: Attempt to stop firmware only if it had been previously executed.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 3e296ab..6ad1588 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++

[PATCH 4/6] qla2xxx: Correct pci_set_msi() usage semantics.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 6ad1588..db998d8 100644 ---

[PATCH 6/6] qla2xxx: Update version number to 8.01.07-k7.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index dc85495..c375a4e 100644 ---

[PATCH 5/6] qla2xxx: Add MSI support.

2007-05-07 Thread Andrew Vasquez
Supported ISP types include ISP2422 and revision-2 type ISP2432 chips. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: It looks like the pass-through target support is currently broken, at least as I've checked for ibmvstgt, but I think it's a general problem. I wanted to check my assumptions and get ideas. Yeah, unfortunately, it works only with the iSCSI target driver (which runs in

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread FUJITA Tomonori
From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date: Mon, 07 May 2007 18:24:44 +0400 FUJITA Tomonori wrote: It looks like the pass-through target support is currently broken, at least as I've checked for ibmvstgt, but I think

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date: Mon, 07 May 2007 18:24:44 +0400 FUJITA Tomonori wrote: It looks like the pass-through target support is currently broken, at least as I've checked for

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-07 Thread Kristen Carlson Accardi
On Fri, 04 May 2007 15:30:48 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote: Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index:

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread FUJITA Tomonori
From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date: Mon, 07 May 2007 19:27:23 +0400 FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date:

bidi bsg is non-blocking

2007-05-07 Thread Daniel . E . Messinger
Greetings to all, I'm attempting to use the bidi variant of bsg to talk to an OSD target device. I've run into an undesirable situation. My application has a free-running receive loop (doing a read() on the bsg device) waiting for responses to commands sent to bsg by another thread. The problem

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date: Mon, 07 May 2007 19:27:23 +0400 FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for

Re: [patch 05/30] scsi: remove unnecessary check in drivers/scsi/sg.c

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Eric Sesterhenn [EMAIL PROTECTED] coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Awaiting ACK from dougg James -

Re: [patch 04/30] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: walter harms [EMAIL PROTECTED] Signed-off-by: walter harms [EMAIL PROTECTED] Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Cc: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Need ack from

Re: [PATCH] fill in scsi_host_template module owner

2007-05-07 Thread Mike Christie
Olaf Kirch wrote: I recently ran into an oops that happens because you can shut down all of iSCSI even though you still have iSCSI targets mounted. It turned out that iscsi's scsi_host_template missed a THIS_MODULE, so reference counting wasn't done properly. Brief inspection showed that

Re: [RFC] [PATCH 4/5] qla4xxx: Add IPv6 support and misc

2007-05-07 Thread Mike Christie
David C Somayajulu wrote: Signed-off-by: David Somayajulu [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_mbx.c | 190 ++-- diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 7f28657..0ef777a 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++

Re: [RFC] [PATCH 1/5] qla4xxx: Add IPv6 support and misc

2007-05-07 Thread Mike Christie
David C Somayajulu wrote: Signed-off-by: David Somayajulu [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_def.h | 84 --- drivers/scsi/qla4xxx/ql4_fw.h | 426 +++- diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h

RE: [Bugme-new] [Bug 8426] New: massive slowdown on SCSI CD/DVDdrive connected to mptspi driver

2007-05-07 Thread Doug Chapman
On Fri, 2007-05-04 at 17:58 -0500, James Bottomley wrote: On Fri, 2007-05-04 at 17:56 -0400, Doug Chapman wrote: I am applying/removing _only_ your patch and the problem goes away with just removing it. What id and channel is this DVD drive on? There is a potential bug in the move:

RE: [RFC] [PATCH 4/5] qla4xxx: Add IPv6 support and misc

2007-05-07 Thread David Somayajulu
From: Mike Christie [mailto:[EMAIL PROTECTED] Sent: Monday, May 07, 2007 11:31 AM David C Somayajulu wrote: Signed-off-by: David Somayajulu [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_mbx.c | 190 ++-- diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c

[PATCH] bug fix: SCSI async scan sysfs -EEXIST problem

2007-05-07 Thread James Smart
This corrects the kobject_add -EEXIST failure reported in http://marc.info/?l=linux-scsim=117699334422336w=2 Basically, there was a collision between async scsi scan's scsi_sysfs_add_devices() and asynchronous scanning kicked off by the fc transport's rport code. Both called

Re: [patch 08/30] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Amol Lad [EMAIL PROTECTED] For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Needs ack by maintainer ... cc'd James -

RE: [patch 08/30] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2007-05-07 Thread Patro, Sumant
Ack. Thanks. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Thursday, April 26, 2007 12:35 AM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [patch 08/30]

RE: [Bugme-new] [Bug 8426] New: massive slowdown on SCSI CD/DVDdrive connected to mptspi driver

2007-05-07 Thread Doug Chapman
Found the problem. Sending a patch to linux-scsi under a [PATCH] subject line. - Doug On Fri, 2007-05-04 at 17:58 -0500, James Bottomley wrote: On Fri, 2007-05-04 at 17:56 -0400, Doug Chapman wrote: I am applying/removing _only_ your patch and the problem goes away with just removing it.

RE: [patch 04/30] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-05-07 Thread Patro, Sumant
Ack. Thanks, Sumant -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Thursday, April 26, 2007 12:35 AM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL

Re: [patch 29/30] PCI Error Recovery: Symbios SCSI base support

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Linas Vepstas [EMAIL PROTECTED] Various PCI bus errors can be signaled by newer PCI controllers. This patch adds the PCI error recovery callbacks to the Symbios SCSI device driver. The patch has been tested, and appears to

Re: [patch 25/30] scsi: fix CONFIG_SCSI_WAIT_SCAN=m

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Hugh Dickins [EMAIL PROTECTED] CONFIG_MODULES=y CONFIG_SCSI=y CONFIG_SCSI_SCAN_ASYNC=y CONFIG_SCSI_WAIT_SCAN=m 2.6.21-rc5-mm2 VFS panics unable to find my root on /dev/sda2, but boots okay if I change drivers/scsi/Kconfig

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Richard Knutsson [EMAIL PROTECTED] Convert: FALSE - false TRUE - true NAK'd by maintainer. James - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

Re: [patch 18/30] Fix |/|| confusion in fusion driver

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Dirk Mueller [EMAIL PROTECTED] This patch corrects a |/|| confusion in mptscsih_copy_sense_data. Using || means that the data that ends up being written is (almost always) 1, instead of being bit-wise or'ed. Needs ack by

Re: [patch 09/30] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Amol Lad [EMAIL PROTECTED] Replaced save_flags()/cli() with spin_lock alternatives This one, there's not much point to ... the driver now needs to be converted correctly over to esp_scsi. James - To unsubscribe from this

[PATCH] fix for BZ 8426 - massive slowdown on SCSI CD/DVD drive connected to mptspi driver

2007-05-07 Thread Doug Chapman
Patch for: http://bugzilla.kernel.org/show_bug.cgi?id=8426 A recent code cleanup that moved code from mptscsih to mptspi inadvertently change the order some code was called. This caused a massive slowdown (of 150x to 300x) on the CD/DVD drive on the high-end HP Integrity servers. Signed-off-by:

Re: [patch 04/30] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-05-07 Thread Andrew Morton
On Mon, 7 May 2007 13:40:54 -0600 Patro, Sumant [EMAIL PROTECTED] wrote: Ack. Thanks. Please consider raising a patch adding yourself to ./MAINTAINERS? - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread Andrew Morton
On Mon, 7 May 2007 14:06:56 -0700 Andrew Morton [EMAIL PROTECTED] wrote: so I'll drop it on those grounds, not on the bogus ones. However it will come back again. All subsystem-private implementations of TRUE and FALSE are in the firing line now. - To unsubscribe from this list: send the line

[PATCH 1/1] ipr: Use PCI-E reset API for new ipr adapter

2007-05-07 Thread Brian King
Use a newly added PCI API to issue a PCI Fundamental reset (warm reset) to a new ipr PCI-E adapter. Typically, the ipr adapter uses the start BIST bit in config space to reset an adapter. Issuing start BIST on this particular adapter results in the PCI-E logic on the card losing sync, which

[PATCH v2] add bidi support for block pc requests

2007-05-07 Thread FUJITA Tomonori
Here is an updated version of the patch to add bidi support to block pc requests. Bugs spotted by Benny were fixed. This patch can be applied cleanly to the scsi-misc git tree and is on the top of the following patch to add linked request support:

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread Richard Knutsson
Andrew Morton wrote: On Mon, 7 May 2007 14:06:56 -0700 Andrew Morton [EMAIL PROTECTED] wrote: so I'll drop it on those grounds, not on the bogus ones. However it will come back again. All subsystem-private implementations of TRUE and FALSE are in the firing line now. Amen. But

Re: [Stgt-devel] Question for pass-through target design

2007-05-07 Thread Vladislav Bolkhovitin
Vladislav Bolkhovitin wrote: FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: [Stgt-devel] Question for pass-through target design Date: Mon, 07 May 2007 19:27:23 +0400 FUJITA Tomonori wrote: From: Vladislav Bolkhovitin [EMAIL PROTECTED] Subject: Re: