Re: [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock

2013-04-01 Thread Robert Jennings
* Brian King (brk...@linux.vnet.ibm.com) wrote: No locks should be held when calling scsi_adjust_queue_depth so drop the lock in slave_configure prior to calling it. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi

Re: [PATCH 1/5] ibmvfc: Properly set cancel flags when cancelling abort

2013-04-16 Thread Robert Jennings
. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_abort_cancel_flags drivers/scsi/ibmvscsi

Re: [PATCH 2/5] ibmvfc: Support FAST_IO_FAIL in EH handlers

2013-04-16 Thread Robert Jennings
recovers. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 69 ++--- 1 file changed, 52 insertions(+), 17 deletions(-) diff -puN drivers/scsi/ibmvscsi/ibmvfc.c

Re: [PATCH 3/5] ibmvfc: Send cancel when link is down

2013-04-16 Thread Robert Jennings
to prevent error handling from failing and/or escalating. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff -puN drivers/scsi

Re: [PATCH 4/5] ibmvfc: Suppress ABTS if target gone

2013-04-16 Thread Robert Jennings
-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 13 +++-- drivers/scsi/ibmvscsi/ibmvfc.h |3 ++- 2 files changed, 9 insertions(+), 7 deletions(-) diff -puN drivers/scsi/ibmvscsi/ibmvfc.c

Re: [PATCH 5/5] ibmvfc: Driver version 1.0.11

2013-04-16 Thread Robert Jennings
* Brian King (brk...@linux.vnet.ibm.com) wrote: Bump driver version to 1.0.11. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/1] [v2] ibmvscsi: Prevent IO during partner login

2007-11-01 Thread Robert Jennings
0 would result in all events being sent rather than returning SCSI_MLQUEUE_HOST_BUSY; this has also been fixed by this patch. Signed-off-by: Robert Jennings [EMAIL PROTECTED] Signed-off-by: Brian King [EMAIL PROTECTED] --- drivers/scsi/ibmvscsi/ibmvscsi.c | 59

Re: [PATCH 1/1] [v2] ibmvscsi: requeue while CRQ closed

2007-11-12 Thread Robert Jennings
-by: Robert Jennings [EMAIL PROTECTED] Signed-off-by: Brian King [EMAIL PROTECTED] --- drivers/scsi/ibmvscsi/ibmvscsi.c | 59 --- 1 file changed, 48 insertions(+), 11 deletions(-) Index: linux-2.6/drivers/scsi/ibmvscsi/ibmvscsi.c

[PATCH 1/1] ibmvscsi: retry on H_DROPPED during send_crq

2007-12-05 Thread Robert Jennings
send_srp_login are not checking the return code. We could get H_DROPPED or H_CLOSED and in that case we should reset and retry. Signed-off-by: Robert Jennings [EMAIL PROTECTED] --- drivers/scsi/ibmvscsi/ibmvscsi.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) Index: b

Re: [PATCH] Update Maintainers for IBM Power 842, vscsi, and vfc drivers

2014-04-11 Thread Robert Jennings
Fontenot nf...@linux.vnet.ibm.com Nathan, sorry I didn't take care of this before I gave up r...@linux.ibm.com. Acked-by: Robert Jennings r...@pochix.net --- MAINTAINERS | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) Index: linux/MAINTAINERS

Re: [Stgt-devel] Question for pass-through target design

2007-05-24 Thread Robert Jennings
* Vladislav Bolkhovitin ([EMAIL PROTECTED]) wrote: Robert Jennings wrote: What I meant that is that the kernel tgt code (scsi_tgt*) receives SCSI commands from one lld and send them to another lld instead of sending them to user space. Although the approach of passing SCSI commands from

[PATCH 0/2] ibmvscsi: dynamic request_limit and device restart

2007-02-09 Thread Robert Jennings
There are two fixes for the ibmvscsi client driver in this set. - Dynamic request_limit The request_limit for the driver was not properly reflecting the value on the server side and could cause can_queue to be set to improper values (-1). The patch corrects this so that request_limit mirrors the

[PATCH 2/2] [v2] ibmvscsi: add slave_configure to allow device restart

2007-02-13 Thread Robert Jennings
The first version of this patch had the incorrect type for the lock_flags variable. Adding a slave_configure function for the driver. Now the disks can be restarted by the scsi mid-layer when the are disconnected and reconnected. Signed-off-by: Robert Jennings [EMAIL PROTECTED] --- drivers/scsi

[PATCH 0/2][resend] ibmvscsi: dynamic request_limit and device restart

2007-03-28 Thread Robert Jennings
James, Resending these patches for inclusion in your tree. There are two fixes for the ibmvscsi client driver in this set. - Dynamic request_limit The request_limit for the driver was not properly reflecting the value on the server side and could cause can_queue to be set to improper values

[PATCH 1/2] ibmvscsi: allow for dynamic adjustment of server request_limit

2007-03-28 Thread Robert Jennings
The request limit calculations used previously on the client failed to mirror the state of the server. Additionally, when a value 3 was provided there could be problems setting can_queue and handling abort and reset commands. Signed-off-by: Robert Jennings [EMAIL PROTECTED] Signed-off

Re: [PATCH 2/2] ibmvscsi: add slave_configure to allow device restart

2007-03-29 Thread Robert Jennings
Fixed the kernel-doc comment for ibmvscsi_slave_configure. Thanks to Randy Dunlap for catching that. Adding a slave_configure function for the driver. Now the disks can be restarted by the scsi mid-layer when the are disconnected and reconnected. Signed-off-by: Robert Jennings [EMAIL PROTECTED

Re: [PATCH] scsi/ibmvscsi: add module alias for ibmvscsic

2012-07-31 Thread Robert Jennings
On Tue, Jul 31, 2012 at 11:20 AM, Brian King brk...@linux.vnet.ibm.com wrote: On 07/30/2012 10:08 PM, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 21:06 +0200, Olaf Hering wrote: So while this would work, I do wonder however whether we could instead fix it by simplifying the whole

[PATCH] ibmvscsi: Add maintainer for IBM virtual SCSI/FC drivers

2012-07-31 Thread Robert Jennings
Add a MAINTAINERS entry for the IBM Power Virtual SCSI and FC device drivers. Signed-off-by: Robert Jennings r...@linux.vnet.ibm.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fb036a0..f441c46 100644

Re: [PATCH] scsi/ibmvscsi: /sys/class/scsi_host/hostX/config doesn't show any information

2012-08-16 Thread Robert Jennings
is our standard PAGE_SIZE) doesn't work and result in an empty config from the server. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org CC: sta...@vger.kernel.org Acked-by: Robert Jennings r...@linux.vnet.ibm.com Tested with an IBM i host and confirmed the fix. --- diff --git

Re: [PATCH] scsi/ibmvscsi: add module alias for ibmvscsic

2012-09-07 Thread Robert Jennings
matches the driver hotplug name and fixes auto-load issues. Signed-off-by: Benjamin Herrenschmidt benh@kernel.crashing. I've give this a quick test and I prefer this cleanup, it solves the initial problem nicely. James, please consider pulling this patch. Thanks. Acked-by: Robert Jennings r

Re: [PATCH] scsi/ibmvscsi: /sys/class/scsi_host/hostX/config doesn't show any information

2012-09-07 Thread Robert Jennings
in an empty config from the server. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org CC: sta...@vger.kernel.org James, can this be added to your for-next branch so that we can also get this to the stable trees? Thanks. Acked-by: Robert Jennings r...@linux.vnet.ibm.com --- diff