Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Mon, May 25, 2026 at 04:55:04PM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 21.05.2026 um 13:53 +0200 schrieb Jürgen > Spitzmüller: > > Color > > > > taking the first one for both modes if only one is specified. > > Implemented at c962f7b8708f > > Expect it to have rough edges. Great, thank you! I will be testing. Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Am Donnerstag, dem 21.05.2026 um 13:53 +0200 schrieb Jürgen Spitzmüller: > Color > > taking the first one for both modes if only one is specified. Implemented at c962f7b8708f Expect it to have rough edges. -- Jürgen -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Thu, May 21, 2026 at 01:53:56PM +0200, Jürgen Spitzmüller wrote: > Scott Kostyshak schrieb am 21.05.2026 10:03 (GMT +02:00): > > The problem is that I have a *lot* of custom insets. And it helps for > > them to have different colors from each other so I can quickly > > distinguish which is which based on the color (and without having to > > read the label). I see there is textlabel1 up to textlabel3. But I would > > need much more than that. Not sure there is any ideal solution. > > One solution that has been proposed (#12462) is to extend the color > definition in layouts from > > Color > > to > > Color > > taking the first one for both modes if only one is specified. > > This makes sense and is probably not too hard to implement, but I need to > find time for it. > > Note, though, that this remains sub-optimal when color themes are being used. That all makes sense, thank you! Colors are tricky. Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Scott Kostyshak schrieb am 21.05.2026 10:03 (GMT +02:00): > The problem is that I have a *lot* of custom insets. And it helps for > them to have different colors from each other so I can quickly > distinguish which is which based on the color (and without having to > read the label). I see there is textlabel1 up to textlabel3. But I would > need much more than that. Not sure there is any ideal solution. One solution that has been proposed (#12462) is to extend the color definition in layouts from Color to Color taking the first one for both modes if only one is specified. This makes sense and is probably not too hard to implement, but I need to find time for it. Note, though, that this remains sub-optimal when color themes are being used. Jürgen > > Thanks, > Scott > > -- > lyx-devel mailing list > [email protected] > https://lists.lyx.org/mailman/listinfo/lyx-devel > -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Thu, May 21, 2026 at 09:25:30AM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 21.05.2026 um 08:48 +0200 schrieb Scott Kostyshak: > > > UI colors should be set to fit well with the UI in > > > the first place. > > > > I don't understand this statement. Are you saying that the reason the > > colors don't match is because of the poor color choice for the custom > > layout? > > No. When you say "red" in a layout file, we assume you want to see red. > We assume you select a color that works well in the work area. > > As opposed to that, we you select "red" as a text color, we assume you > want to see this color in the output (e.g., PDF), but in the workarea, > as with black (default) text color, we try to make it more readable if > the background color does not match the output (PDF) background color. > > In general, I would always suggest to use semantic colors (such as > textlabel1) for UI elements, as they do have dedicated dark and light > settings. Ahhh I see. That of course makes a lot of sense. Thanks for the explanation. The problem is that I have a *lot* of custom insets. And it helps for them to have different colors from each other so I can quickly distinguish which is which based on the color (and without having to read the label). I see there is textlabel1 up to textlabel3. But I would need much more than that. Not sure there is any ideal solution. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Am Donnerstag, dem 21.05.2026 um 08:48 +0200 schrieb Scott Kostyshak: > > UI colors should be set to fit well with the UI in > > the first place. > > I don't understand this statement. Are you saying that the reason the > colors don't match is because of the poor color choice for the custom > layout? No. When you say "red" in a layout file, we assume you want to see red. We assume you select a color that works well in the work area. As opposed to that, we you select "red" as a text color, we assume you want to see this color in the output (e.g., PDF), but in the workarea, as with black (default) text color, we try to make it more readable if the background color does not match the output (PDF) background color. In general, I would always suggest to use semantic colors (such as textlabel1) for UI elements, as they do have dedicated dark and light settings. -- Jürgen -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Thu, May 21, 2026 at 06:48:24AM +0200, Jürgen Spitzmüller wrote: > Am Dienstag, dem 19.05.2026 um 21:01 +0200 schrieb Scott Kostyshak: > > 1. The text inside the inset is not the same color as the text of the > > label. Is this expected? > > I won't change this. I actually kind of like it, anyway. > UI colors should be set to fit well with the UI in > the first place. I don't understand this statement. Are you saying that the reason the colors don't match is because of the poor color choice for the custom layout? > > 2. The text color of a quote is the color of the label. I would > > expect it to be the color of the text. > > This is fixed with 37df97c9d3c9 Thanks! Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Am Dienstag, dem 19.05.2026 um 21:01 +0200 schrieb Scott Kostyshak: > 1. The text inside the inset is not the same color as the text of the > label. Is this expected? I won't change this. UI colors should be set to fit well with the UI in the first place. > 2. The text color of a quote is the color of the label. I would > expect it to be the color of the text. This is fixed with 37df97c9d3c9 -- Jürgen -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Wed, May 20, 2026 at 08:18:22AM +0200, Jürgen Spitzmüller wrote: > Scott Kostyshak schrieb am 19.05.2026 21:01 (GMT +02:00): > > On current master (i.e., on 4fd29561), open the attached document. A > > couple of things are interesting: > > > > 1. The text inside the inset is not the same color as the text of the > >label. Is this expected? > > > > 2. The text color of a quote is the color of the label. I would expect > >it to be the color of the text. > > Somewhat expected. Inset color is not yet handled. OK thanks. Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Scott Kostyshak schrieb am 19.05.2026 21:01 (GMT +02:00): > On current master (i.e., on 4fd29561), open the attached document. A > couple of things are interesting: > > 1. The text inside the inset is not the same color as the text of the >label. Is this expected? > > 2. The text color of a quote is the color of the label. I would expect >it to be the color of the text. Somewhat expected. Inset color is not yet handled. Jürgen > -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Tue, May 19, 2026 at 09:01:35PM +0200, Scott Kostyshak wrote: > On Sat, May 16, 2026 at 07:16:24AM +, Juergen Spitzmueller wrote: > > commit 67a87d81f4d58f33306a25532010cecb05d22270 > > Author: Juergen Spitzmueller > > Date: Sat May 16 09:15:43 2026 +0200 > > > > Improve readability of dark text colors in dark mode (#13218) > > --- > > src/RowPainter.cpp | 12 +--- > > src/frontends/qt/GuiPainter.cpp | 8 +++- > > 2 files changed, 16 insertions(+), 4 deletions(-) > > > > On current master (i.e., on 4fd29561), open the attached document. A > couple of things are interesting: > > 1. The text inside the inset is not the same color as the text of the >label. Is this expected? > > 2. The text color of a quote is the color of the label. I would expect >it to be the color of the text. > > As usualy, it may be my color settings. Forgot to attach. Now attaching. Scott example.lyx Description: application/lyx signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Sat, May 16, 2026 at 07:16:24AM +, Juergen Spitzmueller wrote: > commit 67a87d81f4d58f33306a25532010cecb05d22270 > Author: Juergen Spitzmueller > Date: Sat May 16 09:15:43 2026 +0200 > > Improve readability of dark text colors in dark mode (#13218) > --- > src/RowPainter.cpp | 12 +--- > src/frontends/qt/GuiPainter.cpp | 8 +++- > 2 files changed, 16 insertions(+), 4 deletions(-) > On current master (i.e., on 4fd29561), open the attached document. A couple of things are interesting: 1. The text inside the inset is not the same color as the text of the label. Is this expected? 2. The text color of a quote is the color of the label. I would expect it to be the color of the text. As usualy, it may be my color settings. Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Tue, May 19, 2026 at 02:27:49PM +0200, Jürgen Spitzmüller wrote: > Scott Kostyshak schrieb am 18.05.2026 22:39 (GMT +02:00): > > Starting with this commit, I seem to lose some color. See the attached > > screenshots. One is from 2.4.0 and one is from current master. > > > > Notice, specifically, the text in the "Frame title" inset is now white > > instead of blue. And same for the structure inset. > > > > Perhaps it is specific to my color set up? Can you reproduce? > > Yes. The issue is that we shouldn't try to fiddle with dynamic colors that > have > sensible values for dark mode (as opposed to fixed one such as "blue" that are > the same in both modes). > > (However, it also might indicate that the color we use here might be a bit too > dark for dark mode) > > Should be fixed with 4fd295618a9 > > Thanks for the report! Tested and looks good, thanks! Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
Scott Kostyshak schrieb am 18.05.2026 22:39 (GMT +02:00): > Starting with this commit, I seem to lose some color. See the attached > screenshots. One is from 2.4.0 and one is from current master. > > Notice, specifically, the text in the "Frame title" inset is now white > instead of blue. And same for the structure inset. > > Perhaps it is specific to my color set up? Can you reproduce? Yes. The issue is that we shouldn't try to fiddle with dynamic colors that have sensible values for dark mode (as opposed to fixed one such as "blue" that are the same in both modes). (However, it also might indicate that the color we use here might be a bit too dark for dark mode) Should be fixed with 4fd295618a9 Thanks for the report! Jürgen -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve readability of dark text colors in dark mode (#13218)
On Sat, May 16, 2026 at 07:16:24AM +, Juergen Spitzmueller wrote: > commit 67a87d81f4d58f33306a25532010cecb05d22270 > Author: Juergen Spitzmueller > Date: Sat May 16 09:15:43 2026 +0200 > > Improve readability of dark text colors in dark mode (#13218) > --- > src/RowPainter.cpp | 12 +--- > src/frontends/qt/GuiPainter.cpp | 8 +++- > 2 files changed, 16 insertions(+), 4 deletions(-) > Starting with this commit, I seem to lose some color. See the attached screenshots. One is from 2.4.0 and one is from current master. Notice, specifically, the text in the "Frame title" inset is now white instead of blue. And same for the structure inset. Perhaps it is specific to my color set up? Can you reproduce? Thanks for your work on this! Scott signature.asc Description: PGP signature -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
