On Tue, Mar 22, 2016 at 8:55 PM, Rowley, Timothy O
wrote:
>
>> On Mar 22, 2016, at 3:51 PM, Justen, Jordan L
>> wrote:
>>
>> What does 532172 in the subject refer to?
>
> swr rasterizer development happens in another source control system.
On Wednesday, March 23, 2016 3:55:10 AM PDT Rowley, Timothy O wrote:
>
> > On Mar 22, 2016, at 3:51 PM, Justen, Jordan L
wrote:
> >
> > What does 532172 in the subject refer to?
>
> swr rasterizer development happens in another source control system. 532172
is a
On 2016-03-22 20:55:10, Rowley, Timothy O wrote:
>
> > On Mar 22, 2016, at 3:51 PM, Justen, Jordan L
> > wrote:
> >
> > What does 532172 in the subject refer to?
>
> swr rasterizer development happens in another source control system.
> 532172 is a revision id to
On 22.03.2016 05:41, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Results are undefined but may not crash. Without this change, out-of-bounds
> indexing can lead to VM faults and GPU hangs.
>
> Constant buffers, samplers, and possibly others will eventually need
> On Mar 22, 2016, at 3:51 PM, Justen, Jordan L
> wrote:
>
> What does 532172 in the subject refer to?
swr rasterizer development happens in another source control system. 532172 is
a revision id to checkpoint where we’ve pushed the changes publicly.
> From this
On 23.03.2016 02:27, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_state.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c
> b/src/gallium/drivers/radeonsi/si_state.c
>
Signed-off-by: Edward O'Callaghan
---
src/mesa/state_tracker/st_extensions.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
index b03f531..6645189 100644
---
Signed-off-by: Edward O'Callaghan
---
src/mesa/state_tracker/st_extensions.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
index 2fdaba0..b03f531 100644
The only functional change in this series is taking off the breaks on
higher GLSL versions than 4.1. This will likely be relevant by weeks
end.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
Signed-off-by: Edward O'Callaghan
---
src/gallium/drivers/radeon/r600_query.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/r600_query.c
b/src/gallium/drivers/radeon/r600_query.c
index f8b6241..f9a5721 100644
---
Reviewed-by: Edward O'Callaghan
On 2016-03-23 04:27, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
v2: Fixed regression pointed out by Eduardo Lima Mitev
Allow the sequence operator to be a constant expression in GLSL ES versions
prior
to GLSL ES 3.0
Fixes the following piglit test:
/all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert
This is similar to the logic
You are correct, it should be state->is_version(120, 300).
I will submit an updated patch.
On Tue, Mar 22, 2016 at 3:32 PM, Eduardo Lima Mitev
wrote:
> On 03/22/2016 02:48 PM, Lars Hamre wrote:
>
>> Resending this patch because it received no response last week.
>>
>> Allow
>> + int dim;
>> + switch (tgsi_tex) {
>> + case TGSI_TEXTURE_BUFFER:
>> + case TGSI_TEXTURE_1D:
>> + dim = 1;
>> + break;
>> + case TGSI_TEXTURE_2D:
>> + case TGSI_TEXTURE_RECT:
>> + case TGSI_TEXTURE_1D_ARRAY:
>> + case TGSI_TEXTURE_2D_MSAA:
>> + dim = 2;
>> +
On 23 March 2016 at 01:37, Brian Paul wrote:
> On 03/21/2016 04:02 PM, Dave Airlie wrote:
>>
>> From: Dave Airlie
>>
>> This is a mask of which of the current 2x2 grid are non-helper
>> invocations. This allows us to mask off the helper invocations
>> later
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 1 -
src/mesa/drivers/dri/i965/brw_fs.h | 2 --
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 -
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 ---
4 files changed, 15 deletions(-)
diff --git
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++--
src/mesa/drivers/dri/i965/brw_fs.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 6c7c8cd..2d12449 100644
---
Now that we have MOV_INDIRECT opcodes, we have all of the size information
we need directly in the opcode. With a little restructuring of the
algorithm used in assign_constant_locations we don't need param_size
anymore. The big thing to watch out for now, however, is that you can have
two ranges
Unfortunately, this also means that we need to use a slightly different
algorithm for assign_constant_locations. The old algorithm worked based on
the assumption that each read of a uniform value read exactly one float.
If it encountered a MOV_INDIRECT, it would immediately bail and push the
It's not really doing enough anymore to justify a helper function.
---
src/mesa/drivers/dri/i965/brw_vec4.h | 2 --
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 37 ++
2 files changed, 14 insertions(+), 25 deletions(-)
diff --git
It should work fine without it and the visitor can set it if it wants.
---
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
index c883fe3..35400cb
---
src/compiler/nir/nir.h| 7 +++
src/compiler/nir/nir_intrinsics.h | 6 +-
src/compiler/nir/nir_lower_io.c | 5 +
src/compiler/nir/nir_print.c | 1 +
4 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
We aren't using it anymore.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +--
src/mesa/drivers/dri/i965/brw_ir_fs.h | 5 +
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 2cf093a..57397f2
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index eaff953..7d15794 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++
---
src/mesa/drivers/dri/i965/brw_vec4.cpp| 8
src/mesa/drivers/dri/i965/brw_vec4.h | 2 --
src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 9 -
src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp| 2 --
Instead of using reladdr, this commit changes the FS backend to emit a
MOV_INDIRECT whenever we need an indirect uniform load. We also have to
rework some of the other bits of the backend to handle this new form of
uniform load. The obvious change is that demote_pull_constants now acts
more like
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 1a62029..6c7c8cd 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++
While we're at it, we also add support for the possibility that the
indirect is, in fact, a constant. This shouldn't happen in the common case
(if it does, that means NIR failed to constant-fold something), but it's
possible so we should handle it.
---
src/mesa/drivers/dri/i965/brw_fs.cpp
The subnr field is in bytes so we don't need to multiply by type_sz.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 7d15794..d41c8a8 100644
---
This commit moves us to an instruction based model rather than a
register-based model for indirects. This is more accurate anyway as we
have to emit instructions to resolve the reladdr. It's also a lot simpler
because it gets rid of the recursive reladdr problem by design.
One side-effect of
This is mostly a re-send of a patch series I've had floating around in one
form or a while for quite some time. It's basically the same except that
the original version was missing a work-around for Sandy Bridge. For a
while, I wasn't really pushing to get it merged because I couldn't
On Tuesday, March 22, 2016 2:31:42 PM PDT Ian Romanick wrote:
> On 03/17/2016 09:18 AM, Martin Peres wrote:
> > On 16/03/16 19:33, Kenneth Graunke wrote:
> >> The SIN and COS instructions on Intel hardware can produce values
> >> slightly outside of the [-1.0, 1.0] range for a small set of values.
https://bugs.freedesktop.org/show_bug.cgi?id=94512
--- Comment #5 from EoD ---
(In reply to Michel Dänzer from comment #4)
> Sounds like it's not a driver specific issue then but a general one with
> GLX-TLS on x32.
X did not segfault when I used my Barts (radeon + r600) instead of
On 03/17/2016 09:18 AM, Martin Peres wrote:
> On 16/03/16 19:33, Kenneth Graunke wrote:
>> The SIN and COS instructions on Intel hardware can produce values
>> slightly outside of the [-1.0, 1.0] range for a small set of values.
>> Obviously, this can break everyone's expectations about trig
I thought I already had this patch, but it looks like it was on my to-do
list. I had patches to use GL_ARB_explicit_uniform_location, and those
needed GL_ARB_explicit_attrib_location (to get the layout keyword).
https://patchwork.freedesktop.org/patch/74220/ (and others... I'm not
sure why I
What does 532172 in the subject refer to?
On 2016-03-22 12:45:48, Tim Rowley wrote:
> Highlights include:
> * code style fixes
> * start removing win32 types
> * switch DC/DS rings to ringbuffer datastructure
> * rdtsc bucket support for shaders
> * address some coverity issues
> *
On 22.03.2016 12:27, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index
On Tue, Mar 22, 2016 at 9:15 PM, Marek Olšák wrote:
> On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote:
>> From: Nicolai Hähnle
>>
>> ---
>> src/gallium/drivers/radeonsi/si_descriptors.c | 61 +-
>>
Reviewed-by: Jason Ekstrand
On Tue, Mar 22, 2016 at 12:35 PM, Rob Clark wrote:
> From: Rob Clark
>
> In many places, the convention is to pass an existing ssadef name ptr
> when construction/initializing a new nir_ssa_def.
On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> ---
> src/gallium/drivers/radeonsi/si_descriptors.c | 61 +-
> src/gallium/drivers/radeonsi/si_pipe.h| 1 +
>
On 03/22/2016 09:01 PM, Iurie wrote:
hello,
where is possible to see the history of the dusscutions in the mailing list?
https://lists.freedesktop.org/archives/mesa-dev/
thanks
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
hello,
where is possible to see the history of the dusscutions in the mailing list?
thanks
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Sure, no problem.
- Bas
On Tue, Mar 22, 2016 at 8:27 PM, Brian Paul wrote:
> If you can wait until tomorrow, Bas, I'll do an overight piglit run to check
> for regressions.
>
> -Brian
>
>
> On 03/22/2016 12:31 PM, Marek Olšák wrote:
>>
>> Reviewed-by: Marek Olšák
From: Rob Clark
In many places, the convention is to pass an existing ssadef name ptr
when construction/initializing a new nir_ssa_def. But that goes badly
(as noticed by garbage in nir_print output) when the original string
gets freed.
Just use ralloc_strdup()
On 03/22/2016 02:48 PM, Lars Hamre wrote:
Resending this patch because it received no response last week.
Allow the sequence operator to be a constant expression in GLSL ES versions
prior
to GLSL ES 3.0
Fixes the following piglit test:
If you can wait until tomorrow, Bas, I'll do an overight piglit run to
check for regressions.
-Brian
On 03/22/2016 12:31 PM, Marek Olšák wrote:
Reviewed-by: Marek Olšák
Somebody from Intel or VMWare might want to take a look too.
Marek
On Tue, Mar 22, 2016 at 2:58 AM,
Reviewed-by: Marek Olšák
Marek
On Mon, Mar 21, 2016 at 9:41 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Results are undefined but may not crash. Without this change, out-of-bounds
> indexing can lead to VM faults and
https://bugs.freedesktop.org/show_bug.cgi?id=94088
Steve Langasek changed:
What|Removed |Added
Resolution|--- |FIXED
On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote:
> Hi,
>
> since shader images have laid most of the foundation, here are shader buffers
> now. This is the last extension missing for OpenGL 4.2 (we still need to turn
> on GLSL 4.2, but I think that only involves
Reviewed-by: Marek Olšák
Somebody from Intel or VMWare might want to take a look too.
Marek
On Tue, Mar 22, 2016 at 2:58 AM, Bas Nieuwenhuizen
wrote:
> This removes any dependency on driver validation of the number of
> framebuffer samples.
>
>
Right now, we have phi placement code in two places and there are other
places where it would be nice to be able to do this analysis. Instead of
repeating it all over the place, this commit adds a helper for placing all
of the needed phi nodes for a value.
v2: Add better documentation
On Tue, Mar 22, 2016 at 8:46 AM, Michel Dänzer wrote:
> On 22.03.2016 05:34, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote:
>>
>> URL:
>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=e85cf35a6516c44e33663fcd9637c6b434bb63ee
>> Author: Nicolai Hähnle
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index b9bdd47..b8fde00 100644
---
On Mar 22, 2016 8:19 AM, "Samuel Iglesias Gonsálvez"
wrote:
>
>
>
> On 21/03/16 23:56, Jason Ekstrand wrote:
> > On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez <
> > sigles...@igalia.com> wrote:
> >
> >> From: Iago Toral Quiroga
> >>
> >> ---
On Mar 22, 2016 8:18 AM, "Samuel Iglesias Gonsálvez"
wrote:
>
>
>
> On 21/03/16 23:54, Jason Ekstrand wrote:
> > On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <
> > sigles...@igalia.com> wrote:
> >
> >> From: Iago Toral Quiroga
> >>
> >>
On Tue, Mar 22, 2016 at 1:06 AM, dw kim wrote:
> On Mon, Mar 21, 2016 at 08:35:20PM +0100, Marek Olšák wrote:
>> On Wed, Mar 9, 2016 at 2:28 AM, Dongwon Kim wrote:
>> > This patch enables an EGL extension, EGL_KHR_reusable_sync.
>> > This new
On 03/21/2016 03:03 PM, Anuj Phogat wrote:
I don't have a hardware which supports this extension and I realized it
after writing these patches. This blocks the testing of these patches.
So, I'm sure there will be few things left out in this series. But I
think it'll be nice to have 90% of the
On 22/03/16 16:19, Samuel Iglesias Gonsálvez wrote:
>
>
> On 21/03/16 23:56, Jason Ekstrand wrote:
>> On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez <
>> sigles...@igalia.com> wrote:
>>
>>> From: Iago Toral Quiroga
>>>
>>> ---
>>>
https://bugs.freedesktop.org/show_bug.cgi?id=94088
--- Comment #3 from Roland Scheidegger ---
(In reply to Steve Langasek from comment #2)
> Hello,
>
> The patch for this bug is incomplete. In between the calls to
> pipe_barrier_init() and pipe_barrier_destroy() are calls
On 03/21/2016 04:02 PM, Dave Airlie wrote:
From: Dave Airlie
This adds support for load/store/atomic operations on images
along with image tracking support.
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/draw/draw_gs.c | 2 +-
A bunch of nit-picks below.
Overall, I'd like to see more comments on the new functions to explain
what's going on.
On 03/21/2016 04:02 PM, Dave Airlie wrote:
From: Dave Airlie
This adds support for ARB_shader_image_load_store to softpipe.
Signed-off-by: Dave Airlie
On 03/21/2016 04:02 PM, Dave Airlie wrote:
From: Dave Airlie
This is a mask of which of the current 2x2 grid are non-helper
invocations. This allows us to mask off the helper invocations
later for the image operations.
Can you elaborate on what a helper invocation is
In the subject, should that be "address" instead of "array"?
On 03/21/2016 04:02 PM, Dave Airlie wrote:
From: Dave Airlie
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/tgsi/tgsi_exec.h | 6 --
1 file changed, 4 insertions(+), 2
On 21/03/16 23:56, Jason Ekstrand wrote:
> On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez <
> sigles...@igalia.com> wrote:
>
>> From: Iago Toral Quiroga
>>
>> ---
>> src/compiler/nir/glsl_to_nir.cpp | 6 ++
>> src/compiler/nir/nir_opcodes.py | 2 ++
>> 2
On 21/03/16 23:54, Jason Ekstrand wrote:
> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <
> sigles...@igalia.com> wrote:
>
>> From: Iago Toral Quiroga
>>
>> Undefined sources in alu operations don't have a valid bit size because
>> they are uninitialized.
On 21/03/16 23:49, Jason Ekstrand wrote:
> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <
> sigles...@igalia.com> wrote:
>
>> From: Connor Abbott
>>
>> ---
>> src/compiler/nir/nir_print.c | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>>
On 21/03/16 22:03, Jason Ekstrand wrote:
> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <
> sigles...@igalia.com> wrote:
>
>> From: Connor Abbott
>>
>> v2 (Sam):
>> - Keep using nir_op_imov when calling nir_alu_instr_create() at
>>
I just pushed a (trivial) patch that fixed this.
-Brian
On 03/21/2016 05:52 PM, Dave Airlie wrote:
From: Dave Airlie
In file included from ../../src/compiler/glsl/list.h:74:0,
from ./main/mtypes.h:47,
from ./main/errors.h:43,
So I've been looking a bit more at this, and skipping the
shader_program->UniformStorage[location].opaque[stage].index offset
is, I think, not the right thing to do.
The original issue I was having with this seems to be a disagreement
about location idx into UniformStorage. In
Resending this patch because it received no response last week.
Allow the sequence operator to be a constant expression in GLSL ES versions
prior
to GLSL ES 3.0
Fixes the following piglit test:
/all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert
This mirrors the logic
Ah you are correct, this is no longer needed in the push branch. We can
drop this one from the series as its a nop, please ignore thanks for
spotting it.
On 2016-03-22 02:43, Marek Olšák wrote:
Does this fix anything even? The blitter always binds something, thus
this should have no effect.
On 22.03.2016 05:34, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote:
>
> URL:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=e85cf35a6516c44e33663fcd9637c6b434bb63ee
> Author: Nicolai Hähnle
> Date: Sat Feb 6 18:32:13 2016 -0500
>
> radeonsi: implement
72 matches
Mail list logo