Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-22 Thread Stéphane Marchesin
On Tue, Mar 22, 2016 at 8:55 PM, Rowley, Timothy O wrote: > >> On Mar 22, 2016, at 3:51 PM, Justen, Jordan L >> wrote: >> >> What does 532172 in the subject refer to? > > swr rasterizer development happens in another source control system.

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-22 Thread Kenneth Graunke
On Wednesday, March 23, 2016 3:55:10 AM PDT Rowley, Timothy O wrote: > > > On Mar 22, 2016, at 3:51 PM, Justen, Jordan L wrote: > > > > What does 532172 in the subject refer to? > > swr rasterizer development happens in another source control system. 532172 is a

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-22 Thread Jordan Justen
On 2016-03-22 20:55:10, Rowley, Timothy O wrote: > > > On Mar 22, 2016, at 3:51 PM, Justen, Jordan L > > wrote: > > > > What does 532172 in the subject refer to? > > swr rasterizer development happens in another source control system. > 532172 is a revision id to

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-22 Thread Michel Dänzer
On 22.03.2016 05:41, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Results are undefined but may not crash. Without this change, out-of-bounds > indexing can lead to VM faults and GPU hangs. > > Constant buffers, samplers, and possibly others will eventually need

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-22 Thread Rowley, Timothy O
> On Mar 22, 2016, at 3:51 PM, Justen, Jordan L > wrote: > > What does 532172 in the subject refer to? swr rasterizer development happens in another source control system. 532172 is a revision id to checkpoint where we’ve pushed the changes publicly. > From this

Re: [Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

2016-03-22 Thread Michel Dänzer
On 23.03.2016 02:27, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state.c > b/src/gallium/drivers/radeonsi/si_state.c >

[Mesa-dev] [PATCH 3/3] mesa/st: Remove GLSLVersion clamping

2016-03-22 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_extensions.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b03f531..6645189 100644 ---

[Mesa-dev] [PATCH 2/3] mesa/st: Trivial, use glsl_feature_level var consistently

2016-03-22 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_extensions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 2fdaba0..b03f531 100644

[Mesa-dev] Misc asortment of minor fixes

2016-03-22 Thread Edward O'Callaghan
The only functional change in this series is taking off the breaks on higher GLSL versions than 4.1. This will likely be relevant by weeks end. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 1/3] radeon/r600_query.c: Minor style fix

2016-03-22 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index f8b6241..f9a5721 100644 ---

Re: [Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

2016-03-22 Thread eocallaghan
Reviewed-by: Edward O'Callaghan On 2016-03-23 04:27, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2] compiler/glsl: allow sequence op as const expression for gles 1.0

2016-03-22 Thread Lars Hamre
v2: Fixed regression pointed out by Eduardo Lima Mitev Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert This is similar to the logic

Re: [Mesa-dev] [PATCH] compiler/glsl: Allow the sequence operator to be a constant expression

2016-03-22 Thread Lars Hamre
You are correct, it should be state->is_version(120, 300). I will submit an updated patch. On Tue, Mar 22, 2016 at 3:32 PM, Eduardo Lima Mitev wrote: > On 03/22/2016 02:48 PM, Lars Hamre wrote: > >> Resending this patch because it received no response last week. >> >> Allow

Re: [Mesa-dev] [PATCH 5/8] tgsi: add support for image operations to tgsi_exec.

2016-03-22 Thread Dave Airlie
>> + int dim; >> + switch (tgsi_tex) { >> + case TGSI_TEXTURE_BUFFER: >> + case TGSI_TEXTURE_1D: >> + dim = 1; >> + break; >> + case TGSI_TEXTURE_2D: >> + case TGSI_TEXTURE_RECT: >> + case TGSI_TEXTURE_1D_ARRAY: >> + case TGSI_TEXTURE_2D_MSAA: >> + dim = 2; >> +

Re: [Mesa-dev] [PATCH 3/8] tgsi: introduce NonHelperMask

2016-03-22 Thread Dave Airlie
On 23 March 2016 at 01:37, Brian Paul wrote: > On 03/21/2016 04:02 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This is a mask of which of the current 2x2 grid are non-helper >> invocations. This allows us to mask off the helper invocations >> later

[Mesa-dev] [PATCH v2 09/15] i965/fs: Get rid of the param_size array

2016-03-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 - src/mesa/drivers/dri/i965/brw_fs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 9 - src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 --- 4 files changed, 15 deletions(-) diff --git

[Mesa-dev] [PATCH v2 14/15] i965/fs: Rename demote_pull_constants to lower_constant_loads

2016-03-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 6c7c8cd..2d12449 100644 ---

[Mesa-dev] [PATCH v2 08/15] i965/fs: Stop relying on param_size in assign_constant_locations

2016-03-22 Thread Jason Ekstrand
Now that we have MOV_INDIRECT opcodes, we have all of the size information we need directly in the opcode. With a little restructuring of the algorithm used in assign_constant_locations we don't need param_size anymore. The big thing to watch out for now, however, is that you can have two ranges

[Mesa-dev] [PATCH v2 15/15] i965/fs: Push small uniform arrays

2016-03-22 Thread Jason Ekstrand
Unfortunately, this also means that we need to use a slightly different algorithm for assign_constant_locations. The old algorithm worked based on the assumption that each read of a uniform value read exactly one float. If it encountered a MOV_INDIRECT, it would immediately bail and push the

[Mesa-dev] [PATCH v2 10/15] i965/vec4: Inline get_pull_constant_offset

2016-03-22 Thread Jason Ekstrand
It's not really doing enough anymore to justify a helper function. --- src/mesa/drivers/dri/i965/brw_vec4.h | 2 -- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 37 ++ 2 files changed, 14 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

2016-03-22 Thread Jason Ekstrand
It should work fine without it and the visitor can set it if it wants. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index c883fe3..35400cb

[Mesa-dev] [PATCH v2 05/15] nir: Add another index to load_uniform to specify the range read

2016-03-22 Thread Jason Ekstrand
--- src/compiler/nir/nir.h| 7 +++ src/compiler/nir/nir_intrinsics.h | 6 +- src/compiler/nir/nir_lower_io.c | 5 + src/compiler/nir/nir_print.c | 1 + 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h

[Mesa-dev] [PATCH v2 07/15] i965/fs: Get rid of reladdr

2016-03-22 Thread Jason Ekstrand
We aren't using it anymore. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +-- src/mesa/drivers/dri/i965/brw_ir_fs.h | 5 + 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 2cf093a..57397f2

[Mesa-dev] [PATCH v2 01/15] i965/fs: Add support for doing MOV_INDIRECT on uniforms

2016-03-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index eaff953..7d15794 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH v2 13/15] i965/vec4: Get rid of the uniform_size array

2016-03-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4.cpp| 8 src/mesa/drivers/dri/i965/brw_vec4.h | 2 -- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 9 - src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp| 2 --

[Mesa-dev] [PATCH v2 06/15] i965/fs: Use MOV_INDIRECT for all indirect uniform loads

2016-03-22 Thread Jason Ekstrand
Instead of using reladdr, this commit changes the FS backend to emit a MOV_INDIRECT whenever we need an indirect uniform load. We also have to rework some of the other bits of the backend to handle this new form of uniform load. The obvious change is that demote_pull_constants now acts more like

[Mesa-dev] [PATCH v2 12/15] i965/fs: Use UD type for offsets in VARYING_PULL_CONSTANT_LOAD

2016-03-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 1a62029..6c7c8cd 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH v2 04/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

2016-03-22 Thread Jason Ekstrand
While we're at it, we also add support for the possibility that the indirect is, in fact, a constant. This shouldn't happen in the common case (if it does, that means NIR failed to constant-fold something), but it's possible so we should handle it. --- src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

2016-03-22 Thread Jason Ekstrand
The subnr field is in bytes so we don't need to multiply by type_sz. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 7d15794..d41c8a8 100644 ---

[Mesa-dev] [PATCH v2 11/15] i965/vec4: Use MOV_INDIRECT instead of reladdr for indirect push constants

2016-03-22 Thread Jason Ekstrand
This commit moves us to an instruction based model rather than a register-based model for indirects. This is more accurate anyway as we have to emit instructions to resolve the reladdr. It's also a lot simpler because it gets rid of the recursive reladdr problem by design. One side-effect of

[Mesa-dev] [PATCH v2 00/15] i965: Rework uniform handling in the back-end

2016-03-22 Thread Jason Ekstrand
This is mostly a re-send of a patch series I've had floating around in one form or a while for quite some time. It's basically the same except that the original version was missing a work-around for Sandy Bridge. For a while, I wasn't really pushing to get it merged because I couldn't

Re: [Mesa-dev] [PATCH] i965: Work around SIN/COS output range problem.

2016-03-22 Thread Kenneth Graunke
On Tuesday, March 22, 2016 2:31:42 PM PDT Ian Romanick wrote: > On 03/17/2016 09:18 AM, Martin Peres wrote: > > On 16/03/16 19:33, Kenneth Graunke wrote: > >> The SIN and COS instructions on Intel hardware can produce values > >> slightly outside of the [-1.0, 1.0] range for a small set of values.

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

2016-03-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94512 --- Comment #5 from EoD --- (In reply to Michel Dänzer from comment #4) > Sounds like it's not a driver specific issue then but a general one with > GLX-TLS on x32. X did not segfault when I used my Barts (radeon + r600) instead of

Re: [Mesa-dev] [PATCH] i965: Work around SIN/COS output range problem.

2016-03-22 Thread Ian Romanick
On 03/17/2016 09:18 AM, Martin Peres wrote: > On 16/03/16 19:33, Kenneth Graunke wrote: >> The SIN and COS instructions on Intel hardware can produce values >> slightly outside of the [-1.0, 1.0] range for a small set of values. >> Obviously, this can break everyone's expectations about trig

Re: [Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

2016-03-22 Thread Ian Romanick
I thought I already had this patch, but it looks like it was on my to-do list. I had patches to use GL_ARB_explicit_uniform_location, and those needed GL_ARB_explicit_attrib_location (to get the layout keyword). https://patchwork.freedesktop.org/patch/74220/ (and others... I'm not sure why I

Re: [Mesa-dev] [PATCH] gallium/swr: update rasterizer (532172)

2016-03-22 Thread Jordan Justen
What does 532172 in the subject refer to? On 2016-03-22 12:45:48, Tim Rowley wrote: > Highlights include: > * code style fixes > * start removing win32 types > * switch DC/DS rings to ringbuffer datastructure > * rdtsc bucket support for shaders > * address some coverity issues > *

Re: [Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

2016-03-22 Thread Nicolai Hähnle
On 22.03.2016 12:27, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

Re: [Mesa-dev] [PATCH 02/11] radeonsi: implement set_shader_buffers

2016-03-22 Thread Marek Olšák
On Tue, Mar 22, 2016 at 9:15 PM, Marek Olšák wrote: > On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> --- >> src/gallium/drivers/radeonsi/si_descriptors.c | 61 +- >>

Re: [Mesa-dev] [PATCH] nir: fix dangling ssadef->name ptrs

2016-03-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Mar 22, 2016 at 12:35 PM, Rob Clark wrote: > From: Rob Clark > > In many places, the convention is to pass an existing ssadef name ptr > when construction/initializing a new nir_ssa_def.

Re: [Mesa-dev] [PATCH 02/11] radeonsi: implement set_shader_buffers

2016-03-22 Thread Marek Olšák
On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 61 +- > src/gallium/drivers/radeonsi/si_pipe.h| 1 + >

Re: [Mesa-dev] history of the dusscutions in the mailing list

2016-03-22 Thread Samuel Pitoiset
On 03/22/2016 09:01 PM, Iurie wrote: hello, where is possible to see the history of the dusscutions in the mailing list? https://lists.freedesktop.org/archives/mesa-dev/ thanks ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] history of the dusscutions in the mailing list

2016-03-22 Thread Iurie
hello, where is possible to see the history of the dusscutions in the mailing list? thanks ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

2016-03-22 Thread Bas Nieuwenhuizen
Sure, no problem. - Bas On Tue, Mar 22, 2016 at 8:27 PM, Brian Paul wrote: > If you can wait until tomorrow, Bas, I'll do an overight piglit run to check > for regressions. > > -Brian > > > On 03/22/2016 12:31 PM, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH] nir: fix dangling ssadef->name ptrs

2016-03-22 Thread Rob Clark
From: Rob Clark In many places, the convention is to pass an existing ssadef name ptr when construction/initializing a new nir_ssa_def. But that goes badly (as noticed by garbage in nir_print output) when the original string gets freed. Just use ralloc_strdup()

Re: [Mesa-dev] [PATCH] compiler/glsl: Allow the sequence operator to be a constant expression

2016-03-22 Thread Eduardo Lima Mitev
On 03/22/2016 02:48 PM, Lars Hamre wrote: Resending this patch because it received no response last week. Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test:

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

2016-03-22 Thread Brian Paul
If you can wait until tomorrow, Bas, I'll do an overight piglit run to check for regressions. -Brian On 03/22/2016 12:31 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák Somebody from Intel or VMWare might want to take a look too. Marek On Tue, Mar 22, 2016 at 2:58 AM,

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Mar 21, 2016 at 9:41 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Results are undefined but may not crash. Without this change, out-of-bounds > indexing can lead to VM faults and

[Mesa-dev] [Bug 94088] [llvmpipe] SIGFPE pthread_barrier_destroy.c:40

2016-03-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94088 Steve Langasek changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 00/11] radeonsi: shader buffer support (atomic counters, ssbo)

2016-03-22 Thread Marek Olšák
On Tue, Mar 22, 2016 at 12:21 AM, Nicolai Hähnle wrote: > Hi, > > since shader images have laid most of the foundation, here are shader buffers > now. This is the last extension missing for OpenGL 4.2 (we still need to turn > on GLSL 4.2, but I think that only involves

Re: [Mesa-dev] [PATCH] mesa: replace gl_context->Multisample._Enabled with _mesa_is_multisample_enabled.

2016-03-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Somebody from Intel or VMWare might want to take a look too. Marek On Tue, Mar 22, 2016 at 2:58 AM, Bas Nieuwenhuizen wrote: > This removes any dependency on driver validation of the number of > framebuffer samples. > >

[Mesa-dev] [PATCH 09/21] nir: Add a phi node placement helper

2016-03-22 Thread Jason Ekstrand
Right now, we have phi placement code in two places and there are other places where it would be nice to be able to do this analysis. Instead of repeating it all over the place, this commit adds a helper for placing all of the needed phi nodes for a value. v2: Add better documentation

Re: [Mesa-dev] Mesa (master): 23 new commits

2016-03-22 Thread Marek Olšák
On Tue, Mar 22, 2016 at 8:46 AM, Michel Dänzer wrote: > On 22.03.2016 05:34, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote: >> >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=e85cf35a6516c44e33663fcd9637c6b434bb63ee >> Author: Nicolai Hähnle

[Mesa-dev] [PATCH] radeonsi: fix 2D array MSAA failures since image support landed

2016-03-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index b9bdd47..b8fde00 100644 ---

Re: [Mesa-dev] [PATCH 23/29] nir: add i2d and u2d opcodes

2016-03-22 Thread Jason Ekstrand
On Mar 22, 2016 8:19 AM, "Samuel Iglesias Gonsálvez" wrote: > > > > On 21/03/16 23:56, Jason Ekstrand wrote: > > On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez < > > sigles...@igalia.com> wrote: > > > >> From: Iago Toral Quiroga > >> > >> ---

Re: [Mesa-dev] [PATCH 19/29] nir: fix up bit sizes for undefined alu sources

2016-03-22 Thread Jason Ekstrand
On Mar 22, 2016 8:18 AM, "Samuel Iglesias Gonsálvez" wrote: > > > > On 21/03/16 23:54, Jason Ekstrand wrote: > > On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > > sigles...@igalia.com> wrote: > > > >> From: Iago Toral Quiroga > >> > >>

Re: [Mesa-dev] [PATCH] egl: adds EGL_KHR_reusable_sync to egl_dri

2016-03-22 Thread Marek Olšák
On Tue, Mar 22, 2016 at 1:06 AM, dw kim wrote: > On Mon, Mar 21, 2016 at 08:35:20PM +0100, Marek Olšák wrote: >> On Wed, Mar 9, 2016 at 2:28 AM, Dongwon Kim wrote: >> > This patch enables an EGL extension, EGL_KHR_reusable_sync. >> > This new

Re: [Mesa-dev] [V2 00/19] Add infrastructure for GL_OES_texture_compression_astc

2016-03-22 Thread Brian Paul
On 03/21/2016 03:03 PM, Anuj Phogat wrote: I don't have a hardware which supports this extension and I realized it after writing these patches. This blocks the testing of these patches. So, I'm sure there will be few things left out in this series. But I think it'll be nice to have 90% of the

Re: [Mesa-dev] [PATCH 23/29] nir: add i2d and u2d opcodes

2016-03-22 Thread Samuel Iglesias Gonsálvez
On 22/03/16 16:19, Samuel Iglesias Gonsálvez wrote: > > > On 21/03/16 23:56, Jason Ekstrand wrote: >> On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez < >> sigles...@igalia.com> wrote: >> >>> From: Iago Toral Quiroga >>> >>> --- >>>

[Mesa-dev] [Bug 94088] [llvmpipe] SIGFPE pthread_barrier_destroy.c:40

2016-03-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94088 --- Comment #3 from Roland Scheidegger --- (In reply to Steve Langasek from comment #2) > Hello, > > The patch for this bug is incomplete. In between the calls to > pipe_barrier_init() and pipe_barrier_destroy() are calls

Re: [Mesa-dev] [PATCH 5/8] tgsi: add support for image operations to tgsi_exec.

2016-03-22 Thread Brian Paul
On 03/21/2016 04:02 PM, Dave Airlie wrote: From: Dave Airlie This adds support for load/store/atomic operations on images along with image tracking support. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c | 2 +-

Re: [Mesa-dev] [PATCH 7/8] softpipe: add image support to softpipe

2016-03-22 Thread Brian Paul
A bunch of nit-picks below. Overall, I'd like to see more comments on the new functions to explain what's going on. On 03/21/2016 04:02 PM, Dave Airlie wrote: From: Dave Airlie This adds support for ARB_shader_image_load_store to softpipe. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 3/8] tgsi: introduce NonHelperMask

2016-03-22 Thread Brian Paul
On 03/21/2016 04:02 PM, Dave Airlie wrote: From: Dave Airlie This is a mask of which of the current 2x2 grid are non-helper invocations. This allows us to mask off the helper invocations later for the image operations. Can you elaborate on what a helper invocation is

Re: [Mesa-dev] [PATCH 1/8] tgsi_exec: add support for up to 3 array registers

2016-03-22 Thread Brian Paul
In the subject, should that be "address" instead of "array"? On 03/21/2016 04:02 PM, Dave Airlie wrote: From: Dave Airlie Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.h | 6 -- 1 file changed, 4 insertions(+), 2

Re: [Mesa-dev] [PATCH 23/29] nir: add i2d and u2d opcodes

2016-03-22 Thread Samuel Iglesias Gonsálvez
On 21/03/16 23:56, Jason Ekstrand wrote: > On Mon, Mar 21, 2016 at 5:06 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Iago Toral Quiroga >> >> --- >> src/compiler/nir/glsl_to_nir.cpp | 6 ++ >> src/compiler/nir/nir_opcodes.py | 2 ++ >> 2

Re: [Mesa-dev] [PATCH 19/29] nir: fix up bit sizes for undefined alu sources

2016-03-22 Thread Samuel Iglesias Gonsálvez
On 21/03/16 23:54, Jason Ekstrand wrote: > On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Iago Toral Quiroga >> >> Undefined sources in alu operations don't have a valid bit size because >> they are uninitialized.

Re: [Mesa-dev] [PATCH 14/29] nir: add support for printing double immediates

2016-03-22 Thread Samuel Iglesias Gonsálvez
On 21/03/16 23:49, Jason Ekstrand wrote: > On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Connor Abbott >> >> --- >> src/compiler/nir/nir_print.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >>

Re: [Mesa-dev] [PATCH 03/29] nir/vars_to_ssa: adapt to different bit sizes

2016-03-22 Thread Samuel Iglesias Gonsálvez
On 21/03/16 22:03, Jason Ekstrand wrote: > On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Connor Abbott >> >> v2 (Sam): >> - Keep using nir_op_imov when calling nir_alu_instr_create() at >>

Re: [Mesa-dev] [PATCH] swrast: silence texture_slices warning

2016-03-22 Thread Brian Paul
I just pushed a (trivial) patch that fixed this. -Brian On 03/21/2016 05:52 PM, Dave Airlie wrote: From: Dave Airlie In file included from ../../src/compiler/glsl/list.h:74:0, from ./main/mtypes.h:47, from ./main/errors.h:43,

Re: [Mesa-dev] [RFCv3 04/11] nir: allow pre-resolved sampler uniform locations

2016-03-22 Thread Rob Clark
So I've been looking a bit more at this, and skipping the shader_program->UniformStorage[location].opaque[stage].index offset is, I think, not the right thing to do. The original issue I was having with this seems to be a disagreement about location idx into UniformStorage. In

[Mesa-dev] [PATCH] compiler/glsl: Allow the sequence operator to be a constant expression

2016-03-22 Thread Lars Hamre
Resending this patch because it received no response last week. Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert This mirrors the logic

Re: [Mesa-dev] [PATCH 11/17] gallium/aux: Fix u_blitter.c for layers/samples

2016-03-22 Thread eocallaghan
Ah you are correct, this is no longer needed in the push branch. We can drop this one from the series as its a nop, please ignore thanks for spotting it. On 2016-03-22 02:43, Marek Olšák wrote: Does this fix anything even? The blitter always binds something, thus this should have no effect.

Re: [Mesa-dev] Mesa (master): 23 new commits

2016-03-22 Thread Michel Dänzer
On 22.03.2016 05:34, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote: > > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=e85cf35a6516c44e33663fcd9637c6b434bb63ee > Author: Nicolai Hähnle > Date: Sat Feb 6 18:32:13 2016 -0500 > > radeonsi: implement