Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-31 Thread Peter Stuge
Marek Vasut wrote: So it turns out (by reading Freescale iMX515 errata), ENGcm09395 to be exact Please mention this within the fixup function. But that being the case, I'd prefer to make an incremental patch on top of the patches I submitted. Please don't, since some of the former patches

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-31 Thread David Brownell
I think caring about the variant should strongly be avoided. Use the ROM table by default. Only in the case of a broken ROM table should we (a) emit a message, then (b) work around the brokenness. Such working-around might care about variant, if wecan't come up with a simple heuristic fix. -

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-31 Thread Øyvind Harboe
On Sun, Oct 31, 2010 at 10:59 AM, David Brownell davi...@pacbell.net wrote: I think caring about the variant should strongly be avoided.  Use the ROM table by default.  Only in the case of a broken ROM table should we (a) emit a message, then (b) work around the brokenness. Such

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-31 Thread Marek Vasut
On Sunday 31 October 2010 13:16:43 Øyvind Harboe wrote: On Sun, Oct 31, 2010 at 10:59 AM, David Brownell davi...@pacbell.net wrote: I think caring about the variant should strongly be avoided. Use the ROM table by default. Only in the case of a broken ROM table should we (a) emit a

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-30 Thread Marek Vasut
On Saturday 30 October 2010 07:24:08 Marek Vasut wrote: On Friday 29 October 2010 09:37:36 Øyvind Harboe wrote: Oyvind sorry, I just can't find it ... could you tell me where it is please ? Start here: https://lists.berlios.de/pipermail/openocd-development/2010-September/016 48

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Øyvind Harboe
On Fri, Oct 29, 2010 at 7:57 AM, Marek Vasut marek.vasut.n...@gmail.com wrote: Shouldn't this be automatically detected? yes it should ... i'll send a patch on top of this one once I figure out how to do it. Is that good enough approach for you? Or shall we put these on hold until then? I

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Øyvind Harboe
On Fri, Oct 29, 2010 at 8:08 AM, Marek Vasut marek.vasut.n...@gmail.com wrote: On Fri, Oct 29, 2010 at 7:57 AM, Marek Vasut marek.vasut.n...@gmail.com wrote: Shouldn't this be automatically detected? yes it should ... i'll send a patch on top of this one once I figure out how to do

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Marek Vasut
On Friday 29 October 2010 07:43:18 Peter Stuge wrote: Marek Vasut wrote: In this patch, I introduce the use of -variant parameter, so I can adjust the debug_base accordingly. This seems completely wrong to me. I think this logic should just stay in Tcl. So if anything, you would add a

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Marek Vasut
On Friday 29 October 2010 08:18:46 Marek Vasut wrote: On Fri, Oct 29, 2010 at 8:08 AM, Marek Vasut marek.vasut.n...@gmail.com wrote: On Fri, Oct 29, 2010 at 7:57 AM, Marek Vasut marek.vasut.n...@gmail.com wrote: Shouldn't this be automatically detected? yes it

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Øyvind Harboe
On Fri, Oct 29, 2010 at 9:33 AM, Marek Vasut marek.va...@gmail.com wrote: On Friday 29 October 2010 07:43:18 Peter Stuge wrote: Marek Vasut wrote: In this patch, I introduce the use of -variant parameter, so I can adjust the debug_base accordingly. This seems completely wrong to me. I

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Øyvind Harboe
Oyvind sorry, I just can't find it ... could you tell me where it is please ? Start here: https://lists.berlios.de/pipermail/openocd-development/2010-September/016482.html -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base?according to variant

2010-10-29 Thread Peter Stuge
Marek Vasut wrote: add a parameter for dap_base. That's what I wanted to do, but I'm still starting to get familiar with OpenOCD again. Could you point me in a direction please? Um, well, don't you just do the same thing as you did for -variant, except use strtoul() in the C code?

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Peter Stuge
Øyvind Harboe wrote: So if anything, you would add a parameter for dap_base. Could you point me in a direction please? This should be picked up automatically, so this is the wrong direction. If you type dap info 0, I believe it prints out the debug base, so the code is even in there

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-29 Thread Marek Vasut
On Friday 29 October 2010 09:37:36 Øyvind Harboe wrote: Oyvind sorry, I just can't find it ... could you tell me where it is please ? Start here: https://lists.berlios.de/pipermail/openocd-development/2010-September/01648 2.html Hey, I went through all of this stuff tonight ... and I

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-28 Thread Peter Stuge
Marek Vasut wrote: In this patch, I introduce the use of -variant parameter, so I can adjust the debug_base accordingly. This seems completely wrong to me. I think this logic should just stay in Tcl. So if anything, you would add a parameter for dap_base. //Peter

Re: [Openocd-development] [PATCH 1/3] CortexA8: Setup debug_base according to variant

2010-10-28 Thread Øyvind Harboe
Shouldn't this be automatically detected? -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing