[HACKERS] pg_stat_transaction patch

2010-05-06 Thread Joel Jacobson
added. The patch should apply to 9.0beta or HEAD, but I created it using 8.4.3 because that's the version I'm using. I'm thankful for your feedback. My apologies if the packaging of the patch does not conform to your guidelines, feedback on this is also welcome. -- Best regards, Joel Jacobson

Re: [HACKERS] pg_stat_transaction patch

2010-05-19 Thread Joel Jacobson
is the intended output, while run.out90b1 gives 0 on the columns n_tup_ins and n_tup_upd (and probably n_tup_del etc also). I hope someone can help locating the problem. Thanks. Best regards, Joel 2010/5/7 Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp Joel Jacobson j...@gluefinance.com wrote

Re: [HACKERS] pg_stat_transaction patch

2010-06-08 Thread Joel Jacobson
Hi Takahiro, Here is an updated version of the patch. Thanks Magnus H for the help :) 1.4: Ported to head. Updated tests. Removed pg_stat_report. 2010/5/25 Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp Joel Jacobson j...@gluefinance.com wrote: I applied all the changes on 9.0beta

Re: [HACKERS] pg_stat_transaction patch

2010-08-09 Thread Joel Jacobson
if any columns where irrelevant for current transaction data. I guess if someone would need the blocks_fetched/hit, they could build their own view. regards, tom lane -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01 Postal address

[HACKERS] Deadlock bug

2010-08-20 Thread Joel Jacobson
) in postgres? -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01 Postal address: Glue Finance AB Box 549 114 11 Stockholm Sweden Visiting address: Glue Finance AB Birger Jarlsgatan 14 114 34 Stockholm Sweden deadlock.sql Description: Binary data -- Sent

Re: [HACKERS] Deadlock bug

2010-08-20 Thread Joel Jacobson
with a deadlock in my example. (If it helps, we would be willing to assign a bounty prize to anyone taking on the task to solve this problem.) Best regards, Joel Jacobson Glue Finance 2010/8/20 Tom Lane t...@sss.pgh.pa.us Kevin Grittner kevin.gritt...@wicourts.gov writes: The surprising thing

Re: [Glue] [HACKERS] Deadlock bug

2010-08-20 Thread Joel Jacobson
possible to improve it. -- -- Josh Berkus PostgreSQL Experts Inc. http://www.pgexperts.com -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01

Re: [HACKERS] [Glue] Deadlock bug

2010-08-20 Thread Joel Jacobson
OK. Thanks for the explanation. It's probably the case in general, but in all of my tests (10), process 2 always aborts. I don't think it is arbitrary in this example, or could it be? 2010/8/20 Greg Stark gsst...@mit.edu On Fri, Aug 20, 2010 at 7:38 PM, Joel Jacobson j...@gluefinance.com wrote

Re: [HACKERS] Deadlock bug

2010-08-20 Thread Joel Jacobson
on the FK, but I cannot understand why it is granted it the first time, but not the second time? 2010/8/20 Tom Lane t...@sss.pgh.pa.us Joel Jacobson j...@gluefinance.com writes: I don't understand exactly why this deadlock occurs, but the one thing I cannot understand is why process 2 is not allowed

Re: [HACKERS] Deadlock bug

2010-08-20 Thread Joel Jacobson
of A? 2010/8/20 Tom Lane t...@sss.pgh.pa.us Joel Jacobson j...@gluefinance.com writes: I fully agree it must obtain a sharelock on the FK, but I cannot understand why it is granted it the first time, but not the second time? It *isn't* granted it the first time, because it doesn't try

Re: [HACKERS] Deadlock bug

2010-08-26 Thread Joel Jacobson
/ UNIQUE will create implicit index p_b_key for table p CREATE TABLE rhaas=# create table r (b integer not null references p (b)); CREATE TABLE -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Best regards, Joel Jacobson Glue Finance E: j

Re: [HACKERS] Generate call graphs in run-time

2012-01-10 Thread Joel Jacobson
PM, Joel Jacobson wrote: Generates call graphs of function calls within a transaction in run-time. Related to this... we had Command Prompt write a function for us that would spit out the complete call-graph of the current call stack whenever it was called. Alvaro didn't need to add any hooks

Re: [HACKERS] Generate call graphs in run-time

2012-01-17 Thread Joel Jacobson
On Mon, Jan 16, 2012 at 2:23 PM, Martin Pihlak martin.pih...@gmail.com wrote: My approach was to add parent oid to the per-backend function stats structure - PgStat_BackendFunctionEntry. Also, I changed the hash key for that structure to (oid, parent) pair. This means that within the backend

[HACKERS] Explicitly specifying use of IN/OUT variable in PL/pgSQL functions

2012-03-13 Thread Joel Jacobson
The introduction of custom_variable_classes and #variable_conflict in 9.0 partly solves the problem with mixing IN/OUT variables with column names. In 8.4 and before, it defaulted to the IN/OUT variable, if it shared the name of a column. In 9.0 the behaviour was changed to raise an error if a

[HACKERS] UPDATE pg_catalog.pg_proc.prosrc OK?

2010-12-27 Thread Joel Jacobson
column = new source code WHERE oid = function's oid; instead of using the CREATE OR REPLACE FUNCTION command? (Using pg_dump -s + pg_restore isn't feasible since it operates on the entire schema, and not just a subset of functions, important in my case.) Thanks for any advise. -- Best regards, Joel

Re: [HACKERS] UPDATE pg_catalog.pg_proc.prosrc OK?

2010-12-28 Thread Joel Jacobson
-- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01 Postal address: Glue Finance AB Box 549 114 11 Stockholm Sweden Visiting address: Glue Finance AB Birger Jarlsgatan 14 114 34 Stockholm Sweden

[HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
tested the patch for both the latest HEAD (9.1devel) as well as 8.4.6. Feedback welcome. -- Best regards, Joel Jacobson Glue Finance pg-dump-split-plain-text-files-8.4.6.patch Description: Binary data pg-dump-split-plain-text-files-9.1devel.patch Description: Binary data -- Sent via pgsql

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
2010/12/28 Tom Lane t...@sss.pgh.pa.us Joel Jacobson j...@gluefinance.com writes: Dear fellow hackers, Problem: A normal diff of two slightly different schema dump files (pg_dump -s), will not produce a user-friendly diff, as you get all changes in the same file. Solution: I propose

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
which could cause a diff -r between two different databases to break? (This might be a bad idea for some other reason, but I noticed a few other users requesting the same feature when I googled pg_dump split.) -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
unless truncated, and since the problem is very limited, I think we shouldn't include it. It's cleaner with just the name part of the tag in the file name. -- Best regards, Joel Jacobson Glue Finance pg-dump-split-plain-text-files-8.4.6.patch Description: Binary data pg-dump-split-plain-text

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
Sent from my iPhone On 28 dec 2010, at 21:45, Gurjeet Singh singh.gurj...@gmail.com wrote: The problem I see with suffixing a sequence id to the objects with name collision is that one day the dump may name myfunc(int) as myfunc.sql and after an overloaded version is created, say myfunc(char,

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
table to convert between the long names to the short names? E.g., character varying = varchar timestamp with time zone = timestamptz etc. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
, and let diff take care of the rest of the challenge. :) Brb with a new patch. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
to optimize the actual diff output. -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01 Postal address: Glue Finance AB Box 549 114 11 Stockholm Sweden Visiting address: Glue Finance AB Birger Jarlsgatan 14 114 34 Stockholm Sweden pg-dump-split-plain-text

Re: [HACKERS] pg_dump --split patch

2010-12-28 Thread Joel Jacobson
of such options to provide the same flexibility as a split dump, highly reducing the need for such options as you could then compose your own restore script based on the dump. Of course, not all of these scenarios are relevant for everybody. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2010-12-29 Thread Joel Jacobson
2010/12/29 Aidan Van Dyk ai...@highrise.ca On Wed, Dec 29, 2010 at 2:27 AM, Joel Jacobson j...@gluefinance.com wrote: description of split stuff So, how different (or not) is this to the directory format that was coming out of the desire of a parallel pg_dump? Not sure what format you

Re: [HACKERS] pg_dump --split patch

2010-12-29 Thread Joel Jacobson
/myfunc.sql \i /crypt/splitpatch-split/public/FUNCTION/otherfunc.sql -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2010-12-29 Thread Joel Jacobson
pg_dump tool. Happy new year! Joel Jacobson Glue Finance

[HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
Happy new year fellow pgsql-hackers! This is the first alpha release of a new hopefully quite interesting little tool, named snapshot. Feedback welcomed. -- Best regards, Joel Jacobson Glue Finance URL https://github.com/gluefinance/snapshot DESCRIPTION Take a snapshot or rollback all

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
for fast reply. My guests hate me becuase I had to escape from the dinner party, but I simply couldn't wait a whole year fixing this bug. Commit. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] contrib/snapshot

2010-12-31 Thread Joel Jacobson
, Joel Jacobson Glue Finance

Re: [HACKERS] contrib/snapshot

2011-01-01 Thread Joel Jacobson
/fsnapshot -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Joel Jacobson
to append manually. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] contrib/snapshot

2011-01-02 Thread Joel Jacobson
2011/1/3 Joel Jacobson j...@gluefinance.com 2011/1/2 Jim Nasby j...@nasby.net Is it actually limited to functions? ISTM this concept would be valuable for anything that's not in pg_class (in other words, anything that doesn't have user data in it). Instead of limiting the support

Re: [HACKERS] contrib/snapshot

2011-01-03 Thread Joel Jacobson
sure objects are created/dropped in an order not breaking any dependencies. -- Best regards, Joel Jacobson Glue Finance

Re: [HACKERS] pg_dump --split patch

2011-01-03 Thread Joel Jacobson
should narrow down your mind-mapping-change-grasping-exercise quite a lot. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_dump --split patch

2011-01-03 Thread Joel Jacobson
of the need for such an option for all object types is greather than the extra complexity introduced by a patch consisting of only a few lines of code. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] pg_dump --split patch

2011-01-03 Thread Joel Jacobson
solving the same problem. Multiple almost identical solutions to exactly the same problem is kind of time waste. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] Implementing pg_dump_sort.c topological sorting in sql/plpgsql/plperl?

2011-01-04 Thread Joel Jacobson
such a function to hopefully save some time? Thanks a lot! [1] https://github.com/gluefinance/fsnapshot -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

[HACKERS] pov and tsort

2011-01-06 Thread Joel Jacobson
) UP only traverse predecessors DOWNonly traverse successors -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] obj_unique_identifier(oid)

2011-01-07 Thread Joel Jacobson
.- pg_class.pg_catalog.pg_statio_sys_sequences pg_amproc.gin.pg_catalog.array_ops.pg_catalog._bool.pg_catalog._bool.1 pg_class.pg_catalog.pg_stat_all_indexes pg_class.pg_catalog.pg_type pg_proc.pg_catalog.pg_stat_get_function_time(oid) (10 rows) -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-07 Thread Joel Jacobson
Sent from my iPhone On 7 jan 2011, at 20:46, Tom Lane t...@sss.pgh.pa.us wrote: Joel Jacobson j...@gluefinance.com writes: The function obj_unique_identifier(oid) will return a unique name for _any_ oid. Surely this is broken by design? You can *not* assume that the same OID isn't in use

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-07 Thread Joel Jacobson
The function should take both classid and oid as input. I'll fix. Sent from my iPhone On 7 jan 2011, at 20:59, Joel Jacobson j...@gluefinance.com wrote: Sent from my iPhone On 7 jan 2011, at 20:46, Tom Lane t...@sss.pgh.pa.us wrote: Joel Jacobson j...@gluefinance.com writes: The function

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-07 Thread Joel Jacobson
be provided in the vanilla distro. :) -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Joel Jacobson
pinned objects being compatible with a specific version of the database. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Joel Jacobson
2011/1/8 Magnus Hagander mag...@hagander.net: Yes. Once things are committed to the main repository, they are only backed out if someone finds a major issue with them that is not fixable (ina reasonable timeframe). That almost never happens. We don't keep unapproved patches or development

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Joel Jacobson
2011/1/8 Robert Haas robertmh...@gmail.com: I don't think your analysis is correct.  Each entry in pg_depend represents the fact that one object depends on another object, and an object could easily depend on more than one other object, or be depended upon by more than one other object, or

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Joel Jacobson
) of operator family array_ops for access method gin for (character varying[],character varying[]) (2 rows) Looks great! Many thanks for fixing the bug! Andreas -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46 70 360 38 01 Postal address: Glue Finance AB Box

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Joel Jacobson
actually be UNION, it would produce the same result, but perhaps it would be a bit faster. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid))

2011-01-10 Thread Joel Jacobson
in the production. Very helpful function indeed! https://github.com/gluefinance/pov/blob/master/sql/schema/pov/functions/pg_describe_object.sql -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid))

2011-01-10 Thread Joel Jacobson
a lot of postgres-guru-knowledge. I think it would be a big improvement and increase the number of possible use cases of the existing pg_describe_object function if the documentation would say the returned text is guaranteed to be unique for each object. -- Best regards, Joel Jacobson Glue Finance

[HACKERS] Add function dependencies

2011-01-10 Thread Joel Jacobson
a nice call tree of your entire system. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bug in pg_describe_object

2011-01-10 Thread Joel Jacobson
text. The name would make sense since we already have a pg_get_function_identity_arguments( func_oid ), for a similar purpose but solely for functions. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Bug in pg_describe_object

2011-01-11 Thread Joel Jacobson
a totally different story and there is no excuse why it should return the same descriptions for the same objects. Any other reasoning is just silly. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Bug in pg_describe_object

2011-01-11 Thread Joel Jacobson
versions. In this case it is better to compare textual strings describing the objects than to compare based on oids. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] pg_depend explained

2011-01-11 Thread Joel Jacobson
, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_depend explained

2011-01-11 Thread Joel Jacobson
. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_depend explained

2011-01-11 Thread Joel Jacobson
the logic necessary to do the trick, but it's not that easy to follow. I guess it's time for plan B, sorting based on oid, no biggie, it will work for my purpose, but it's damn ugly. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] pg_depend explained

2011-01-12 Thread Joel Jacobson
of creation, only including the base objects. pg_depend_actual.png : PNG generated using GraphViz with pg_depend_actual.dot as input pg_depend_actual.svg : SVG generated using GraphViz with pg_depend_actual.dot as input -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers

Re: [HACKERS] pg_depend explained

2011-01-12 Thread Joel Jacobson
] and pg_depend_actual.[dot|png|svg] with the circular references. The dotted edges in pg_depend_actual are the edges which must be removed to break the loop. Any ideas on how to design an algorithm to transform the digraph pg_depend into pg_depend_actual are highly appreciated. -- Best regards, Joel

Re: [HACKERS] pg_depend explained

2011-01-12 Thread Joel Jacobson
(node-node) as indata, but also a edge type as indata (i.e. the deptype in pg_depend) would also be very useful. I have only found algorithms to do sorting on normal directional graphs, where all edges are threated the same. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers

Re: [HACKERS] pg_depend explained

2011-01-12 Thread Joel Jacobson
(sorry for top posting, iPhone + drunk) pg_depend_before is a select * from pg_depend before creating the test db model Sent from my iPhone On 12 jan 2011, at 20:36, David Fetter da...@fetter.org wrote: On Wed, Jan 12, 2011 at 08:06:24PM +0100, Joel Jacobson wrote: 2011/1/12 Tom Lane t

[HACKERS] Bug in pg_dump

2011-01-13 Thread Joel Jacobson
too. This isn't particularly *useful*, maybe, but it's hardly impossible. And if we analyzed function dependencies in any detail, circular dependencies among functions would be possible (and useful).                        regards, tom lane -- Best regards, Joel Jacobson Glue Finance

[HACKERS] Possible bug in pg_settings/pg_depend

2011-01-13 Thread Joel Jacobson
-- view pg_settings column name (1 row) -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add function dependencies

2011-01-13 Thread Joel Jacobson
public.myfunc(int) called and what tables has it inserted/selected/updated/deleted from since the last time I resetted the statistics? Just an idea... -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Possible bug in pg_settings/pg_depend

2011-01-13 Thread Joel Jacobson
seems a bit strange I only found one such in the entire database, smells like some kind of bug, but might not be, I dunno, just thought it was worth investigating a bit, but if you're sure about it I of course trust you. -- Best regards, Joel Jacobson Glue Finance E: j...@gluefinance.com T: +46

Re: [HACKERS] pg_depend explained

2011-01-13 Thread Joel Jacobson
hadn't really solved the problem at the time I wrote my last email, it turned out I had to do things a bit differently to avoid running into problems with corner cases. I will put together a self-contained example like you suggested and get back shortly :-) -- Best regards, Joel Jacobson Glue

[HACKERS] Do magic using pg_depend

2011-01-13 Thread Joel Jacobson
, this stuff has already been implemented in pg_dump, but since pov is a SQL-based system it was necessary to implement the same functionality using only sql/plpgsql/plperl. Author: Joel Jacobson, Glue Finance AB, Sweden, j...@gluefinance.com Datestamp: 2011-01-13 23:42 Europe/Stockholm License: MIT

Re: [HACKERS] pg_depend explained

2011-01-14 Thread Joel Jacobson
/sql/schema/pov/views/pg_depend_remapped.sql It can be tested stand-alone and does not require any other components from the pov project. Can I create a wiki snippet myself or do I need some kind of admin access? -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing

[HACKERS] pov 1.0 is released, testers with huge schemas needed

2011-01-14 Thread Joel Jacobson
, etc... I would highly appreciate if you hackers could test to play around with this, using real-life database schemas, to detect any bugs. To all of you, have a great weekend! Happy hacking! -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pov 1.0 is released, testers with huge schemas needed

2011-01-15 Thread Joel Jacobson
2011/1/14 Joel Jacobson j...@gluefinance.com: To install: git clone g...@github.com:gluefinance/pov.git Ops, typo, to do this without my ssh key, you need to do: git clone git://github.com/gluefinance/pov.git -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-15 Thread Joel Jacobson
-damn-two-lines-of-code-patch, could Tom please describe to the patch submitter what you mean with get it done right, and perhaps the patch submitter will be motivated enough to invest a few hundred/thousands hours of his time to solve the problem the way hinted by Tom? -- Best regards, Joel

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-17 Thread Joel Jacobson
the text string, which would break a lot of things. Just some thoughts... -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-17 Thread Joel Jacobson
2011/1/17 Tom Lane t...@sss.pgh.pa.us: Joel Jacobson j...@gluefinance.com writes: a) pg_describe_object should always include the schema in the name, even for object in public and pg_catalog. I knew you were going to demand that next, as soon as you figured out that it was an obstacle

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-23 Thread Joel Jacobson
perfection in every little detail. I'm proud we can conclude ProstgreSQL is apparently a project of the second category. -- Best regards, Joel Jacobson Glue Finance -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] PL/PgSQL STRICT

2012-12-21 Thread Joel Jacobson
On Fri, Dec 21, 2012 at 4:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: What about before it, ie STRICT UPDATE ... +1 from me too. This feature would be awesome. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] PL/PgSQL STRICT

2012-12-21 Thread Joel Jacobson
On Fri, Dec 21, 2012 at 4:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: That was my first reaction too, but Marko's followon examples seem to make a reasonable case for it. There are many situations where you expect an UPDATE or DELETE to hit exactly one row. Often, programmers won't bother to

[HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-04 Thread Joel Jacobson
I have received positive feedback on the pg_dump --split option I suggested, but it depends on pg_dump dumping objects in a deterministic order. I'm committed to fixing this. The first problem I've spotted is overloaded functions. This patch adds a new element to DumpableObject: char *proargs

[HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-04 Thread Joel Jacobson
I renamed the new element to DumpableObject from proargs to the more general name sortkey. This way this element can be used by any object types in the future, which might require sorting by additional information than type, namespace and name. Currently, it's only set for functions/aggregates

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 2:38 AM, Robert Haas robertmh...@gmail.com wrote: My vote is - when there's an overloaded function, put each version in its own file. And name the files something like functionname_something.sql. And just document that something may not be entirely stable. I would

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-05 Thread Joel Jacobson
New version, made a typo in last one. pg_dump_deterministic_order_v3.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
Maybe it could be made an option to pg_dump? Some users and their systems might not even have overloaded functions, and these users will of course prefer a nice looking filename, i.e. all functions having the same name kept in the same file. Which for them will mean only one function per file

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 4:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Ick. Then we have to deal with all the downsides of *both* methods. pg_dump is already a bloated, nearly unmaintainable mess. The very last thing it needs is even more options. When you say bloated, are you referring to

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 5:17 PM, Alvaro Herrera alvhe...@commandprompt.comwrote: Agreed. However I am also against what seems to be the flow. Normally, you don't write overloaded plpgsql functions such as equal. Case in point, the equality functions in core have funny names like int4eq and

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 5:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: FWIW, I'm attracted to the all-similarly-named-functions-together method, mainly because it dodges the problem of how to encode a function's argument list into a filename. However, we're being short-sighted to only think of

Re: [HACKERS] Schema version management

2012-07-05 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 6:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, to be perfectly frank, I already doubt that this entire feature passes the complexity-versus-value test, because pg_dump is not a substitute for an SCM --- people who have got enough functions to need this sort of thing

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-05 Thread Joel Jacobson
I agree, good suggestion, I just didn't know how to implement it without a new field. I'll make a new attempt to get it right. On Thursday, July 5, 2012, Tom Lane wrote: Joel Jacobson j...@trustly.com javascript:; writes: New version, made a typo in last one. I'm not particularly happy

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-05 Thread Joel Jacobson
Roger that. I'm on it. On Thursday, July 5, 2012, Tom Lane wrote: Joel Jacobson j...@trustly.com javascript:; writes: You may in fact need a new field --- I'm just saying it should be in the object-type-specific struct, eg FuncInfo, not DumpableObject. regards, tom

Re: [HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-06 Thread Joel Jacobson
On Thu, Jul 5, 2012 at 10:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: You may in fact need a new field --- I'm just saying it should be in the object-type-specific struct, eg FuncInfo, not DumpableObject. I suggest adding char *funcsig to FuncInfo, and moving the funcsig =

Re: [HACKERS] Schema version management

2012-07-08 Thread Joel Jacobson
On Saturday, July 7, 2012, Tom Lane wrote: If we think that operators outside of extensions will be an infrequent special case, what about just dumping all of them into a single file named operators? And similarly for casts? regards, tom lane +1

Re: [HACKERS] Schema version management

2012-07-11 Thread Joel Jacobson
On Wed, Jul 11, 2012 at 12:24 AM, Merlin Moncure mmonc...@gmail.com wrote: What does your patch do that you can't already do with pg_restore? Please read through the entire thread, think question has already been answered.

Re: [HACKERS] Schema version management

2012-07-12 Thread Joel Jacobson
On Wed, Jul 11, 2012 at 8:01 PM, Merlin Moncure mmonc...@gmail.com wrote: After extensive off-list discussion with Joel it became clear that per-object dumping ability really belongs in pg_restore. The only benefit I could see in putting it in pg_restore is you would then be able to do a

Re: [HACKERS] Schema version management

2012-07-12 Thread Joel Jacobson
On Wed, Jul 11, 2012 at 11:20 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: operator_!___numeric.sql (postfix, name does not need escape) operator_%7C%2F_integer__.sql (prefix) operator_%3C_bit_varying__bit_varying.sql (type name with spaces, changed to _) I think the directory

Re: [HACKERS] Schema version management

2012-07-12 Thread Joel Jacobson
On Thursday, July 12, 2012, Tom Lane wrote: What are you going to do with objects that don't have schemas? (Including, but not restricted to, the schemas themselves.) Good question. Maybe something like this? For objects without schema: /global/[type]/[name].sql For objects with schema:

Re: [HACKERS] Schema version management

2012-07-12 Thread Joel Jacobson
On Thu, Jul 12, 2012 at 4:01 PM, Tom Lane t...@sss.pgh.pa.us wrote: FWIW, I think you could save a level of naming if you were willing to put the type first, since the type would imply whether the object lives in a schema or not: [type]/[name].sql [type]/[schema]/[name].sql

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Fri, Jul 13, 2012 at 9:41 PM, Peter Eisentraut pete...@gmx.net wrote: Personally, I hate this proposed nested directory structure. I would like to have all objects in one directory. But there is a lot of personally in this thread, of course. Why do you hate it? It's a bit like saying,

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Sat, Jul 14, 2012 at 11:25 AM, Peter Eisentraut pete...@gmx.net wrote: Well, of course everyone uses directories in moderation. But you might want to take a look at the gcc source code. You'll love it. ;-) Yes, but GCC was also created by someone who picks stuff from his bare foot and eats

Re: [HACKERS] Schema version management

2012-07-14 Thread Joel Jacobson
On Sat, Jul 14, 2012 at 12:34 PM, Joel Jacobson j...@trustly.com wrote: On Sat, Jul 14, 2012 at 11:25 AM, Peter Eisentraut pete...@gmx.net wrote: Well, of course everyone uses directories in moderation. But you might want to take a look at the gcc source code. You'll love it. ;-) [505

[HACKERS] [PATCH] pg_dump: Sort overloaded functions in deterministic order

2012-07-19 Thread Joel Jacobson
Makes pg_dump sort overloaded functions in deterministic order. The field proiargs has been added to FuncInfo and is set by getFuncs() and getAggregates() for all functions and aggregates. DOTypeNameCompare uses this field to break ties if the name and number of arguments are the same. This

[HACKERS] Unexpected plperl difference between 8.4 and 9.1

2012-08-19 Thread Joel Jacobson
After upgrading from 8.4 to 9.1, one of my plperl functions stopped working properly. For some reason, when matching a string using a regex, the $1 variable cannot be returned directly using return_next() but must be set to a variable first. If returned directly, it appears to be cached in some

  1   2   3   >