Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 23, 2015, 8:05 p.m.) Review request for Plasma, Ashish

Re: Review Request 126121: [greeter] Use PlasmaShellSurface to position the views

2015-11-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126121/ --- (Updated Nov. 23, 2015, 10:47 a.m.) Status -- This change has been

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Kai Uwe Broulik
> On Nov. 23, 2015, 10:59 vorm., Martin Gräßlin wrote: > > and what if krunner fails? That's a rhethorical question. I don't think > > that we need a fallback to go to krunner. If it's broken it's broken. Maybe > > show a dialog that it's broken (compare KWin tabbox/tabboxhandler.cpp line > >

Re: Review Request 126095: [backends/hwcomposer] Announce support for DPMS

2015-11-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126095/ --- (Updated Nov. 23, 2015, 10:49 a.m.) Status -- This change has been

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126143/#review88712 --- and what if krunner fails? That's a rhethorical question. I

Re: Review Request 126126: kicker: always show arrows for items with children

2015-11-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126126/#review88711 --- I think currently without arrows does look a bit strange with

Kubuntu 15.04 Graphics Driver Issue

2015-11-23 Thread gokul krishna
Hi, I started using Kubuntu 15.04 around five months back and recently I encountered a problem when I updated my graphics driver[1]. Currently I’ve Nvidia 860M Graphics driver in my Lenovo Y50-70 laptop. I tried [2] and even tried updating and upgrading the whole system by logging in through

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson
> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. How do you

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88715 --- Do the tests not work anymore? Just curious why were they

Minutes Monday Plasma Hangout

2015-11-23 Thread Sebastian Kügler
Present: bshah, jensreu, kbroulik, notmart, mgraesslin, obogdan, sebas Date: November 23rd, 2015 bshah: - we have required qt5.5 packages for mobile - maybe we are hitting : https://bugreports.qt.io/browse/QTBUG-46831 - needs further debugging and fixing - I plan to build next IMG once this issue

Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126143/ --- Review request for Plasma and Martin Gräßlin. Repository:

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354250 Kai Uwe Broulik changed: What|Removed |Added Product|plasmashell |Powerdevil Target

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 23, 2015, 1:50 p.m.) Review request for Plasma, Ashish

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread Martin Gräßlin
> On Nov. 23, 2015, 8:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. > > David Edmundson

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson
> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around. > > David Edmundson

[Powerdevil] [Bug 355687] Powerdevil does not act (e.g. suspend, dim) when switching to battery mode

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355687 Kai Uwe Broulik changed: What|Removed |Added Version Fixed In||5.5.0

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354250 Kai Uwe Broulik changed: What|Removed |Added Version Fixed In||5.5.0 Latest

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik
> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- (Updated Nov. 23, 2015, 10:19 p.m.) Review request for Plasma, Marco

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
> On Nov. 23, 2015, 9:02 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 122 > > > > > > Why do you drop FAST_CONCATENATION? ack QT_USE_FAST_CONCATENATION /usr/include/ brings nothing ack

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88745 --- The interaction seems fine, but since it's a user setting,

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review88741 --- The problem with this is that the old applet had the

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Eike Hein
> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88737 --- src/declarativeimports/core/datamodel.cpp (line 58)

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik
> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/core/datamodel.cpp, line 58 > > > > > > Why not constBegin()/constEnd()? because rNames is const, constBegin()/constEnd() will be

[Powerdevil] [Bug 355804] Fresh boot to sddm and a few minutes of inactivity sends computer to Standby

2015-11-23 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355804 Martin Gräßlin changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88746 --- File Attachment: Avatar gallery - usermanageravatar2.png

Re: Review Request 126101: allow loading backends in-process

2015-11-23 Thread Sebastian Kügler
> On Nov. 20, 2015, 10:14 a.m., Daniel Vrátil wrote: > > src/backendmanager.cpp, line 361 > > > > > > Instead of deleting the AbstractBackend manually here, you could let > > QPluginLoader do it by

Re: Review Request 126101: allow loading backends in-process

2015-11-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/ --- (Updated Nov. 24, 2015, 3:04 a.m.) Status -- This change has been

[Powerdevil] [Bug 353356] Powerdevil does not respect the critical level configuration

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353356 Kai Uwe Broulik changed: What|Removed |Added CC|

[Powerdevil] [Bug 352235] Screens return from DPMS Suspend Mode to Normal Mode When Receiving Google Hangouts Messages

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=352235 --- Comment #2 from Kai Uwe Broulik --- Please give a try to https://git.reviewboard.kde.org/r/126145/ -- You are receiving this mail because: You are the assignee for the bug. ___

[Powerdevil] [Bug 353538] screen switches off when playing video in VLC or even when screen blanking is switched off

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353538 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

[Powerdevil] [Bug 345115] allow to disable suspend inhibitiors per activity

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=345115 Kai Uwe Broulik changed: What|Removed |Added Ever confirmed|0 |1

[Breeze] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355799 --- Comment #2 from radzaqu...@gmail.com --- Created attachment 95674 --> https://bugs.kde.org/attachment.cgi?id=95674=edit Breeze Dark - Glitches Here is the result with Breeze Dark: look at Dolphin icon & System Settings icon -- You are receiving

[Breeze] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355799 --- Comment #1 from radzaqu...@gmail.com --- Created attachment 95673 --> https://bugs.kde.org/attachment.cgi?id=95673=edit Breeze - No glitch This is the situation with Breeze: everything's OK -- You are receiving this mail because: You are the

[Powerdevil] [Bug 355804] New: Fresh boot to sddm and a few minutes of inactivity sends computer to Standby

2015-11-23 Thread Gregor Mi via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355804 Bug ID: 355804 Summary: Fresh boot to sddm and a few minutes of inactivity sends computer to Standby Product: Powerdevil Version: 5.4.3 Platform: Other OS: Linux

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

2015-11-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125968/ --- (Updated Nov. 23, 2015, 6:59 p.m.) Status -- This change has been

[Breeze] [Bug 355799] New: Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355799 Bug ID: 355799 Summary: Icons-only task manager has glitches with Breeze Dark theme Product: Breeze Version: 5.4.3 Platform: Archlinux Packages OS: Linux

[Powerdevil] [Bug 353356] Powerdevil does not respect the critical level configuration

2015-11-23 Thread LtWorf
https://bugs.kde.org/show_bug.cgi?id=353356 --- Comment #2 from Salvo "LtWorf" Tomaselli --- Critical is 6%, low is 10% -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list

[plasmashell] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355799 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|visual-des...@kde.org

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

2015-11-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125968/#review88731 --- Ship it! Ship It! - Marco Martin On Nov. 23, 2015, 5:22

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88730 --- libs/mediacenter/lastfmimagefetcher.cpp (line 152)

[Powerdevil] [Bug 348082] monitor is randomly powered back on

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=348082 Kai Uwe Broulik changed: What|Removed |Added CC|

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88735 --- CMakeLists.txt (line 122)

Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- Review request for Plasma, Marco Martin and Martin Klapetek. Repository:

Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- Review request for Plasma. Bugs: ?

Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

2015-11-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126150/ --- Review request for Plasma. Bugs: 33

Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/ --- Review request for Plasma, KDE Usability and Jonathan Riddell. Bugs: