Re: [Qemu-devel] [PATCH 1/2] hw/pflash_cfi01.c: Make read after byte-write or erase return status

2013-02-21 Thread Peter Crosthwaite
No breakages for Microblaze test cases and series looks good. On Tue, Jan 22, 2013 at 12:08 AM, Peter Maydell peter.mayd...@linaro.org wrote: The Intel flash command set requires that a read operation after doing a 'single byte write' command returns the status register; add this case to

Re: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: Treat read in unknown command state as read

2013-02-21 Thread Peter Crosthwaite
On Tue, Jan 22, 2013 at 12:08 AM, Peter Maydell peter.mayd...@linaro.org wrote: The code for handling the default unknown command state case in pflash_read in pflash_cfi01.c comments reset state treat it as a read. However the code doesn't actually do this. Moving the default case to the top

Re: [Qemu-devel] [PATCH 32/41] qemu-file: add writable socket QEMUFile

2013-02-21 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/migration/qemu-file.h |2 +- migration-tcp.c |2 +- migration-unix.c |2 +- savevm.c | 33 +++--

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0

2013-02-21 Thread Peter Crosthwaite
Hi Paolo, On Tue, Feb 19, 2013 at 7:07 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/02/2013 05:02, Peter Crosthwaite ha scritto: num_interfaces only tells you how many interfaces the concrete child class has (as defined in the TypeInfo). This means if you have a child class which

Re: [Qemu-devel] [RESEND PATCH v2 0/2] seabios q35: Fix seabios IRQ mapping and setup

2013-02-21 Thread Gerd Hoffmann
On 02/15/13 22:11, Alex Williamson wrote: This enables interrupts to work pre-boot for assigned devices. I had self nak'd and resent a v2 patch for 2/2, but there were never any comments, so resending the whole series as v2. Thanks, btw: With all the reorg going on in master atm I think it

Re: [Qemu-devel] Block I/O optimizations

2013-02-21 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 7:19 PM, Loic Dachary l...@dachary.org wrote: I recently tried to figure out the best and easiest ways to increase block I/O performances with qemu. Not being a qemu expert, I expected to find a few optimization tricks. Much to my surprise, it appears that there are

Re: [Qemu-devel] [PATCH 33/41] qemu-file: simplify and export qemu_ftell

2013-02-21 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: Force a flush when qemu_ftell is called. This simplifies the buffer magic (it also breaks qemu_ftell for input QEMUFiles, but we never use it). Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- savevm.c | 20 1 files

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-21 Thread Roy Tam
2013/2/21 Roy Tam roy...@gmail.com: 2013/2/21 Paolo Bonzini pbonz...@redhat.com: Il 21/02/2013 01:35, Roy Tam ha scritto: QEMU system emulation has been thread-safe for a long time, and setting the CPU affinity is hurting performance badly. Remove the bogus code. Jacob Kroon reports

Re: [Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-21 Thread Markus Armbruster
FredBezies fredbez...@gmail.com writes: Could be also a bug related to texinfo 5.0 upgrade, indeed ! Anyway, besides removing this patch, which are the options ? Wait for Cole's fix to be committed, or apply it locally, or downgrade texinfo.

Re: [Qemu-devel] [PATCH v4 4/6] introduce new vma archive format

2013-02-21 Thread Dietmar Maurer
+This format contains a header which includes the VM configuration as +binary blobs, and a list of devices (dev_id, name). Is there a magic number, for quickly identifying whether a file is likely to be a vma? Yes ('VMA') What endianness are multi-byte numbers interpreted with?

Re: [Qemu-devel] [PATCH 30/41] qemu-file: fsync a writable stdio QEMUFile

2013-02-21 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: This is what fd_close does. Prepare for switching to a QEMUFile. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- savevm.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c

Re: [Qemu-devel] [PATCH] doc: document -netdev hubport

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 05:21:24PM +0100, Laszlo Ersek wrote: On 02/20/13 11:03, Stefan Hajnoczi wrote: Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-options.hx | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx

[Qemu-devel] [PATCH v2] doc: document -netdev hubport

2013-02-21 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-options.hx | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 4bc9c85..cd18ad1 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1404,7 +1404,8 @@ DEF(netdev,

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes, that's the right thing to do. Also, in QEMU you're doing:

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v5)

2013-02-21 Thread Kevin Wolf
On Wed, Feb 20, 2013 at 06:26:55PM +0100, Andreas Färber wrote: Am 20.02.2013 18:05, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: Am 20.02.2013 14:43, schrieb Anthony Liguori: This includes a de_DE translation from Kevin Wolf and an it translation from Paolo

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-21 Thread Dietmar Maurer
This should call bdrv_is_allocated_above like the other block jobs do. It would be needed later anyway to backup only the topmost image. I do not need that information now, so why do you want that I add dead code? I think you do. You're wasting time reading unallocated clusters and

Re: [Qemu-devel] [PATCH V2] tap: forbid creating multiqueue tap when hub is used

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 11:05:56AM +0800, Jason Wang wrote: Obviously, hub does not support multiqueue tap. So this patch forbids creating multiple queue tap when hub is used to prevent the crash when command line such as -net tap,queues=2 is used. Cc: qemu-sta...@nongnu.org

Re: [Qemu-devel] [PATCH 2/5] blockdev: add discard suboption to -drive

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 03:09:51PM +0100, Paolo Bonzini wrote: Il 13/02/2013 11:39, Stefan Hajnoczi ha scritto: .type = QEMU_OPT_STRING, .help = disk image, },{ +.name = discard, +.type = QEMU_OPT_STRING, +

Re: [Qemu-devel] Online resize of virtio-blk device does not emit udev event

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 09:34:45PM +0100, Milos Vyletel wrote: It looks like none of the block drivers handle this. drivers/md/dm*.c is a block driver and you showed that LVM (device-mapper) does raise a uevent when the device is resized. That would be the place to look. Stefan

Re: [Qemu-devel] [PATCH 34/41] migration: use QEMUFile for migration channel lifetime

2013-02-21 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: As a start, use QEMUFile to store the destination and close it. qemu_get_fd gets a file descriptor that will be used by the write callbacks. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/migration/migration.h |7 ---

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-21 Thread Dietmar Maurer
This should call bdrv_is_allocated_above like the other block jobs do. It would be needed later anyway to backup only the topmost image. I do not need that information now, so why do you want that I add dead code? I think you do. You're wasting time reading unallocated clusters

Re: [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data

2013-02-21 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: Second, drop the file descriptor indirection, and write directly to the QEMUFile. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/migration/migration.h |4 --- migration-exec.c | 12 --- migration-fd.c

[Qemu-devel] Build failure with -werror on i386

2013-02-21 Thread David Holsgrove
Configuring QEMU as ./configure --target-list=i386-softmmu --cpu=i386 --enable-werror results in following error cc1: warnings being treated as errors qemu-char.c: In function 'qmp_ringbuf_write': qemu-char.c:2764: error: passing argument 2 of 'g_base64_decode' from incompatible pointer type

Re: [Qemu-devel] [PATCH 2/5] blockdev: add discard suboption to -drive

2013-02-21 Thread Kevin Wolf
On Thu, Feb 21, 2013 at 09:48:56AM +0100, Stefan Hajnoczi wrote: On Wed, Feb 20, 2013 at 03:09:51PM +0100, Paolo Bonzini wrote: Il 13/02/2013 11:39, Stefan Hajnoczi ha scritto: .type = QEMU_OPT_STRING, .help = disk image, },{ +.name

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 09:36 +0100, Paolo Bonzini wrote: Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes,

[Qemu-devel] [PATCH] doc: fix sheepdog invalid texi @table @list syntax

2013-02-21 Thread Stefan Hajnoczi
Some versions of texinfo are not happy with @table @list: ./qemu-options.texi:1526: unknown command `list' ./qemu-options.texi:1526: table requires an argument: the formatter for @item ./qemu-options.texi:1526: warning: @table has text but no @item Use @table @code instead and mark each

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 02:10 +0100, Laszlo Ersek wrote: On 02/21/13 00:55, David Woodhouse wrote: Well... your test now works because of the bug that Anthony is trying to fix :) I don't believe so, Ok, for the *specific* variant of the test that you did. But there are many tests you could

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 08:46 +0100, Paolo Bonzini wrote: You may go ahead and send a pull request (note that we do send the other patches together with a pull request, just the cover letter has [PULL 0/4] and the git request-pull output). Thanks. I suppose I'd better test that I haven't broken

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-21 Thread Jason Wang
On 02/20/2013 10:23 PM, Michael S. Tsirkin wrote: On Fri, Feb 01, 2013 at 06:03:32PM +0800, Jason Wang wrote: Hello all: During testing, I find doing scp during migration with vhost fails with warnings in guest like: Corrupted MAC on input. Disconnecting: Packet corrupt. lost connection

Re: [Qemu-devel] [PATCH] docs: Fix generating qemu-doc.html with texinfo 5

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 12:20:31PM -0500, Cole Robinson wrote: LC_ALL=C makeinfo --no-headers --no-split --number-sections --html qemu-doc.texi -o qemu-doc.html ./qemu-options.texi:1521: unknown command `list' ./qemu-options.texi:1521: table requires an argument: the formatter for @item

Re: [Qemu-devel] [PATCH] doc: fix sheepdog invalid texi @table @list syntax

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 10:13:33AM +0100, Stefan Hajnoczi wrote: Some versions of texinfo are not happy with @table @list: ./qemu-options.texi:1526: unknown command `list' ./qemu-options.texi:1526: table requires an argument: the formatter for @item ./qemu-options.texi:1526: warning:

Re: [Qemu-devel] [PATCH] doc: fix sheepdog invalid texi @table @list syntax

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 10:13:33AM +0100, Stefan Hajnoczi wrote: Some versions of texinfo are not happy with @table @list: ./qemu-options.texi:1526: unknown command `list' ./qemu-options.texi:1526: table requires an argument: the formatter for @item ./qemu-options.texi:1526: warning:

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 09:13, Roy Tam ha scritto: Yes, at least linux kernel starts but stalls when hitting IO-APIC thingy, with noapic boot switch it stalls after detecting ttyS0 With patch, QEMU is unresponsive when loading vmlinuz (not even showing Decompressing Linux message) Clarify that

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc: fixed RAM initialization bug in hw/ppc4xx_devs.c, can now use memory larger than 256MB in bamboo PPC machines

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 09:36:09PM -0500, Alin Tomescu wrote: I hope this is the right way of submitting QEMU patches. I was trying to launch a PowerPC bamboo machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just

Re: [Qemu-devel] [PATCH] .gitignore: Ignore optionrom/*.asm

2013-02-21 Thread Stefan Hajnoczi
On Tue, Feb 19, 2013 at 05:41:28PM -0500, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

Re: [Qemu-devel] [PATCH] Add some missing qtest binaries to .gitignore

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 01:34:40PM +1100, David Gibson wrote: These binaries are generated during make check on at least some configurations, so att them to .gitignore. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- tests/.gitignore |7 +++ 1 file changed, 7

Re: [Qemu-devel] [RFC PATCH v2 19/23] qcow2: Add error handling to the l2meta coroutine

2013-02-21 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 04:42:55PM +0100, Stefan Hajnoczi wrote: On Wed, Feb 13, 2013 at 02:22:09PM +0100, Kevin Wolf wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 57552aa..2819336 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -774,11 +774,33 @@ static void coroutine_fn

Re: [Qemu-devel] [RFC PATCH v2 20/23] qcow2: Cancel COW when overwritten

2013-02-21 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 04:46:49PM +0100, Stefan Hajnoczi wrote: On Wed, Feb 13, 2013 at 02:22:10PM +0100, Kevin Wolf wrote: @@ -707,6 +710,16 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, QCowL2Meta *m) } /* Update L2 table. */ +

[Qemu-devel] [PULL 0/5] Trivial patches for 6 to 21 February 2013

2013-02-21 Thread Stefan Hajnoczi
The 1.5 merge window is open, let's get patches moving again! The following changes since commit 7d2a929feba319c18603e324b1750830d6c8b7a1: vnc-tls: Fix compilation with newer versions of GNU-TLS (2013-02-18 08:40:20 -0600) are available in the git repository at:

[Qemu-devel] [PATCH 2/5] xilinx_axienet.c: Assert no error when making link

2013-02-21 Thread Stefan Hajnoczi
From: Peter Crosthwaite peter.crosthwa...@xilinx.com This gives an awful silent failure when it doesn't work. Assert against link creation failure. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/xilinx_axienet.c | 4 +++-

[Qemu-devel] [PATCH 5/5] .gitignore: Ignore optionrom/*.asm

2013-02-21 Thread Stefan Hajnoczi
From: Cole Robinson crobi...@redhat.com Signed-off-by: Cole Robinson crobi...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 53fe9c3..27ad002 100644 --- a/.gitignore +++

Re: [Qemu-devel] [PATCH] Remove elderly top level TODO file

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 04:24:22PM +, Peter Maydell wrote: The top level TODO file hasn't been touched since 2008, so it's now an unhelpful and out of date mix of things that have already been done, things that don't make sense any more and things which could in theory be done but are not

[Qemu-devel] [PATCH] net: reduce the unnecessary memory allocation of multiqueue

2013-02-21 Thread Jason Wang
Edivaldo reports a problem that the array of NetClientState in NICState is too large - MAX_QUEUE_NUM(1024) which will wastes memory even if multiqueue is not used. Instead of static arrays, solving this issue by allocating the queues on demand for both the NetClientState array in NICState and

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-21 Thread Jason Wang
On 02/21/2013 12:48 AM, Michael S. Tsirkin wrote: On Wed, Feb 20, 2013 at 04:23:52PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 01, 2013 at 06:03:32PM +0800, Jason Wang wrote: Hello all: During testing, I find doing scp during migration with vhost fails with warnings in guest like:

[Qemu-devel] [PATCH 10/14] usb-redir: simplify packet copy

2013-02-21 Thread Gerd Hoffmann
usb_packet_copy can handle combined packets now, so it isn't needed to special-case them any more. Also use the new usb_packet_size() function. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff

[Qemu-devel] [PATCH 13/14] usb-xhci: usb3 streams

2013-02-21 Thread Gerd Hoffmann
Add streams support to the xhci emulation. No secondary streams yet, only linear stream arays are supported for now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 268 - trace-events |6 +- 2 files changed,

[Qemu-devel] [PATCH 14/14] uas-uas: usb3 streams

2013-02-21 Thread Gerd Hoffmann
Add usb3 streams support to the uas (usb attached scsi) emulation. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-uas.c | 247 -- 1 file changed, 205 insertions(+), 42 deletions(-) diff --git a/hw/usb/dev-uas.c

[Qemu-devel] [PATCH 06/14] usb-host: move legacy cmd line bits

2013-02-21 Thread Gerd Hoffmann
The code handling the -usbdevice host:... legacy command line syntax is moved to the new hw/usb/host-legacy.c file. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure|2 +- hw/usb/Makefile.objs |2 +- hw/usb/host-legacy.c | 144

[Qemu-devel] [PATCH 1/5] Remove forward declaration of non-existant variable

2013-02-21 Thread Stefan Hajnoczi
From: Hervé Poussineau hpous...@reactos.org This variable has been removed 5 years ago in 970ac5a3082428dca91171f270dcd95d6f4b2636. Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/sysemu/sysemu.h | 1 - 1 file changed, 1

[Qemu-devel] [PATCH 12/14] usb-core: usb3 streams

2013-02-21 Thread Gerd Hoffmann
This patch adds support for usb3 streams to the usb subsystem core. This is just adding a streams field / parameter in a number of places. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h | 10 ++ hw/usb/core.c | 10 ++

[Qemu-devel] [PULL 00/14] usb patch queue

2013-02-21 Thread Gerd Hoffmann
Hi, master is open again, time to push the bits piled up in the usb queue during the freeze. Most significant change is the usb3 streams support. Other than that there are a bunch of little fixes and some preparation for switch usb-host over to libusb. pleaase pull, Gerd The following

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-21 Thread Roy Tam
2013/2/21 Paolo Bonzini pbonz...@redhat.com: Il 21/02/2013 09:13, Roy Tam ha scritto: Yes, at least linux kernel starts but stalls when hitting IO-APIC thingy, with noapic boot switch it stalls after detecting ttyS0 With patch, QEMU is unresponsive when loading vmlinuz (not even

[Qemu-devel] [PATCH 3/5] Add some missing qtest binaries to .gitignore

2013-02-21 Thread Stefan Hajnoczi
From: David Gibson da...@gibson.dropbear.id.au These binaries are generated during make check on at least some configurations, so att them to .gitignore. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/.gitignore | 7 +++

[Qemu-devel] [PATCH 09/14] usb: make usb_packet_copy operate on combined packets

2013-02-21 Thread Gerd Hoffmann
Likewise usb_packet_skip. Also usb_packet_size. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h |1 + hw/usb/core.c | 19 ++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index af86fbd..0d09e02 100644 --- a/hw/usb.h

[Qemu-devel] [PATCH 03/14] make usb devices configurable

2013-02-21 Thread Gerd Hoffmann
Leave the core usb devices (usb hub, tablet, mouse, keyboard) enabled unconditionally. Make the other ones configurable. Exceptions: - bluetooth: not qdevified yet, has a vl.c dependency because of that, thus disabling isn't as easy as not linking the object file. - smardcard:

[Qemu-devel] [PATCH 07/14] usb-host: remove usb_host_device_close

2013-02-21 Thread Gerd Hoffmann
Nobody implements that anyway. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h|1 - hw/usb/host-bsd.c |6 -- hw/usb/host-linux.c | 24 hw/usb/host-stub.c |5 - vl.c|5 +++-- 5 files changed, 3

Re: [Qemu-devel] [RFC PATCH v2 19/23] qcow2: Add error handling to the l2meta coroutine

2013-02-21 Thread Kevin Wolf
On Thu, Feb 21, 2013 at 10:35:42AM +0100, Kevin Wolf wrote: On Mon, Feb 18, 2013 at 04:42:55PM +0100, Stefan Hajnoczi wrote: On Wed, Feb 13, 2013 at 02:22:09PM +0100, Kevin Wolf wrote: diff --git a/block/qcow2.c b/block/qcow2.c index 57552aa..2819336 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH 02/14] fix scripts/make_device_config.sh

2013-02-21 Thread Gerd Hoffmann
Make it handle multiple include statements in a file: (1) The printf needs a space so the include files will be separated. (2) Also $f can contain multiple failes, so redirection will not work and we have to use cat to process all files. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 05/14] usb-storage: use scsi_req_enqueue return value

2013-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-storage.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index b89d00f..d3f01aa 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -400,6 +400,7 @@

[Qemu-devel] [PATCH 11/14] usb: fix endpoint descriptor ordering

2013-02-21 Thread Gerd Hoffmann
Fix the ordering of the endpoint descriptors for superspeed endpoints: The superspeed companion must come first, possible additional descriptors for the endpoint after that. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/desc.c |9 + 1 file changed, 5 insertions(+), 4

[Qemu-devel] [PATCH 4/5] ppc: fix bamboo 256MB RAM initialization in hw/ppc4xx_devs.c

2013-02-21 Thread Stefan Hajnoczi
From: Alin Tomescu tomescu.a...@gmail.com I was trying to launch a PowerPC bamboo machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just hang. However, when I used -m 256, the machine would boot. I looked through the code

[Qemu-devel] [PATCH 08/14] usb: add usb_ep_set_halted

2013-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h |1 + hw/usb/core.c |6 ++ 2 files changed, 7 insertions(+) diff --git a/hw/usb.h b/hw/usb.h index 90024a4..af86fbd 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -417,6 +417,7 @@ void usb_ep_set_max_packet_size(USBDevice

Re: [Qemu-devel] [PATCH V10 0/5] VMXNET3 paravirtual NIC device implementation

2013-02-21 Thread Stefan Hajnoczi
Hi Dmitry, The net multiqueue feature went into QEMU 1.4 and conflicts with vmxnet3.c. Please post a rebased version onto qemu.git/master so vmxnet3 can be merged. I'm currently getting the following compiler errors with these patches: hw/vmxnet3.c: In function ‘vmxnet3_set_variable_mac’:

[Qemu-devel] [PATCH 04/14] allow disabling usb smartcard support

2013-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/Makefile.objs |2 ++ hw/usb/Makefile.objs |1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/Makefile.objs b/hw/Makefile.objs index 447e32a..a1f3a80 100644 --- a/hw/Makefile.objs +++ b/hw/Makefile.objs @@ -38,8

[Qemu-devel] [PATCH 01/14] usb: Makefile cleanup

2013-02-21 Thread Gerd Hoffmann
Group files, sprinkle in some comments. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/Makefile.objs | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs index d1bbbc0..bfe5e5f 100644 ---

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 09:17 +, David Woodhouse wrote: Thanks. I suppose I'd better test that I haven't broken suspend/resume first. I don't care about OS/2 or VDISK, but it's vaguely possible that suspend/resume might be another reset user which actually *would* be offended if the PAM

[Qemu-devel] [PATCH v5 0/6] Efficient VM backup for qemu

2013-02-21 Thread Dietmar Maurer
This series provides a way to efficiently backup VMs. * Backup to a single archive file * Backup contain all data to restore VM (full backup) * Do not depend on storage type or image format * Avoid use of temporary storage * store sparse images efficiently The file docs/backup.txt contains more

[Qemu-devel] [PATCH v5 3/6] add backup related monitor commands

2013-02-21 Thread Dietmar Maurer
We use a generic BackupDriver struct to encapsulate all archive format related function. Another option would be to simply dump devid,cluster_num,cluster_data to the output fh (pipe), and an external binary saves the data. That way we could move the whole archive format related code out of qemu.

[Qemu-devel] [PATCH v5 5/6] add regression tests for backup

2013-02-21 Thread Dietmar Maurer
Simple regression tests using vma-reader and vma-writer. Signed-off-by: Dietmar Maurer diet...@proxmox.com --- tests/Makefile | 11 +- tests/backup-test.c | 529 +++ 2 files changed, 538 insertions(+), 2 deletions(-) create mode 100644

[Qemu-devel] [PATCH v5 6/6] add vm state to backups

2013-02-21 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer diet...@proxmox.com --- blockdev.c | 196 +- hmp.c|3 +- qapi-schema.json |5 +- 3 files changed, 200 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index

[Qemu-devel] [PATCH v5 2/6] add basic backup support to block driver

2013-02-21 Thread Dietmar Maurer
Function backup_job_create() creates a block job to backup a block device. The coroutine is started with backup_job_start(). We call backup_do_cow() for each write during backup. That function reads the original data and pass it to backup_dump_cb(). The tracked_request infrastructure is used to

[Qemu-devel] [PATCH v5 1/6] add documenation for new backup framework

2013-02-21 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer diet...@proxmox.com --- docs/backup.txt | 116 +++ 1 files changed, 116 insertions(+), 0 deletions(-) create mode 100644 docs/backup.txt diff --git a/docs/backup.txt b/docs/backup.txt new file mode 100644 index

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-21 Thread Dietmar Maurer
I think you do. You're wasting time reading unallocated clusters and checking that they are zero. bdrv_is_allocated_above gives you the same information much more efficiently. I thought that just returns information if the data is allocated, or if data is on backing file? Or

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2013 at 05:57:04PM +0800, Jason Wang wrote: On 02/21/2013 12:48 AM, Michael S. Tsirkin wrote: On Wed, Feb 20, 2013 at 04:23:52PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 01, 2013 at 06:03:32PM +0800, Jason Wang wrote: Hello all: During testing, I find doing scp

Re: [Qemu-devel] [PATCHv2] NVMe: Initial commit for NVM Express device

2013-02-21 Thread Kevin Wolf
On Fri, Dec 14, 2012 at 05:44:37PM -0700, Keith Busch wrote: NVM Express is an open standard for PCI-e attached Non-Volatile Memory storage. This commit adds an emulated device that supports the register interface and command set defined by this standard. The standard can be viewed at

Re: [Qemu-devel] Live migration using qcow2

2013-02-21 Thread Dietmar Maurer
The problem is about cache coherency. Local files work just fine with cache=writeback, but if you migrate to a different host, you get the problem that the destination kernel may cache some parts of the image while the source is still writing to it. When you do the actual switch to the

Re: [Qemu-devel] [PATCH 32/41] qemu-file: add writable socket QEMUFile

2013-02-21 Thread Paolo Bonzini
+static int socket_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, int size) +{ +QEMUFileSocket *s = opaque; +ssize_t len; + +len = qemu_send_full(s-fd, buf, size, 0); +if (len == -1) { +len = -socket_error(); +} We won't always detect

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0

2013-02-21 Thread Paolo Bonzini
diff --git a/qom/object.c b/qom/object.c index 4b72a64..3d638ff 100644 --- a/qom/object.c +++ b/qom/object.c @@ -449,7 +449,8 @@ ObjectClass *object_class_dynamic_cast(ObjectClass *class, TypeImpl *type = class-type; ObjectClass *ret = NULL; -if

Re: [Qemu-devel] [RFC PATCH v2 20/23] qcow2: Cancel COW when overwritten

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 10:47:05AM +0100, Kevin Wolf wrote: On Mon, Feb 18, 2013 at 04:46:49PM +0100, Stefan Hajnoczi wrote: On Wed, Feb 13, 2013 at 02:22:10PM +0100, Kevin Wolf wrote: @@ -707,6 +710,16 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, QCowL2Meta *m) }

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Peter Maydell
On 24 January 2013 15:47, Andreas Färber afaer...@suse.de wrote: config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual ./config-devices.mak. Symptoms were spurious build failures due to

Re: [Qemu-devel] [PATCH v4 1/6] add documenation for new backup framework

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 05:14:04AM +, Dietmar Maurer wrote: Thanks for writing this up. I don't think docs/backup.txt should be committed as-is though because it refers to you proposing this patch series. Once merged some of this document will no longer be relevant. Why will

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 05:23:30AM +, Dietmar Maurer wrote: +static void coroutine_fn backup_run(void *opaque) { +BackupBlockJob *job = opaque; +BlockDriverState *bs = job-common.bs; +assert(bs); + +int64_t start, end; + +start = 0; +end =

Re: [Qemu-devel] [PATCH] move qemu-ga from bin to libexec dir, use $HELPERS

2013-02-21 Thread Michael Tokarev
Ping? I received no answer neither to my original question (why qemu-ga is in /usr/bin) nor to this patch. Thanks, /mjt 16.02.2013 22:28, Michael Tokarev wrote: This patch does 3 things: 1. Renames HELPERS-y Makefile variable to HELPERS 2. Moves its definition from Makefile to configure

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-21 Thread Paolo Bonzini
- Messaggio originale - Da: Dietmar Maurer diet...@proxmox.com A: Paolo Bonzini pbonz...@redhat.com Cc: qemu-devel@nongnu.org Inviato: Giovedì, 21 febbraio 2013 12:40:52 Oggetto: RE: [PATCH v3 2/6] add basic backup support to block driver I think you do. You're wasting time

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Andreas Färber
Am 21.02.2013 13:34, schrieb Peter Maydell: On 24 January 2013 15:47, Andreas Färber afaer...@suse.de wrote: config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual ./config-devices.mak.

[Qemu-devel] [PATCH 2/9] vring: introduce vring_restore() to restore from img

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Re-initialize the members of vring correctly is required when restored from img. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/vring.c |6 ++ hw/dataplane/vring.h |1 + 2 files changed, 7 insertions(+), 0

[Qemu-devel] [PATCH 3/9] event poll: make epoll work for normal fd

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com When event poll can work with normal fd, we can port them onto the event loop. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c | 36 hw/dataplane/event-poll.h |8

[Qemu-devel] [PATCH 4/9] event poll: pass event type to event callback

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com With this extra arg -- event type, we can support the standard events dispatched by epoll_wait() Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c |4 ++-- hw/dataplane/event-poll.h |2 +-

[Qemu-devel] [PATCH 6/9] virtio net: introduce dataplane for virtio net

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com This is a emulation to virtio-blk dataplane, which push the data handling out of biglock. And it is a try to implement this process in userspace, while vhost-net in kernel. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 8/9] virtio net: enable dataplane for virtio net

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/virtio-net.c | 38 ++ hw/virtio-net.h |3 +++ hw/virtio-pci.c |2 +- 3 files changed, 42 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread Liu Ping Fan
This is a emulation to virtio-blk dataplane, which push the data handling out of biglock. And it is a try to implement this process in userspace, while vhost-net in kernel. The iperf's result show it improving the perfermance of base line, but still slower than vhost-net (maybe the rx path need

[Qemu-devel] [PATCH 7/9] tap: make tap peer work on dedicated data-plane thread

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/virtio-net.c | 22 +++ hw/dataplane/virtio-net.h |6 +++ include/net/tap.h |6 +++ net/tap.c | 92

Re: [Qemu-devel] [PATCH v4 4/6] introduce new vma archive format

2013-02-21 Thread Kevin Wolf
On Thu, Feb 21, 2013 at 08:20:28AM +, Dietmar Maurer wrote: Honestly, 64k*4G = 128T is not a limit for me. And we still have one byte reserved, so we can have up to 1P per image, and up to 253 images. For now I have no plans to backup such large VMs. 640k ought to be enough for

Re: [Qemu-devel] [PATCH v4 3/6] add backup related monitor commands

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 06:21:32AM +, Dietmar Maurer wrote: +/* add configuration file to archive */ +if (has_config_file) { +char *cdata = NULL; +gsize clen = 0; +GError *err = NULL; +if (!g_file_get_contents(config_file, cdata, clen,

[Qemu-devel] [PATCH 1/9] vring: split the modification and publish of used ring

2013-02-21 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Currently, vring_push() modify used ring and publish it, but sometime, we need to gather the changes and publish them all at once. So introduce vring_fill(), vring_flush(). Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-21 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 06:53:24AM +, Dietmar Maurer wrote: Interesting series, the backup block job makes sense to me. Regarding efficiency, I think incremental backup is a must, One can easily implement incremental backup on top of this patches. That is why I introduced the

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote: Interesting series, the backup block job makes sense to me. Regarding efficiency, I think incremental backup is a must, otherwise regular backups using this approach won't really be a win over backing files. Incremental

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-21 Thread Kevin Wolf
On Thu, Feb 21, 2013 at 06:53:24AM +, Dietmar Maurer wrote: How would VMA fit in if the backup block job took a BlockDriverState destination and vmsave worked atomically with backup block jobs? You could have QEMU write to NBD server ports that a VMA writer process has open. VMA would

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-21 Thread Kevin Wolf
On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote: The backup writer abstraction is a special case interface somewhere between an image format and live migration. I'd prefer it if the backup block job stuck to BlockDriverState as the destination for backup data. Then you

[Qemu-devel] [RFC PATCH 3/3] KVM: s390: Hook up ioeventfds.

2013-02-21 Thread Cornelia Huck
As s390 doesn't use memory writes for virtio notifcations, create a special kind of ioeventfd instead that hooks up into diagnose 0x500 (kvm hypercall) with function code 3 (virtio-ccw notification). Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- arch/s390/include/asm/kvm_host.h | 23

  1   2   3   4   >