Re: patch and observations

[Matt Sergeant]

On 26 Dec 2004, at 06:16, Fred Moyer wrote:
I was playing around with Apache::Qpsmtpd today with mod_perl 1.99_17, 
and
I needed to patch the source as follows.  One other thing I had to do 
was
to symbolically link all files in /var/qmail/control to
/home/httpd/qpsmtpd/config/.  I don't know if that's a standard part of
setting this up, but I ran into a few problems when $self->qp->config
variables were undefined.  Thanks for this interface, it's nice to be 
able
to manage smtp services under Apache.
Thanks for the patch. Now that mod_perl 2.0-RC2 is out I should be able 
to update things, and also get the early-talker code working under 
apache (because mod_perl 2.0-rc2 supports a poll() interface).

Matt.

patch and observations

[Fred Moyer]

Greetings,

I was playing around with Apache::Qpsmtpd today with mod_perl 1.99_17, and
I needed to patch the source as follows.  One other thing I had to do was
to symbolically link all files in /var/qmail/control to
/home/httpd/qpsmtpd/config/.  I don't know if that's a standard part of
setting this up, but I ran into a few problems when $self->qp->config
variables were undefined.  Thanks for this interface, it's nice to be able
to manage smtp services under Apache.

--- lib/Apache/Qpsmtpd.pm.orig  2004-12-25 20:10:38.789193152 -0800 +++
lib/Apache/Qpsmtpd.pm   2004-12-25 21:10:45.736853760 -0800 @@ -144,7
+144,7 @@
 my $bb = $self->{bb_out};
 my $line = $code . (@messages?"-":" ").$msg;
 $self->log(LOGDEBUG, $line);
-my $bucket = APR::Bucket->new("$line\r\n");
+my $bucket = APR::Bucket->new($bb->bucket_alloc, "$line\r\n");
 $bb->insert_tail($bucket);
 $c->output_filters->fflush($bb);
 $bucket->remove;