Re: [PR] [SPARK-53501][PYTHON][CORE] Extract PythonWorkerFactory cache from SparkEnv [spark]

2026-03-05 Thread via GitHub 


HyukjinKwon commented on code in PR #54604:
URL: https://github.com/apache/spark/pull/54604#discussion_r2888593195


##
core/src/main/scala/org/apache/spark/SparkEnv.scala:
##


Review Comment:
   SparkEnv is actually a developer API. I think we can't just remove them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [SPARK-53501][PYTHON][CORE] Extract PythonWorkerFactory cache from SparkEnv [spark]

2026-03-05 Thread via GitHub 


zhengruifeng commented on PR #54604:
URL: https://github.com/apache/spark/pull/54604#issuecomment-4003258786

   cc @gaogaotiantian @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] [SPARK-53501][PYTHON][CORE] Extract PythonWorkerFactory cache from SparkEnv [spark]

2026-03-03 Thread via GitHub 


fangchenli opened a new pull request, #54604:
URL: https://github.com/apache/spark/pull/54604

   
   
   ### What changes were proposed in this pull request?
   
   Move PythonWorkerFactory cache from SparkEnv to a new class 
PythonWorkerManager. There was a closed PR #52250. My is similar to that one 
but with a smaller scope.
   
   
   ### Why are the changes needed?
   
   Avoid polluting SparkEnv with the logic that manages the lifecycle of 
PythonWorkerFactory.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   
   ### How was this patch tested?
   
   Existing tests, and new tests added.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]