Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]

2026-03-05 Thread via GitHub 


allisonwang-db closed pull request #54606: [SPARK-55822][SQL] Rename 
`_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE`
URL: https://github.com/apache/spark/pull/54606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]

2026-03-05 Thread via GitHub 


ilicmarkodb commented on PR #54606:
URL: https://github.com/apache/spark/pull/54606#issuecomment-4003802559

   @cloud-fan can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]

2026-03-04 Thread via GitHub 


ilicmarkodb commented on code in PR #54606:
URL: https://github.com/apache/spark/pull/54606#discussion_r2883070415


##
common/utils/src/main/resources/error/error-conditions.json:
##
@@ -1049,6 +1049,12 @@
 },
 "sqlState" : "21S01"
   },
+  "CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE" : {
+"message" : [
+  "CREATE VIEW with both IF NOT EXISTS and REPLACE is not allowed."

Review Comment:
   done, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]

2026-03-04 Thread via GitHub 


mihailoale-db commented on code in PR #54606:
URL: https://github.com/apache/spark/pull/54606#discussion_r2882626976


##
common/utils/src/main/resources/error/error-conditions.json:
##
@@ -1049,6 +1049,12 @@
 },
 "sqlState" : "21S01"
   },
+  "CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE" : {
+"message" : [
+  "CREATE VIEW with both IF NOT EXISTS and REPLACE is not allowed."

Review Comment:
   Let's add the view name here to improve the error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]