[jira] [Updated] (S4-63) onTime() events are not synchronized correctly

2012-06-28 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/S4-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Gómez Ferro updated S4-63:
-

Attachment: 0001-Fix-timers-synchronization.patch

Used --no-prefix last time.

> onTime() events are not synchronized correctly
> --
>
> Key: S4-63
> URL: https://issues.apache.org/jira/browse/S4-63
> Project: Apache S4
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: Daniel Gómez Ferro
> Fix For: 0.5
>
> Attachments: 0001-Fix-timers-synchronization.patch, 
> 0001-Fix-timers-synchronization.patch, S4-63-synchronize-onTime-events.patch, 
> S4-63-synchronize-onTime-events.patch
>
>
> onTime() events are executed by a separate thread and are not synchronized 
> correctly with the rest of events, since ProcessingElement.OnTimerTask's 
> run() method synchronizes on "this" (the thread object) instead of the PE 
> instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (S4-63) onTime() events are not synchronized correctly

2012-06-27 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/S4-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Gómez Ferro updated S4-63:
-

Attachment: 0001-Fix-timers-synchronization.patch

Patch recreated with format-patch

> onTime() events are not synchronized correctly
> --
>
> Key: S4-63
> URL: https://issues.apache.org/jira/browse/S4-63
> Project: Apache S4
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: Daniel Gómez Ferro
> Fix For: 0.5
>
> Attachments: 0001-Fix-timers-synchronization.patch, 
> S4-63-synchronize-onTime-events.patch, S4-63-synchronize-onTime-events.patch
>
>
> onTime() events are executed by a separate thread and are not synchronized 
> correctly with the rest of events, since ProcessingElement.OnTimerTask's 
> run() method synchronizes on "this" (the thread object) instead of the PE 
> instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (S4-63) onTime() events are not synchronized correctly

2012-06-22 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/S4-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Gómez Ferro updated S4-63:
-

Attachment: S4-63-synchronize-onTime-events.patch

Grant license to ASF

> onTime() events are not synchronized correctly
> --
>
> Key: S4-63
> URL: https://issues.apache.org/jira/browse/S4-63
> Project: Apache S4
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: Daniel Gómez Ferro
> Fix For: 0.5
>
> Attachments: S4-63-synchronize-onTime-events.patch, 
> S4-63-synchronize-onTime-events.patch
>
>
> onTime() events are executed by a separate thread and are not synchronized 
> correctly with the rest of events, since ProcessingElement.OnTimerTask's 
> run() method synchronizes on "this" (the thread object) instead of the PE 
> instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (S4-63) onTime() events are not synchronized correctly

2012-06-22 Thread Matthieu Morel (JIRA)

 [ 
https://issues.apache.org/jira/browse/S4-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthieu Morel updated S4-63:
-

Affects Version/s: 0.5
Fix Version/s: 0.5

> onTime() events are not synchronized correctly
> --
>
> Key: S4-63
> URL: https://issues.apache.org/jira/browse/S4-63
> Project: Apache S4
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: Daniel Gómez Ferro
> Fix For: 0.5
>
> Attachments: S4-63-synchronize-onTime-events.patch
>
>
> onTime() events are executed by a separate thread and are not synchronized 
> correctly with the rest of events, since ProcessingElement.OnTimerTask's 
> run() method synchronizes on "this" (the thread object) instead of the PE 
> instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (S4-63) onTime() events are not synchronized correctly

2012-06-22 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/S4-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Gómez Ferro updated S4-63:
-

Attachment: S4-63-synchronize-onTime-events.patch

This patch fixes the synchronization issue and adds a test case to guard 
against regressions.

I'm adding a dependency on Mockito for tests, and I'm adding a couple of void 
modules (BareCoreModule, BareCommModule) to make it easy to test components 
without the Comm layer.

> onTime() events are not synchronized correctly
> --
>
> Key: S4-63
> URL: https://issues.apache.org/jira/browse/S4-63
> Project: Apache S4
>  Issue Type: Bug
>Reporter: Daniel Gómez Ferro
> Attachments: S4-63-synchronize-onTime-events.patch
>
>
> onTime() events are executed by a separate thread and are not synchronized 
> correctly with the rest of events, since ProcessingElement.OnTimerTask's 
> run() method synchronizes on "this" (the thread object) instead of the PE 
> instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira