Hi Torque Devs,
I am in the process to test the update with Java 17 and some further changes
(TORQUE-364).
Yet, I want to wait for an upstream dependency to be releases (to be more
consistent ..)
Best regards,
Georg
-Ursprüngliche Nachricht-
Von: Kallidis, Georg
Gesendet: Donnerstag, 5. September 2024 17:02
An: 'Apache Torque Developers List' ; 'Max Philipp
Wriedt'
Betreff: AW: [DISCUSS] Prepare next Torque release with java 17 baseline
Hi Max,
Thanks!
I think we should do the Java 17 baseline update - but still waiting a few days
to allow for more opinions ...
Concerning your other questions/suggestions:
Java 21 could be considered of course as the next baseline later in 2026
(String Templates may be candidate for replacing velocity or groovy? Just a
thought, but there should be more real thoughts .. )
Template code: What do you mean with dropping one version? I did a short check
of the repo code. This revealed groovy code is currently used only (but
consistently) in torque-templates ddl with configuration file
torque-templates/src/main/resources/org/apache/torque/templates/sql/outlets/ddl.xml.
If this is true, it seems to be kind of a proof of concept. We may just keep
it, though this adds still a dependency to groovy, but at least declare
velocity as our main template language by default (almost this is the current
state). We could keep it, but add a velocity ddl in addition to the provided
groovy code, disable groovy configuration by default making groovy only an
optional dependency. And we could of course remove it entirely. Or the other
way around use groovy instead of velocity! This would result in a somewhat
bigger migration, but may nevertheless a solution! 😉
Repo structure: You may just checkout only
https://svn.apache.org/repos/asf/db/torque/trunk as
https://svn.apache.org/repos/asf/db/torque in svn is for having by default tags
and branches folders there, but also other substructures ...
About a version control migration to git: We may of course do a migration to
git. As an example, for the Apache Turbine project we did this about 2 years
ago and the way to go there was to use different git repos, which could mean -
all modules (Torque-templates, -runtime,-generator,-site,ant-tasks,
-maven-plugin) would be separate git repositories.
- Torque root would become a separate git repo as a maven multi module project
and including the modules as git submodules. As Git migration is now almost
completely automated by Apache INFRA we may done this in less than two or three
weeks. But we may open another discussion thread for this, if we think this is
now the next step to do.
And we could think about using gradle style project management and move to
Kotlin .. this would an alternative way in building Torque, but to maintain
both currently seems to me a bit out of what the project could provide - but
that's of course nevertheless a very nice thing! May be we could think about,
how it could be a contribution to the project as an optional build system? At
least keep it in mind ..
Best regards,
Georg
-Ursprüngliche Nachricht-
Von: Max Philipp Wriedt via torque-dev
Gesendet: Mittwoch, 4. September 2024 14:22
An: [email protected]
Betreff: Re: [DISCUSS] Prepare next Torque release with java 17 baseline
Hi Georg,
also a +1 from me.
The last software I updated from Java 8 was to 17 directly, skipping 11.
Oracle says they dropped "Premier Support" for 11 in 2023 (whatever that means
exactly)
https://www.oracle.com/de/java/technologies/java-se-support-roadmap.html
According to this we could also target the next LTS version (Java 21) for 2026?
Regarding the JDBC compatibility, I don't see any problems. The latest JDBC API
is Version 4.3 from Java SE 9, which we already skipped.
I would agree on modernisation of the template code (and maybe drop one
version? sql code is in groovy and velocity) Also I would like to address some
cleanup of the repository. I am more of a git user, so when I started to work
on the project i was a little confused about the folder structure of this
project. (e.g. torque4 still floating around somehow)
Max
P.S.: i also worked on a gradle-plugin version of the torque-generator,
which I could provide for implementation for an upcoming version. It is
currently written in Kotlin and uses a gradle-style project. Rewriting
it as a maven-project and in Java should be possible, but will need some
work.
Am 02.09.2024 um 16:52 schrieb Kallidis, Georg:
> Hi Torque Devs,
>
> what about to upgrade Java baseline to version 17 for the next release?
>
> This would be in line with Apache Turbine project v7, which does use Torque
> as ORM mapper, and is now in the process to upgrade to Java 17.
>
> In my opinion we do not need a vote for this, when discussing is sufficient
> and no one comes up with an better alternative or other cons
