[Bug 1875517] Re: check_http inefficient and sometimes times out
Haw, I have just uploaded all SRUs to the archive. Now the SRU team will be in charge of approving/reviewing them. After, and if, they are accepted, you will be asked to verify the fixes from [proposed] repository and change tags here at this bug, from verification-needed to verification- done. Would you be able to verify the fixes for me ? Please let me know if there is anything else you need on this. Best Regards Rafael D. Tinoco -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
** Description changed: [Impact] - * check_http nagios plugin module faces timeouts multiple times when - checking for http health. + * Based on the test case numbers, and the numbers provided by the end + user, it seems that memory reclaiming for the http buffer, in check_http + module, is the real issue here. It turns out that, a heavily overloaded + servers might be under big memory pressure and having difficulties + trying to reclaim heap memory pages (flushing dirty cache/buffers, + swapped_cached pages, or worst) for the check_http network buffer. [Test Case] - * not specific clear one. to measure http health in a big environment. - * being tested by real user case. + * Execute check_http with a 150MB file: + + - Unpatched (~ 108 sec) + + | $ /usr/lib/nagios/plugins/check_http -H archive.ubuntu.com -j GET -u /ubuntu/pool/main/l/linux-hwe-5.0/linux-hwe-5.0_5.0.0.orig.tar.gz -t 600 + | HTTP OK: HTTP/1.1 200 OK - 162594115 bytes in 108.216 second response time |time=108.215539s;;;0.00 size=162594115B;;;0 + + - Patched (~ 0.5 sec) + + | $ /usr/lib/nagios/plugins/check_http -H archive.ubuntu.com -j GET -u /ubuntu/pool/main/l/linux-hwe-5.0/linux-hwe-5.0_5.0.0.orig.tar.gz -t 600 + | HTTP OK: HTTP/1.1 200 OK - 162594115 bytes in 0.499 second response time + |time=0.498710s;;;0.00;600.00 size=162594115B;;;0 [Regression Potential] - * check_http module might face a regression (only code touched). - * we are using realloc instead of a new free/malloc for the http buffer - * change is based in an upstream commit and proposed by end-user + * Very little but existent for the network receiving buffer logic under check_http module. + * Change is based in an bigger upstream commit and only a minor subset of the upstream patch is being backported. [Other Info] - * Original Description: + * Original Description: Hi, We're frequently seeing socket timeouts with some checks using the check_http plugin. It seems this is a known issue with some fixes upstream: | https://github.com/nagios-plugins/nagios-plugins/commit/2b38350d546ef9632ccd90e300eeaf6eda0ca32c | https://github.com/nagios-plugins/nagios-plugins/commit/fc1bf94655aaed32eeb6fb5c33b6d093f5564bad Think we can backport these fixes? -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
** Also affects: monitoring-plugins (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: monitoring-plugins (Ubuntu Groovy) Importance: Undecided Status: In Progress ** Also affects: monitoring-plugins (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: monitoring-plugins (Ubuntu Focal) Importance: Undecided Status: New ** No longer affects: monitoring-plugins (Ubuntu Groovy) ** Changed in: monitoring-plugins (Ubuntu Bionic) Status: New => In Progress ** Changed in: monitoring-plugins (Ubuntu Eoan) Status: New => In Progress ** Changed in: monitoring-plugins (Ubuntu Focal) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
** Description changed: + [Impact] + + * check_http nagios plugin module faces timeouts multiple times when + checking for http health. + + [Test Case] + + * not specific clear one. to measure http health in a big environment. + * being tested by real user case. + + [Regression Potential] + + * check_http module might face a regression (only code touched). + * we are using realloc instead of a new free/malloc for the http buffer + * change is based in an upstream commit and proposed by end-user + + [Other Info] + + * Original Description: + Hi, We're frequently seeing socket timeouts with some checks using the check_http plugin. It seems this is a known issue with some fixes upstream: | https://github.com/nagios-plugins/nagios-plugins/commit/2b38350d546ef9632ccd90e300eeaf6eda0ca32c | https://github.com/nagios-plugins/nagios-plugins/commit/fc1bf94655aaed32eeb6fb5c33b6d093f5564bad Think we can backport these fixes? -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
Nice! Knowing that the patch is a a small subset of an upstream patch makes our life easier! Since you provided the test, we can go ahead and do the SRU with the testcase you provided. I'll sponsor the backport for you. ** Changed in: nagios-plugins (Ubuntu) Assignee: Rafael David Tinoco (rafaeldtinoco) => (unassigned) ** No longer affects: nagios-plugins (Ubuntu) ** Changed in: monitoring-plugins (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
@Haw, I need some clarification here. You have applied a temporary mitigation that improves check_http by not constantly freeing and allocating heap memory. You have indicated upstream patches (2 of them) dealing with the constant timeout for the checker. monitoring-plugins 2.2 version check_http SEEMs to be close to nagios- plugins 1.5 version. The nagios-plugins you pointed out are backportable to release-2.2.0 of NAGIOS-PLUGINS package and not monitoring-plugins. Have you tested those ? Do you need nagios-plugins backport (of those 2 patches) to test and see if it mitigates your issue ? Per SRU guidelines I can't simply backport those 2 without a testcase and the guarantee they're addressing your issue with a successful testcase being fixed. Waiting a feedback here. Thanks for reporting this. ** Also affects: nagios-plugins (Ubuntu) Importance: Undecided Status: New ** No longer affects: monitoring-plugins (Ubuntu Bionic) ** No longer affects: monitoring-plugins (Ubuntu Eoan) ** No longer affects: monitoring-plugins (Ubuntu Focal) ** No longer affects: monitoring-plugins (Ubuntu Groovy) ** No longer affects: nagios-plugins (Ubuntu Groovy) ** No longer affects: nagios-plugins (Ubuntu Focal) ** No longer affects: nagios-plugins (Ubuntu Eoan) ** No longer affects: nagios-plugins (Ubuntu Bionic) ** No longer affects: nagios-plugins (Ubuntu) ** Also affects: nagios-plugins (Ubuntu) Importance: Undecided Status: New ** Changed in: nagios-plugins (Ubuntu) Status: New => Triaged ** Changed in: nagios-plugins (Ubuntu) Assignee: (unassigned) => Rafael David Tinoco (rafaeldtinoco) -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1875517] Re: check_http inefficient and sometimes times out
$ git log -1 -p 2b38350d546ef9632ccd90e300eeaf6eda0ca32c | diffstat check_http.c | 127 + 1 file changed, 77 insertions(+), 50 deletions(-) $ git describe --tags 2b38350d546ef9632ccd90e300eeaf6eda0ca32c release-2.2.1-82-g2b38350d $ git log -1 -p fc1bf94655aaed32eeb6fb5c33b6d093f5564bad | diffstat check_http.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) $ git describe --tags fc1bf94655aaed32eeb6fb5c33b6d093f5564bad release-2.2.1-135-gfc1bf946 $ rmadison monitoring-plugins monitoring-plugins | 2.1.2-2ubuntu2 | xenial | source, all monitoring-plugins | 2.2-3ubuntu2 | bionic/universe | source, all monitoring-plugins | 2.2-5 | disco/universe | source, all monitoring-plugins | 2.2-6build2| eoan/universe | source, all monitoring-plugins | 2.2-6ubuntu1 | focal/universe | source, all monitoring-plugins | 2.2-6ubuntu1 | groovy/universe | source, all ** Tags added: server-next ** Changed in: monitoring-plugins (Ubuntu Bionic) Status: Confirmed => Triaged ** Changed in: monitoring-plugins (Ubuntu Eoan) Status: New => Triaged ** Changed in: monitoring-plugins (Ubuntu Groovy) Status: Confirmed => Triaged ** Changed in: monitoring-plugins (Ubuntu Focal) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1875517 Title: check_http inefficient and sometimes times out To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/monitoring-plugins/+bug/1875517/+subscriptions -- Ubuntu-server-bugs mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
