[MediaWiki-CodeReview] [MediaWiki r103658]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103658. Old Status: fixme New Status: new User Hashar also posted a comment on MediaWiki.r103658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103658#c26605 Commit summary: add click handler to switch instantly between pics Follow

[MediaWiki-CodeReview] [MediaWiki r104316]: New comment added

2011-11-28 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r104316. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104316#c26606 Commit summary: Revert r104309, does not work. Comment: The .uc-mask element, does not have a width. The bar is rendered using a border width instead. You can add a

[MediaWiki-CodeReview] [MediaWiki r100588]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100588. Old Status: ok New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100588 Commit summary: using real identity for hashar Converting my pseudonym to use my real identity instead: Ashar Voultoiz - Antoine Musso

[MediaWiki-CodeReview] [MediaWiki r104391]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104391. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104391 Commit summary: Added VipsScaler to the extension list ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104252]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104252 Commit summary: Special:Hieroglyphs: fix copypasta errors in descriptions, properly break on newlines

[MediaWiki-CodeReview] [MediaWiki r104253]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104253. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r104253. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104253#c26607 Commit summary: Damn you, Windows Comment: * \r (CR, Carriage Return)

[MediaWiki-CodeReview] [MediaWiki r104298]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104298. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104298 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r104352]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104352. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104352 Commit summary: WikiHiero: * Use protocol-relative URL in $wgExtensionCredits * Ran stylize.php * Fixed indentation

[MediaWiki-CodeReview] [MediaWiki r104362]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104362. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104362 Commit summary: Localisation updates for core and extension messages from translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r104324]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104324. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104324 Commit summary: docs++ ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104253]: New comment added

2011-11-28 Thread MediaWiki Mail
User MaxSem posted a comment on MediaWiki.r104253. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104253#c26609 Commit summary: Damn you, Windows Comment: After all, users easily insert several spaces between hieroglyphs - it doesn't break the parser either.

[MediaWiki-CodeReview] [MediaWiki r104311]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104311. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104311 Commit summary: Qqq for r99224 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104244]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104244. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104244 Commit summary: Remove trailing whitespace in a message. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104225]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104225. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104225 Commit summary: Removing whitespace added in r104224 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104190]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104190. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104190 Commit summary: Added Database::getServerUptime() function to return seconds of uptime ___

Re: [Wikitech-l] error lasted more than 10 minutes....

2011-11-28 Thread Roan Kattouw
On Mon, Nov 28, 2011 at 12:21 AM, Asher Feldman afeld...@wikimedia.org wrote: That page wasn't suitable for high volume public consumption (very expensive db query + not properly cached), so the site problem persisted even after the db initially suspected as bad was rotated out. What happened

[MediaWiki-CodeReview] [MediaWiki r102505]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102505 Commit summary: Throw a FatalError exception instead of calling OutputPage::showFatalError() (on usage of $wgOut less)

[MediaWiki-CodeReview] [MediaWiki r101634]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101634. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101634 Commit summary: * Use WikiPage instance of Article * Changed to call to directly create a Revision instead of going through WikiPage or

[MediaWiki-CodeReview] [MediaWiki r104407]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104407. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104407 Commit summary: very minor fix ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104408]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104408. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104408 Commit summary: r104381: Consistency tweaks in preparation for adding extension to translatewiki.net: * article - page * no dot at end the

[MediaWiki-CodeReview] [MediaWiki r104409]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104409. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104409 Commit summary: r104381: Adding extension to translatewiki.net ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r104381]: New comment added

2011-11-28 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r104381. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104381#c26610 Commit summary: initial extension commit Comment: The addthis-desc message is a bit of a strange sentence, imho. preAdds [http://www.addthis.com AddThis widget] to

[MediaWiki-CodeReview] [MediaWiki r104265]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104265. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104265 Commit summary: Fixed missing variable definition + reworded ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r104403]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104403. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104403 Commit summary: fixed i18n for named mime types ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104346]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104346. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104346 Commit summary: Forgot one word in Norwegian translation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99681]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r99681. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99681 Commit summary: Fix code viewer url ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r102510]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r102510. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102510 Commit summary: Fix spaces to tabs Fix double indenting Minor stylise normalisation ___

[MediaWiki-CodeReview] [MediaWiki r104424]: New comment added

2011-11-28 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104424. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104424#c26611 Commit summary: Spaces to tabs Comment: Bah. Added new folder also ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104280]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104280. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104280 Commit summary: Per Raymond on r104278, run numbers through formatNum() Tried using $this-getLanguage() and I was just getting a language

[MediaWiki-CodeReview] [MediaWiki r104289]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104289. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104289 Commit summary: Followup r104280 $lang was overridden in the loops, causing variable pollution Switched to use $this-getLanguage now

Re: [Wikitech-l] Final mobile switch-over

2011-11-28 Thread Guillaume Paumier
Hi, On Fri, Nov 25, 2011 at 1:47 PM, Thomas Dalton thomas.dal...@gmail.com wrote: On 23 November 2011 19:13, Philip Chang pch...@wikimedia.org wrote: We are suggesting that a home page customized for mobile viewing is perhaps more suitable, but I also understand the point you are making and

[MediaWiki-CodeReview] [MediaWiki r104412]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104412. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104412 Commit summary: Fix r104410: Added default value for $options to purgeThumbnails(), not sure how this was lost in the patch

[MediaWiki-CodeReview] [MediaWiki r104386]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104386. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104386 Commit summary: Fix for r99911: don't use getImageArea() to determine the area for comparison against $wgMaxImageArea, this breaks the

[MediaWiki-CodeReview] [MediaWiki r104389]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104389. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104389 Commit summary: MFT VipsScaler dependencies r99911, r99916, r99917, r101677, r104386, r104387, except omitting the interface change to

[MediaWiki-CodeReview] [MediaWiki r102662]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r102662. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102662 Commit summary: added missing message ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101312]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101312. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101312 Commit summary: Renamed getRevisionTags - getChangeTags ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] error lasted more than 10 minutes....

2011-11-28 Thread MZMcBride
Roan Kattouw wrote: On Mon, Nov 28, 2011 at 12:21 AM, Asher Feldman afeld...@wikimedia.org wrote: That page wasn't suitable for high volume public consumption (very expensive db query + not properly cached), so the site problem persisted even after the db initially suspected as bad was

Re: [Wikitech-l] error lasted more than 10 minutes....

2011-11-28 Thread Roan Kattouw
On Mon, Nov 28, 2011 at 3:50 PM, MZMcBride z...@mzmcbride.com wrote: I asked roughly the same thing yesterday (more along the lines of shouldn't it take someone ten minutes to add memcache support to the extension?). Reedy said it was long-running queries that never timed out that apparently

[MediaWiki-CodeReview] [MediaWiki r104321]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104321. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104321 Commit summary: Followup r103984, take the default for the language dropdown from the URL ___

[MediaWiki-CodeReview] [MediaWiki r104051]: New comment added

2011-11-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r104051. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104051#c26614 Commit summary: (bug 29475) Remove trackback feature entirely from core. This has been disabled-by-default since its inception and nobody uses it. If someone really

[MediaWiki-CodeReview] [MediaWiki r104051]: New comment added

2011-11-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r104051. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104051#c26616 Commit summary: (bug 29475) Remove trackback feature entirely from core. This has been disabled-by-default since its inception and nobody uses it. If someone really

[MediaWiki-CodeReview] [MediaWiki r103933]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r103933. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103933 Commit summary: Add test case described by Vitaliy Filippov in bug 6200. ___

[MediaWiki-CodeReview] [MediaWiki r104436]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104436. Old Status: new New Status: ok User Platonides also posted a comment on MediaWiki.r104436. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104436#c26617 Commit summary: use meaningful test in a parser test Readin the text

[MediaWiki-CodeReview] [MediaWiki r104437]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104437. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r104437. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104437#c26618 Commit summary: Bump MySQL version to 5.0.2 after r104047 Documentation

[MediaWiki-CodeReview] [MediaWiki r104209]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104209. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104209 Commit summary: Improve comment from r104047 Also bump MySQL min requirements to 5.0.2 to save an extra conditional = 5.0.2 has been around

[MediaWiki-CodeReview] [MediaWiki r104310]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104310. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104310 Commit summary: Follow-up r92364: Update hooks documentation ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r104137]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104137. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104137 Commit summary: Modify maintenance/dev/ router code to fix the bug where post data gets discarded and you can't login inside the dev

[MediaWiki-CodeReview] [MediaWiki r104441]: New comment added

2011-11-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r104441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104441#c26619 Commit summary: Added ApiGetDescription hook Comment: Wikia? ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104441]: New comment added

2011-11-28 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104441#c26620 Commit summary: Added ApiGetDescription hook Comment: Nope ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104441]: New comment added

2011-11-28 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r104441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104441#c26621 Commit summary: Added ApiGetDescription hook Comment: Just wrote it on a whim then? ;-) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r104441]: New comment added

2011-11-28 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104441#c26622 Commit summary: Added ApiGetDescription hook Comment: Haha, nope. Wanted it to add some stuff to the API help text for ApiSandbox

[MediaWiki-CodeReview] [MediaWiki r102873]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102873. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102873 Commit summary: Document $wgGroupPermissions better, including per-NS stuff ___

[MediaWiki-CodeReview] [MediaWiki r102683]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102683. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r102683. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102683#c26623 Commit summary: Add $fname to tableExists Pass $fname/__METHOD__ in in

[MediaWiki-CodeReview] [MediaWiki r104434]: New comment added

2011-11-28 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r104434. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104434#c26624 Commit summary: Https for all! (omg, this hadn't been reported) Comment: Don't we want relative URLs ? Some people might be denied HTTPS URLs (i.e. when behind an

[MediaWiki-CodeReview] [MediaWiki r104445]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104445. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r104445. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104445#c26625 Commit summary: Oh noes, moar http:// - https:// Comment: You

[MediaWiki-CodeReview] [MediaWiki r102683]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r102683. Old Status: fixme New Status: new User Reedy also posted a comment on MediaWiki.r102683. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102683#c26626 Commit summary: Add $fname to tableExists Pass $fname/__METHOD__ in in

[MediaWiki-CodeReview] [MediaWiki r104434]: New comment added

2011-11-28 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r104434. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104434#c26627 Commit summary: Https for all! (omg, this hadn't been reported) Comment: This is documentation. I don't think many people would understand a protocol-relative

Re: [Wikitech-l] Bugzilla Weekly Report

2011-11-28 Thread Huib Laurens
I removed that guy also from this list. 2011/11/28 Brion Vibber br...@pobox.com On Sun, Nov 27, 2011 at 7:06 PM, Hydriz Wikipedia ad...@wikisorg.tk wrote: Nice one, vandal topped the list of bug resolving... Remember, kids: cheaters never win! -- brion

[MediaWiki-CodeReview] [MediaWiki r104445]: New comment added

2011-11-28 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r104445. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104445#c26628 Commit summary: Oh noes, moar http:// - https:// Comment: The enginelink also seemed suspicious, but is apparently not used for identification

[MediaWiki-CodeReview] [MediaWiki r104445]: New comment added

2011-11-28 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104445. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104445#c26629 Commit summary: Oh noes, moar http:// - https:// Comment: Does it really make any difference if it's HTTPS or not? I can revert it back if needed

[MediaWiki-CodeReview] [MediaWiki r104363]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SVG changed the status of MediaWiki.r104363. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104363 Commit summary: Fix indenting Fix register_globals issue Add documentation ___

[MediaWiki-CodeReview] [MediaWiki r104364]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User SVG changed the status of MediaWiki.r104364. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104364 Commit summary: Bring some of the DB code into this century Invert if's to de-indent code Leave FIXME comment about using global esk

[MediaWiki-CodeReview] [MediaWiki r102137]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102137. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r102137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102137#c26630 Commit summary: Make the CliInstaller use --server to set wgServer instead

[MediaWiki-CodeReview] [MediaWiki r102434]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102434 Commit summary: MFT r101434,r101442,r101444: fix for bug 32198 ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101442]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101442. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101442 Commit summary: (bug 31739) Made Block code support ipb_by = 0 convention with for foreign users again, as it did pre 1.18. The byText param

[MediaWiki-CodeReview] [MediaWiki r101434]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101434 Commit summary: Made some callers of getBlocker()-getName() just use getByName() ___

[MediaWiki-CodeReview] [MediaWiki r101242]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101242. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101242 Commit summary: More documentation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100557]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100557. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r100557. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100557#c26631 Commit summary: Adding functions to HTMLForm for explicitly setting the

[MediaWiki-CodeReview] [MediaWiki r104452]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104452. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r104452. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104452#c26632 Commit summary: Follow-up r104345. Make freenode.net links protocol relative

[MediaWiki-CodeReview] [MediaWiki r104452]: New comment added

2011-11-28 Thread MediaWiki Mail
User Jon Harald Søby posted a comment on MediaWiki.r104452. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104452#c26633 Commit summary: Follow-up r104345. Make freenode.net links protocol relative again. Also dropped the trailing slash on a couple of languages. Using

[MediaWiki-CodeReview] [MediaWiki r104452]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104452. Old Status: ok New Status: fixme User Hashar also posted a comment on MediaWiki.r104452. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104452#c26634 Commit summary: Follow-up r104345. Make freenode.net links protocol

[MediaWiki-CodeReview] [MediaWiki r104452]: New comment added

2011-11-28 Thread MediaWiki Mail
User Jon Harald Søby posted a comment on MediaWiki.r104452. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104452#c26635 Commit summary: Follow-up r104345. Make freenode.net links protocol relative again. Also dropped the trailing slash on a couple of languages. Using

[MediaWiki-CodeReview] [MediaWiki r100536]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100536. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r100536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100536#c26636 Commit summary: Use getId() accessors for Revision object (fixes fatal)

[MediaWiki-CodeReview] [MediaWiki r104450]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104450. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104450 Commit summary: Documentation Trim whitespace Remove unreachable statement ___

[MediaWiki-CodeReview] [MediaWiki r102098]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r102098. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102098 Commit summary: Followup r100126, per brion remove htmlspecialchars() call Swap back a code line to use $text Swap some space indents to

[MediaWiki-CodeReview] [MediaWiki r100126]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100126. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100126 Commit summary: Add documentation Fix some unused variables, commented some others out

[MediaWiki-CodeReview] [MediaWiki r104360]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104360. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104360 Commit summary: Follow-up r89020 - the election option to enable checking for blocks on other wikis (default false) was never actually

[MediaWiki-CodeReview] [MediaWiki r104365]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104365. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104365 Commit summary: MFT r104360 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104454]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r104454. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r104454. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104454#c26637 Commit summary: * Improve i18n (use formatNum for all numbers, add dir

[MediaWiki-CodeReview] [MediaWiki r99778]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r99778. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99778 Commit summary: Per Siebrand, fix for r99678: use word-separator and parentheses messages ___

[MediaWiki-CodeReview] [MediaWiki r99847]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r99847. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99847 Commit summary: Use SpecialPage::getTitleFor( 'Book' ) instead of Title::newFromText( $wgContLang-specialPage( 'Book' ) )

[MediaWiki-CodeReview] [MediaWiki r99907]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r99907. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99907 Commit summary: Removed usage of $wgTitle ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r99929]: New comment added

2011-11-28 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r99929. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99929#c26638 Commit summary: Move jquery.validate plugin from branches/salvatoreingala to core Comment: And then we have to mimic all that code for server side validation using

[MediaWiki-CodeReview] [MediaWiki r99895]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99895 Commit summary: Move CategoryViewer to it's own file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104454]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104454. Old Status: fixme New Status: new User SPQRobin also posted a comment on MediaWiki.r104454. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104454#c26639 Commit summary: * Improve i18n (use formatNum for all numbers, add dir

[MediaWiki-CodeReview] [MediaWiki r100529]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r100529. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100529 Commit summary: * Use local context to get messages * Simply use getLang() instead of getContext()-getLang() now that this method exists *

Re: [Wikitech-l] Code review goals for 1.19 deployment

2011-11-28 Thread Mark A. Hershberger
Rob Lanphier ro...@wikimedia.org writes: The goal was not to make something 100% accurate based on our past record, but to come up with a goal that's informed by our history, but also nudges us a little to get better than before. Thanks so much for this! Now I have something to add to my

[MediaWiki-CodeReview] [MediaWiki r104395]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104395. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104395 Commit summary: Need to use wfStreamFile() in 1.18, there's no StreamFile ___

[MediaWiki-CodeReview] [MediaWiki r104390]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104390. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104390 Commit summary: Copied VipsScaler from trunk ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104257]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104257. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104257 Commit summary: PHP Notice: Undefined index: USER in /home/wikipedia/common/php-1.18/maintenance/Maintenance.php on line 926

[MediaWiki-CodeReview] [MediaWiki r103998]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r103998. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103998 Commit summary: MFT r103884, r103947, r103959, r103967, r103991, r103996 ___

[MediaWiki-CodeReview] [MediaWiki r103999]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r103999. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103999 Commit summary: Reverting r103998 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r104068]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104068. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104068 Commit summary: too many index collisions on user=0 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r98808]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98808 Commit summary: Update jquery.ui to 1.8.16 Added new Datepicker languages where appropriate (ie stuff we support)

[MediaWiki-CodeReview] [MediaWiki r98578]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r98578. Old Status: new New Status: resolved User Hashar also posted a comment on MediaWiki.r98578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98578#c26640 Commit summary: * (bug 12130) Initial newlines are now preserved correctly

[MediaWiki-CodeReview] [MediaWiki r104046]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104046. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104046 Commit summary: Kill some more mysql 4 related things from the installer * (bug 32217) Drop MySQL 4 support

[MediaWiki-CodeReview] [MediaWiki r104039]: New comment added, and revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104039. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r104039. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104039#c26642 Commit summary: Make installer error out if php was compiled without ctype

[MediaWiki-CodeReview] [MediaWiki r104029]: Revision status changed

2011-11-28 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104029. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104029 Commit summary: Followup r101507: don't automatically use APC for the localization cache if it is available. I've expressed reservations in

[MediaWiki-CodeReview] [MediaWiki r98430]: New comment added

2011-11-28 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r98430. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98430#c26643 Commit summary: (bug 30202) Restrict file names on upload to 240 bytes, because wfTimestamp( TS_MW ) . '!' . $fileName should fit in oi_archive_name, which is 255 bytes,

[MediaWiki-CodeReview] [MediaWiki r103893]: New comment added

2011-11-28 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r103893. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103893#c26644 Commit summary: Implement a number of namespace related equals functions: * MWNamespace::equals to test equivalence of two namespaces (forward compatible with any

  1   2   3   >