I've rewritten tests to match other tests and have been able to run them 
successfully.

I've also made pull request <https://github.com/zzzeek/sqlalchemy/pull/365>.

I've tested sql generation in `test_compiler` and that values that should 
be updated have been updated and values that shouldn't haven't in roundtrip 
test `test_on_duplicate`.

I've decided to pass columns that should be updated as a keyword-arguments 
instead of `update` parameter that I used initially. What do you think 
about that?

Also, so that my Merge statement would work I moved `values_alias` into 
`OnDuplicateClause`

https://github.com/purpleP/sqlalchemy-utils/blob/merge/sqlalchemy_utils/compilers.py

-- 
SQLAlchemy - 
The Python SQL Toolkit and Object Relational Mapper

http://www.sqlalchemy.org/

To post example code, please provide an MCVE: Minimal, Complete, and Verifiable 
Example.  See  http://stackoverflow.com/help/mcve for a full description.
--- 
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sqlalchemy+unsubscr...@googlegroups.com.
To post to this group, send email to sqlalchemy@googlegroups.com.
Visit this group at https://groups.google.com/group/sqlalchemy.
For more options, visit https://groups.google.com/d/optout.

Reply via email to