[ https://issues.apache.org/jira/browse/TORQUE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395587#comment-15395587 ]
Thomas Vandahl commented on TORQUE-346: --------------------------------------- [~tfischer]: Another question: Is obj.getPrimaryKey() != null a valid method to check for the availability of a primary key at runtime? If so, I could make the decision what to use within buildCriteria(obj) and get rid of buildCriteria(pk). > Introduce abstract layer for peer impl to reduce the amount of generated code > ----------------------------------------------------------------------------- > > Key: TORQUE-346 > URL: https://issues.apache.org/jira/browse/TORQUE-346 > Project: Torque > Issue Type: Improvement > Components: Runtime, Templates > Affects Versions: 4.0 > Reporter: Thomas Vandahl > Assignee: Thomas Vandahl > Fix For: 4.1 > > > Several methods in PeerImpl rely on buildCriteria() and buildColumnValues() > respectively. An intermediate layer of AbstractPeerImpl can be used to > concentrate these methods in a central class and reduce the amount of > generated code duplication. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org For additional commands, e-mail: torque-dev-h...@db.apache.org