"top --help" doesn't include the TOP_COMMON help. and i'm starting to get bug reports from folks confused by this. especially because it makes it look like some options disappeared, and enough is genuinely different in toybox top that they're relying on the help. (for most people, this is the first time they've used the toybox top and ps, even though i switched AOSP master in the second half of last year.)
aiui from times this came up in the past, this missing infrastructure feature isn't easy to fix. so should we just copy & paste the common lines in for now? or is there a trick like what's happening with LS and LS_COLOR where we can just rewrite the USE_ lines to get the right output? (somewhat related, i've attached a small fix to the pgrep help.) -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer.
From 353b0cf5234341d1d119c7d89633bd9b664ce521 Mon Sep 17 00:00:00 2001 From: Elliott Hughes <e...@google.com> Date: Thu, 2 Feb 2017 14:51:32 -0800 Subject: [PATCH] Fix typo in pgrep help. --- toys/posix/ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toys/posix/ps.c b/toys/posix/ps.c index cf1f11c..5badec0 100644 --- a/toys/posix/ps.c +++ b/toys/posix/ps.c @@ -179,7 +179,7 @@ config PGREP default y depends on PGKILL_COMMON help - usage: pgrep [-cL] [-d DELIM] [-L SIGNAL] [PATTERN] + usage: pgrep [-cl] [-d DELIM] [-L SIGNAL] [PATTERN] Search for process(es). PATTERN is an extended regular expression checked against command names. -- 2.11.0.483.g087da7b7c-goog
_______________________________________________ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net