[uClinux-dev] Re: [RFC] m68knommu: dont touch the irq controler in the mcfserial driver (v2)

[Greg Ungerer]

Hi Sebastian,

Sebastian Siewior wrote:

The M523x initialized the irq controller properly, the driver must not do
it anymore.

Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> ---

Got lost in the ifdef mine field.

--- a/drivers/serial/mcfserial.c
+++ b/drivers/serial/mcfserial.c

The mcfserial.c driver is obsolete, and I plan on removing it
from the kernel soon. The mcf.c driver is now the appropriate
one to use. It uese the modern style serial driver API, and
properly support platform devices.

Regards
Greg

@@ -1548,6 +1548,7 @@ static void mcfrs_irqinit(struct mcf_ser

uartp = info->addr; +#if !defined(CONFIG_M523x)

        icrp = (volatile unsigned char *) (MCF_MBAR + MCFICM_INTC0 +
                MCFINTC_ICR0 + MCFINT_UART0 + info->line);
        *icrp = 0x30 + info->line; /* level 6, line based priority */
@@ -1555,7 +1556,7 @@ static void mcfrs_irqinit(struct mcf_ser
        imrp = (volatile unsigned long *) (MCF_MBAR + MCFICM_INTC0 +
                MCFINTC_IMRL);
        *imrp &= ~((1 << (info->irq - MCFINT_VECBASE)) | 1);
-
+#endif
 #if defined(CONFIG_M523x)
        {
                volatile unsigned short *par_uartp;

--
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     [EMAIL PROTECTED]
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev