[jira] Updated: (VELTOOLS-68) VelocityViewServlet has hard coded ServletLogger

[Henning Schmiedehausen (JIRA)]

     [ http://issues.apache.org/jira/browse/VELTOOLS-68?page=all ]

Henning Schmiedehausen updated VELTOOLS-68:
-------------------------------------------

    Attachment: velocity-tools.patch

How about the attached patch? It factors out the property setting by the 
servlet to work similar to the engine itself (load a properties file from the 
class path). This explicitly shows what gets set automagically by the servlet 
and gives useful hints to users that e.g. want to turn on caching for the 
webapp loader in the application velocity.properties...

(webapp.resource.loader.cache = true)

The patch also cleans up a number of minor nits, e.g. the usage of 
getServletContext().log() instead of log() directly...

> VelocityViewServlet has hard coded ServletLogger
> ------------------------------------------------
>
>                 Key: VELTOOLS-68
>                 URL: http://issues.apache.org/jira/browse/VELTOOLS-68
>             Project: VelocityTools
>          Issue Type: Bug
>          Components: VelocityView
>    Affects Versions: 1.3
>            Reporter: Henning Schmiedehausen
>            Priority: Minor
>         Attachments: velocity-tools.patch
>
>
> VelocityViewServlet configures the Velocity engine to use the ServletLogger 
> (~line 323). Integration of the servlet into applications that use other 
> logging systems (e.g. log4j / commons-logging) is very hard because of that.
> - VVS should honor the logging setttings in velocity.properties (e.g. for 
> explicit jdk logging)
> - It should add the ServletLogger to the log engine search path and only use 
> it if no other logger was found (log4j / avalon etc.)
> - The ServletLogger class implements the deprecated LogSystem. VelocityTools 
> should provide a LogChute implementation of the SrevletLogger.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]