Will Glass-Husain
Mon, 06 Nov 2006 09:32:38 -0800
Hmmm... Directive.init() might be a problem. If a user writes a custom directive, they subclass Directive. init used to throw Exception, now it throws TemplateInitException. Since this is a class not an interface we might still be ok. Let me test this. I previously tested this patch with a binary of a custom directive I'd written and found compatibility to be fine, but my directive didn't implement init(). WILL On 11/6/06, Nathan Bubna <[EMAIL PROTECTED]> wrote:
That's no problem for code calling the methods, but not for code overriding them. Are there any legitimate use cases for overriding these methods? On 11/5/06, Will Glass-Husain <[EMAIL PROTECTED]> wrote: > You might be right. It started as a small change but became more > significant as I worked through it. Still, I think it's ok since we > are taking away exceptions not adding them. > > WILL > > On 11/5/06, Henning P. Schmiedehausen <[EMAIL PROTECTED]> wrote: > > [EMAIL PROTECTED] writes: > > > > I like that but it is still a bold change right before beta2. :-) > > > > I do expect heavy bleeding edge users like Malcolm to squeal if that breaks > > things. :-) > > > > Best regards > > Henning > > > > > > >Author: wglass > > >Date: Sun Nov 5 00:56:58 2006 > > >New Revision: 471381 > > > > >URL: http://svn.apache.org/viewvc?view=rev&rev=471381 > > >Log: > > >Removed generic "Exception" from throws for Template class and most Node classes. > > >In response to VELOCITY-436. There's a danger of a change to an > > >API call since this involves method signatures, but the only interface that seems > > >relevant is Node.init (used when defining custom directives). > > >Since we are removing Exception and adding TemplateInitException > > >this seems to work. > > -- > > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH > > [EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/ > > > > RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire > > Linux, Java, perl, Solaris -- Consulting, Training, Development > > > > Social behaviour: Bavarians can be extremely egalitarian and folksy. > > -- http://en.wikipedia.org/wiki/Bavaria > > Most Franconians do not like to be called Bavarians. > > -- http://en.wikipedia.org/wiki/Franconia > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Forio Business Simulations > > Will Glass-Husain > [EMAIL PROTECTED] > www.forio.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Forio Business Simulations Will Glass-Husain [EMAIL PROTECTED] www.forio.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]