On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 18:33, Chad Versace <chadvers...@chromium.org> wrote: > > Run with `bin/gl_basic_test --platform=surfaceless_egl`. > > > > All the tests fail! The rgba pixels returned by glReadPixels are > > black (0x0, 0x0, 0x0, 0xff), but the test expects magenta (0xff, 0x0, > > 0xff, 0xff). I don't know why. > > > > Cc: Gurchetan Singh <gurchetansi...@chromium.org> > > Cc: Haixia Shi <h...@chromium.org> > > --- > > tests/functional/gl_basic_test.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/tests/functional/gl_basic_test.c > > b/tests/functional/gl_basic_test.c > > index 4a90dfd..c3c7774 100644 > > --- a/tests/functional/gl_basic_test.c > > +++ b/tests/functional/gl_basic_test.c > > @@ -703,6 +703,17 @@ CREATE_TESTSUITE(WAFFLE_PLATFORM_GLX, glx) > > > > #endif // WAFFLE_HAS_GLX > > > > +#ifdef WAFFLE_HAS_SURFACELESS_EGL > > + > > +#define unit_test_make(name) \ > > + cmocka_unit_test_setup_teardown(name, setup_surfaceless_egl, > > gl_basic_fini) > > + > > +CREATE_TESTSUITE(WAFFLE_PLATFORM_SURFACELESS_EGL, surfaceless_egl) > > + > > +#undef unit_test_make
> Which reminds me that we might want to add support for testsuite(s) > where each test, uses the same setup/teardown [to cmocka] and drop the > above define/undef foo is related (rather nasty) macros. Yes. The test file needs cleanups like that. > Either way, with the small fixes in 4 and 5 the series is > Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> > > Separating surfaceless/null and "platform FOO does not display > anything" wss a great move, imho. > > Nicely done ! Thanks for the review! _______________________________________________ waffle mailing list waffle@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/waffle
