wget  

Re: FW: GNU Coding Standard compliance

Micah Cowan
Mon, 09 Jun 2008 14:07:02 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chris,

Wouldn't the Cygwin-specific version be preferable to existing Cygwin
users (which would include me, on occasion)? In particular, things like
the default --restrict=windows setting might be less than desirable. I
imagine most Cygwin users are looking for a Windows Wget that behaves
more like Unix Wget (since Cygwin is essentially Posix for Windows).

There's also the fact that Wget-1.10.2 is already a Cygwin package,
which could do with the updating, and is probably important to the
Cygwin set as a whole.

Also, I'm not sure that Eric is subscribed to the ML, so he may not have
gotten your message (I've added him to the recipients).

- -Micah

Christopher G. Lewis wrote:
> Eric - 
> 
>   Why are you trying to package Wget for cygwin when there is 
> a *native* win32 exe?  Seems like a whole *lot* of work for 
> something that really doesn't gain you anything.
> 
>   I'm quite interested in your response.
> 
> Chris
> 
> Christopher G. Lewis
> http://www.ChristopherLewis.com
>  
> 
>> -----Original Message-----
>> From: Eric Blake [EMAIL PROTECTED] 
>> Sent: Wednesday, June 04, 2008 7:52 AM
>> To: [EMAIL PROTECTED]
>> Subject: GNU Coding Standard compliance
>>
> I'm trying to package wget-1.11.3 for cygwin.  But you have 
> several GNU
> Coding Standard compliance problems that is making this task more
> difficult than it should be.  GCS requires that your 
> testsuite be run by
> 'make check', but yours is a no-op.   Instead, you provide 
> 'make test',
> but that fails to compile if you use a VPATH build.  And even 
> when using
> an in-tree build, it fails as follows:
> 
> ./Test-proxied-https-auth.px && echo && echo
> /bin/sh: ./Test-proxied-https-auth.px: No such file or directory
> 
> After commenting that line out, the following tests are 
>> also missing:
>       ./Test-proxy-auth-basic.px
>       ./Test-N-current-HTTP-CD.px
> 
> Test-N-HTTP-Content-Disposition.px fails, since it didn't add the
> --content-disposition flag to the wget invocation.
> 
> Several Test--spider-* tests fail, because an expected error 
> code of 256
> is impossible (exit status is truncated to 8 bits).
> 
> Also, your hand-rolled Makefile.in don't support 
> --datarootdir.  I'm not
> sure whether you are interested in migrating to using 
>> Automake, which
> would solve a number of these issues; let me know if you would be
> interested in such a patch.
> 
>>

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer,
and GNU Wget Project Maintainer.
http://micah.cowan.name/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFITZth7M8hyUobTrERApkTAJ95Xll+H1vZaMYtrBRgRGedFUGP1QCZAVeP
JPBle23eqa0JpuCIdX37c6U=
=yjZr
-----END PGP SIGNATURE-----