> In addition to Bundle-SymbolicName, Bundle-Version, and Export-Package,
> Stefan Bodewig suggested adding Bundle-ManifestVersion, Bundle-Name,
> and Bundle-DocURL. I don't have much clue about any OSGi stuff, but I
> checked the OSGi wiki and these sounded reasonable.

Only the 3 attributes that Krzysztof Daniel added are mandatory,
the rest is optional, but probably nice to have.

> Note that the committed patch hardcodes the bundle version number
> while the patch you included in your email doesn't. On the other hand,
> I think it is OK hardcode "org.tukaani.xz" in build.xml.

Obviously it's fine to hardcode it. For some reason I fought that Maven
group ID and artifact ID were specified in build.properties and I just
wanted to follow the convention, but in fact Maven *paths* are settable
in build.properties, not artifact IDs. I this case fully agree with
hardcoding Bundle-SymbolicName in build.xml.

> Maybe I should make a
> new release some day to include this and xz-x.x-sources.jar fixes even
> though no actual Java code has been changed after 1.1.

The patch perfectly fine. From my perspective there is no need
for a new release, but it might be useful for others.

Thank you,
--
Mikolaj Izdebski

Reply via email to