On Wednesday 11 of June 2014 21:08:39 Lasse Collin wrote:
> On 2014-06-11 Pavel Raiskup wrote:
> > Hi, in RHBZ, there was reported problem with xzgrep, we should exit 0
> > when at lest one file contains matching string.  Grep behaves
> > similarly.
> > 
> > Original bugreport:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1108085
> 
> Thanks. I fixed a typo a in a comment in xzgrep (>=2 instead of >2) and
> simplified the test quite a bit. The original test didn't work for
> out-of-tree builds and there was a typo (exho). The new test doesn't
> test as much but I didn't quickly see a good fix for it.

Thanks for committing!  Just a note - I wanted the exact output to be
compared (not just check the exit value), that is the reason why I test
the '-h/-H/-l' options because that could reveal similar bugs like that
which was fixed e.g. by commits bd5002f5 or 40277998.  But that really
needs not-so naive testsuite.  Would you be interested in autotest
solution?

Pavel


Reply via email to