2009/10/26 Phil Race <phil.r...@sun.com>: > Andrew John Hughes wrote: >> >> 2009/10/26 Phil Race <phil.r...@sun.com>: >> >>> >>> The fix looks fine. I think it should go via the build forest, in the >>> expectation >>> that build is likely to integrate to master before AWT or 2D (which >>> would have been the second choice). >>> >>> >> >> Ok, I can push this now or do you still want to? >> > > You can go ahead but I think it would be better to push it to build-dev. > > Acc. to http://openjdk.java.net/projects/jdk7/builds/ AWT/Swing integrate > right before build, but I'm not sure AWT are integrating this time and if > they I think a PIT build repo has already been spun off since its now so > close > to the integration slot.
Sorry, should have been clearer. I agree with your logic on this, and so intended to (and did) push to build-dev: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9bc5338675e0 > > -phil. > > > > >> >>> >>> And its not a proprietary vs open thing, rather it seemed more efficient >>> to me to do both at once. >>> >>> >> >> Yes, I agree that's (slightly) more efficient but my point was that >> only Sun developers can patch the proprietary tree - I don't have the >> option of doing 'both at once'. So, by taking such a stance you're >> effectively ruling out direct external contribution. >> >> >>> >>> -phil. >>> >>> Andrew John Hughes wrote: >>> >>>> >>>> 2009/10/26 Phil Race <phil.r...@sun.com>: >>>> >>>> >>>>> >>>>> Igor is also fixing the closed src .. >>>>> >>>>> -phil. >>>>> >>>>> >>>>> >>>> >>>> Right, well obviously I can't fix the proprietary source code base by >>>> definition. I don't think that's an acceptable reason for refusing >>>> external contributions. If you want to continue to maintain a >>>> proprietary version as well, then you need to be prepared to integrate >>>> community contributions into it. >>>> >>>> I've applied the following webrev to the AWT tree: >>>> >>>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/ >>>> >>>> and it builds. It also works when applied to the IcedTea forest, >>>> removing the original error I posted. >>>> >>>> Just give the nod and I can push this. >>>> >>>> >>>> >>>>> >>>>> Andrew John Hughes wrote: >>>>> >>>>> >>>>>> >>>>>> 2009/10/26 Igor Nekrestyanov <igor.nekrestya...@sun.com>: >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Andrew, >>>>>>> >>>>>>> i've filed 6895287 for this and plan to fix it soon. >>>>>>> (this will likely a bit faster in terms of "time to get fix into >>>>>>> master"). >>>>>>> >>>>>>> -igor >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> Thanks for filing a bug ID for this. I'm already working on a webrev >>>>>> for this, so let's not duplicate the work. I'll post it as soon as it >>>>>> builds. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> 2009/10/26 Kelly O'Hair<kelly.oh...@sun.com>: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Is someone fixing this bootstrap build problem with >>>>>>>>> FontManager.getFontPath(true) and the fontchecker? >>>>>>>>> >>>>>>>>> Not sure I care much how it gets fixed, I just need it fixed. >>>>>>>>> >>>>>>>>> -kto >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> You and me both! I'll look at removing fontchecker. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >>> >> >> >> >> > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
