> Looks ok to me except the copyright on the test should probably be 2010 now =)
Arg! I knew it! http://cr.openjdk.java.net/~rkennke/6888734/webrev.04/ Now don't tell me I have to put 'Oracle' in there! ;-) /Roman > > Dmitri > > Roman Kennke wrote: > > Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: > >> As Dmitri mentioned you need to move policy file too. Otherwise test > >> will not work in new location when run with jtreg. > > > > So I finally found some time to get back at this. I added the policy > > file too: > > > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ > > > > Is this ok now to push? > > > > Thanks, Roman > > > > > >> Rest looks good to me. > >> > >> -igor > >> > >> On 12/7/09 12:12 PM, Roman Kennke wrote: > >>> Hi Phil, > >>> > >>> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: > >>> > >>>> Roman Kennke wrote: > >>>> > >>>>> I added the (previously closed) testcase, keeping it in the same > >>>>> relative directory location: > >>>>> > >>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ > >>>>> > >>>>> Is this ok? > >>>>> > >>>>> > >>>> Almost. Reg tests don't have the classpath exception. > >>>> > >>> Fixed. > >>> > >>> > >>>> And probably the copyright year should be a range, starting > >>>> with whatever the existing year is. > >>>> > >>> This file is added to the closed repository in 2007, with the initial > >>> commit, it doesn't say anything how old this file is. I put it in > >>> OpenJDK in 2009, this is why I say so in the header. What else can I do? > >>> > >>> Also, we need one more review, Igor, can you have a look? > >>> > >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ > >>> > >>> Thanks, Roman > >>> > >>> > >>> > >>> > > > >
