On 11 March 2010 21:16, Phil Race <[email protected]> wrote: > The changes look OK to me. Since we aren't using X11 to render > these fonts there's no need to add mappings to the appropriate NIO encoders > for those new language/script symbols. > > The fontconfig code is a JDK 7 feature and this is a JDK 6 change I believe.
It is, though I didn't know about the fontconfig code so was assuming it needed to go in 7 first and then be backported. Indeed, the posted webrev was against the AWT JDK7 tree where they still exist. > Also note that there's nothing wrong (even in JDK7) with providing a > fontconfig file that's just right for your distro.. the fontconfig code is > motivated more by the fact that the JDKs that are separate from a distro > need some way to keep up with these sorts of changes. That does make sense. Not all of us are on Fedora or Ubuntu. > I think these files being updated were ones I hacked together in maybe 2007 > to support what distros were current at the time we open sourced JDK. > Its not required that they be what a distro actually uses. > FWIW historically in JDK rather than just "update" the file, we append > the specific version it was targeted at to the name, and make the new > updated one the default for everything else. You might want to consider > doing that here although if those distros are so far past EOSL it likely > doesn't matter in this case. Solaris by contrast is supported for a long, > long time. > I agree it doesn't matter for these. There wasn't even an OpenJDK/IcedTea package until Fedora 8 in any case. These files have been patched pretty much from the start and then updated intermittently. Can I have a bug ID to push this? I assume, given the list redirection, it wants to be in the 2d forest. Joe, is this also ok for 6? > -phil. > > Andrew John Hughes wrote: >> >> On 11 March 2010 20:53, Roman Kennke <[email protected]> wrote: >> >>>>> >>>>> The current fontconfig property files in OpenJDK: >>>>> >>>>> >>>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties >>>>> >>>>> jdk/src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties >>>>> >>>>> are outdated. They pertain to Fedora Core 6 (released October 24th, >>>>> 2006 and not supported for several years) and Ubuntu 6.10 (released >>>>> October 26th, 2006 and no longer supported since April 25th, 2008). >>>>> >>> >>> Are they actually still used? I was under the impression that fontconfig >>> is used to get the correct font locations. >>> >>> >> >> doko updated them this week so I assume they still make some difference. >> doko? >> >> >>> >>> /Roman >>> >>> >>> >>> >> >> >> >> > > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
