I suggest that the test only create the output files if some command line
argument is supplied. In the test harness I am not sure where those would
end up. The current working directory is not necessarily the same as either
where the source files or the class files are.
Also this test passes for me with the latest 6 open on Redhat 5.5,
solaris 10 (sparc) and windows 7 even without your changes!?
I find that very puzzling. My build is not using the system freetype
(ie even in the RH 5.5 case) so maybe that's it but I can't see how ..
-phil.
On 10/7/2010 5:16 AM, Pavel Tisnovsky wrote:
Phil Race wrote:
It might be best if you provided the regression test first as pasting
that into the
bug description as the test case there would make it more apparent what
the user impact is.
Then the evaluation will be what you found as the cause.
I've created webrew with new regression test, it is available here:
http://cr.openjdk.java.net/~ptisnovs/TextOutlineBug/
I've also included correct test images (rendered by Sun JDK 6 and IBM
Java) and incorrectly rendered images.
Phil, could you please review this regression test? Please note that I
didn't include bug ID, so this test probably could not be run from JTreg
harness but "only" from CLI.
Thanks in advance
Pavel
-phil.
On 10/5/2010 2:33 AM, Pavel Tisnovsky wrote:
Phil Race wrote:
Whilst the fix looks reasonable I'm a bit confused since you say the
referenced regression test for
6703377 fails and yet it passes for me on a 6open build .. which is what
I'd hoped would happen
for a test specifically designed to test that bug.
Hi Phil,
thank you very much for your comments. I'm going to create regression
test targeted only to this issue based on
java/awt/Graphics2D/DrawString/RotTransText.java.
Could you please create a new bug id for this issue or do I have to
create reg.test first?
Pavel
Note that this fix would need to be pushed under a new bug id, and
either the regression test
would need to be updated to reference the new bug (in addition to the
old one), or if it can't
reproduce the problem, you'd need to update it or provide a new one.
-phil.
On 10/4/2010 4:14 AM, Pavel Tisnovsky wrote:
Hi,
can someone please review a patch (see attachment) which I posted about
two weeks before? This mail was probably lost due to JavaOne ;-)
Thank you in advance
Pavel
