> What are we regressing from? Is it slower than the previous OpenJDK
> rasterizer?
The rasterizer has always gotten faster. The regression is in the
Dasher, because of this changeset:
http://hg.openjdk.java.net/jdk7/2d-gate/jdk/diff/065e6c5a8027/src/share/classes/sun/java2d/pisces/Dasher.java
where I removed flattening but didn't implement any heuristics to
improve the Dashing performance because the changeset was already
pretty big and we wanted to get something in.
> Is there a publicly available build available that does reproduce it?
> If not, if you create a regression test for it and send it my way I
> can run it against a recent build of mine that doesn't have your fixes and
> then we can push the test under the bugid and evaluate it as "likely
> fixed when NNN was fixed"...
Publically available? I don't know about that, but I tested it myself
with a build without my fixes. I attached a regression test.
Regards,
Denis.
----- Original Message -----
> On 1/27/2011 2:03 PM, Denis Lila wrote:
> >> When I first saw "I am Denis Lila" I chuckled because it came
> >> across like "I am Ironman"
> >
> > :-D
> >
> > Well, it is pushed. Now all that's left on my end is the performance
> > improvement for pisces (dashing in particular). Could you please
> > file
> > a performance regression bug for it?
>
>
> > PS: I was looking at 4074742 and I think last week's pushes fixed
> > it.
> > I mean, that's an RFE for more precision, and declaring such things
> > "fixed" is pretty loaded, but I can't reproduce it with the given
> > reproducer anymore, and the current method is very accurate so I
> > think it should be closed.
>
>
> ...jim
/*
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @rfe 4074742
* @summary Verifies that the rectangle is contained in the curve.
* @run main Test4074742
*/
import java.awt.geom.CubicCurve2D;
import java.awt.geom.Rectangle2D;
public class Test4074742 {
public static void main(String[] argv) throws Exception {
double D = 150;
CubicCurve2D c = new CubicCurve2D.Double(0, 0, D, 0, D, 0, D, D);
Rectangle2D r = new Rectangle2D.Double(75, 65, 10, 10);
System.out.println("r is in? = " + c.contains(r));
if (!c.contains(r)) {
throw new Exception("The rectangle should be contained in the curve");
}
}
}
