Hi Clemens,
I created 8024895: xrender MaskImage cache isn't accounting for change
in alpha
the webrev and test need a little clean-up : adding the @test and @bug
tag + GPL
There's a minor formatting error here :-
int currentEA =xrMgr.getAlphaColor().getAlpha();
.. missing space after "="
Other than that the fix is fine although without looking at bit more broadly
I'm unsure how this cache works in a MT scenario.
-phil.
On 9/14/2013 5:44 AM, Clemens Eisserer wrote:
Hi,
Please review my fix at http://cr.openjdk.java.net/~ceisserer/fix10/
I haven't created a an official bug-id, because due to the migration
to JIRA those user reports don't seem to be directly useable anyway.
Problem description:
For transformed blits the xrender pipeline uses caching-logic to be
able to use the same mask again when geometry doesn't change.
However, that logic didn't take into account changes of the "extra alpha" value.
Fix description:
The pipeline now also stores and validates against the extra-alpha
value which was used the last time the mask was prepared.
Also available is a small regression test, please feel free to modify
or discard it.
Thanks, Clemens
