Hi, Should: if(major <= 3 && minor < 5)
be changed to: if (major < 3 || (major == 3 && minor < 5)) Thanks, Johnny Chen On Sep 30, 2013, at 3:39 PM, Phil Race <[email protected]> wrote: > This looks good to me. I am running it through our build system just to be > sure > but I don't anticipate any problems. > > 2nd reviewer ? > > -phil. > > On 9/28/2013 3:26 PM, Clemens Eisserer wrote: >> Hi Phil, >> >>> Shouldn't most of this be inside an "ifdef _linux_ ? >>> Solaris & (currently) even MacOS will compile this code. >> Thanks for the pointer, I completely forgot about OSX (solaris should >> work as-is). >> Please find an updated version at: >> http://cr.openjdk.java.net/~ceisserer/8007386/webrev.02/ >> >> - Clemens >
