All seems fine. Just a couple of observation/questions ..

1. I see you found an unused variable in ServiceDialog ..

2. IPPPrintService.java

1791     ArrayList<HashMap<String, AttributeClass>> respList = new 
ArrayList<>();


1900                 @SuppressWarnings({"unchecked", "rawtypes"})
1901                 HashMap<String, AttributeClass>[] tmp  =
1902                     respList.toArray((HashMap<String, 
AttributeClass>[])new HashMap[respList.size()]);


Just curious, what  was  the problem here using the generified type as the
argument to toArray() ?

-phil.

On 6/8/2014 10:00 PM, Joe Darcy wrote:
Hello,

Please review my proposed changes to address

    JDK-8042870: Fix raw and unchecked warnings in sun.print
    http://cr.openjdk.java.net/~darcy/8042870.0/

(This is the largest remaining grouping of raw and unchecked warnings in a single package in the jdk repo.)

Thanks,

-Joe


Reply via email to