Approved.
-phil.
On 8/12/14 2:56 PM, Pushan Hinduja wrote:
Hello,
Here is the updated Webrev for the fix:
http://cr.openjdk.java.net/~ssides/8054878/8054878.1/
<http://cr.openjdk.java.net/%7Essides/8054878/8054878.1/>
Thank you
--
Pushan Hinduja
On Tue, Aug 12, 2014 at 1:01 PM, Phil Race <[email protected]
<mailto:[email protected]>> wrote:
309 * @exception DOMException thrown if the node is not
<code>null</code> or
310 * not an instance of <code>IIOMetadtaNode</code>
Seems to be a logic problem with the negatives here.
I think what you want is and not or
Also you misspelt IIOMetaDataNode - missing 'a'
I also prefer @throws as it makes it easier to write like this :-
@throws DOMException if {@code node} is not {@code null} and not an instance
of {@code IIOMetadataNode}
-phil.
On 8/12/14 11:52 AM, Pushan Hinduja wrote:
Hello,
Could you please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8054878
The corresponding Webrev is located at:
http://cr.openjdk.java.net/~ssides/8054878/8054878.0/
<http://cr.openjdk.java.net/%7Essides/8054878/8054878.0/>
This addresses missing @exception or @throw tags in certain files
in javax.imageio
Best Regards,
--
Pushan Hinduja
--
Pushan Hinduja
