Thanks Phil.
I need +1 for this. @Sergey, could you please review and approve it?
Regards
Prasanta
On 10/30/2015 11:39 PM, Phil Race wrote:
Ok .. approved.
-phil.
On 10/29/2015 10:19 PM, prasanta sadhukhan wrote:
Hi Phil,
On 10/30/2015 12:33 AM, Phil Race wrote:
On 10/25/2015 11:56 PM, prasanta sadhukhan wrote:
Hi All,
I have modified the fix to assign printer name in case
UnsupportedEncodingException is thrown which is unlikely as we are
using UTF-8 as character encoding and not any user-supplied encoding.
http://cr.openjdk.java.net/~psadhukhan/8139216/webrev.01/
It should be impossible as it would contradict the SE spec to not
support UTF-8
https://docs.oracle.com/javase/8/docs/api/java/nio/charset/Charset.html
Anyway, off-list you said that even with this change you could not then
open a connection because URLConnection was throwing an
IOException. Is that somehow resolved ??
I was trying a different approach that time which was causing that
problem. This fix does not have that problem and works.
Regards
Prasanta
-phil.
Regards
Prasanta
On 10/15/2015 4:16 PM, prasanta sadhukhan wrote:
Hi All,
Please review a fix for jdk9 where it was found that non-ASCII
characters in CUPS printer name are not properly displayed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8139216
webrev: http://cr.openjdk.java.net/~psadhukhan/8139216/webrev.00/
It was found that the printer "äbc" (with the German umlaut "ä"
as the first character) is displayed as "%C3%A4bc" in printer name.
Fixed to use the UTF-8 charset to decode the printer name.
I could not add any test because it involves adding printer having
unicode character like "lpadmin -p "äbc" -v
http://example.org/printer3 -E"
Regards
Prasanta
