Looks ok to me.
Regards, Rajeev Chamyal Subject: Re: [9] RFR: JDK-8020448: Test closed/java/awt/font/JNICheck/JNICheck.sh fails on Solaris 11 Date: Mon, 2 Nov 2015 16:17:15 +0300 From: Alexander Zvegintsev HYPERLINK "mailto:alexander.zvegint...@oracle.com";<alexander.zvegint...@oracle.com> To: prasanta sadhukhan HYPERLINK "mailto:prasanta.sadhuk...@oracle.com";<prasanta.sadhuk...@oracle.com>, HYPERLINK "mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.net HYPERLINK "mailto:2d-dev@openjdk.java.net";<2d-dev@openjdk.java.net>, Phil Race HYPERLINK "mailto:philip.r...@oracle.com";<philip.r...@oracle.com> Looks good to me. Thanks, Alexander. On 10/29/2015 12:06 PM, prasanta sadhukhan wrote: Hi All, Please review a small fix in jdk9 whereby JNICheck issued a warning that Exception is not checked after calling a JNI method. This is in continuation to HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8130507"JDK-8130507 fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8020448 webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/8020448/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/8020448/webrev.00/ It was seen that JNICheck was issuing a warning WARNING in native method: JNI call made without checking exceptions when required to from CallBooleanMethod at sun.awt.FcFontManager.getFontPathNative(Native Method) resulting in failure of this test. There is another warning raised which is in core-libs code and a bug has been raised against it HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8131136"8131136 Fix is to add the proper Exception check. Regards Prasanta
