139 public static boolean isEnableLogs() {
140 return getBoolean("sun.java2d.renderer.log", "false");
141 }
All of these begin with sun.java2d.renderer but they are all marlin
specific.
I guess it is OK though if we expect that ultimately marlin is the only
renderer.
"isEnable" does not read well but I know that the same pattern is used for
everything so I don't have a firm objection although the "is" seems likeit
is could be removed in most cases. Some may need a "do" adding
You have deleted getCallerInfo so probably you can close
https://bugs.openjdk.java.net/browse/JDK-8144530 as a dup of this bug.
-phil.
On 12/03/2015 02:17 PM, Laurent Bourgès wrote:
https://bugs.openjdk.java.net/browse/JDK-8144654
Please review this webrev that fixes logging issues in Marlin:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144654.0/
<http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8144654.0/>
Changes:
- Byte/Float/Int/ArrayCache: use logInfo instead of System.out
- MarlinConst: enableLogs uses MarlinProperties.isEnableLogs() and
restore potential doMonitors / doChecks flags
- MarlinProperties: added isEnableLogs()
- MarlinUtils: use PlatformLogger instead of Logger and removed
getCallerInfos()
- RendererContext: remove all MarlinUtils.getCallerInfos()
Best regards,
Laurent Bourgès
