I suppose this modified test must pass for all the plugins ? -Phil.
> On Dec 7, 2015, at 6:05 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > This is a revision of the previous patch which had been approved: > > http://cr.openjdk.java.net/~bpb/8144245/webrev.01/ > > I was suspicious of whether the fix for the WriteAfterAbort problem was > really correct in the case of writing a sequence so I wrote another test. > Indeed it discovered that the TIFFImageWriter change did not work for > aborting a sequence. The updated code in this patch passes both tests. > > Modifications versus previous version: > > Added WriteToSequenceAfterAbort test. > Corrected TIFFImageWriter to pass both tests (needed to save and restore some > extra state, mainly positions). > Removed 8144245 from @bug in WriteAfterAbort as it is now present in > WriteToSequenceAfterAbort. > > Thanks, > > Brian > >> On Dec 7, 2015, at 5:20 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> >> wrote: >> >> Looks fine. >> >>> On 05.12.15 1:55, Phil Race wrote: >>> looks good. >>> >>> -phil. >>> >>>> On 12/04/2015 02:27 PM, Brian Burkhalter wrote: >>>> Please review at your convenience. >>>> >>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8144245 >>>> Patch: http://cr.openjdk.java.net/~bpb/8144245/webrev.00/ >>>> >>>> For the principal issue, the stream position was not being reset when >>>> the write was aborted to either the header position or to the position >>>> of the current IFD, as appropriate. As part of the investigation, a >>>> missing check in TIFFIFD was discovered. Also, a few occurrences in >>>> TIFFImageWriter of a NullPointerException being thrown where an >>>> IllegalArgumentException was expected were corrected. Lastly, the test >>>> was slightly modified to iterate over all registered writers and fail >>>> at the end instead of bailing out on the first failure. >>>> >>>> Thanks, >>>> >>>> Brian >> >> >> -- >> Best regards, Sergey. >
