Hi Phil,
I was analyzing HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-7107905"JDK-7107905 as part of it I was looking for any other subclass of ColorModel which doesn't have override equals() method. While doing this I found out that in PackedColorModel we are doing redundant check for number of components. So I raised HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8153363"JDK-8153363 to resolve this minor issue. I mentioned JCK test in mail so that I can add noreg-jck label in bug. Thanks, Jay From: Phil Race Sent: Tuesday, April 05, 2016 2:59 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev Subject: Re: Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method This looks fine although I am unable to work out how a JCK test detected the duplication -phil. On 04/04/2016 08:35 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8153363 Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8153363/webrev.00/"http://cr.openjdk.java.net/~jdv/8153363/webrev.00/ Issue : We have redundant check for equality of number of components in PackedColorModel. Solution : Number of components equality is verified in Parent class(ColorModel) and we call super.equals(), no need for checking the equality again. JCK test "api/java_awt/Image/PackedColorModel/equalsTests.java" verifies equals() method so added noreg-jck label in bug. Thanks, Jay
