Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

[Jayathirth D V]

Hi Phil,

 

Thanks for the review.

I have updated the recommended changes also I made similar change in 
PixelInterleavedSampleModel.java because it is also a non-final & non-abstract 
class.

Please find updated webrev for review:

http://cr.openjdk.java.net/~jdv/8153943/webrev.01/ 

 

Thanks,

Jay

 

From: Phil Race 
Sent: Wednesday, April 20, 2016 10:48 PM
To: Jayathirth D V
Cc: Jim Graham; Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In 
java.awt.image package some of the classes are missing hashCode() or equals() 
method

 

Hi,
 
You removed the following test in CCM.java :
 
2941         if (obj.getClass() !=  getClass()) {
2942             return false;
 
2943         }

What this means is that before your change an instance of a subclass of CCM
would never be equals() to any direct instantiatation of CCM but after
your change it can be. I suspect the condition was there on purpose.

-phil.

On 04/20/2016 05:45 AM, Jayathirth D V wrote:

Hi, 

 

Please review the following fix in JDK9:

 

Bug : https://bugs.openjdk.java.net/browse/JDK-8153943 

 

This is subtask of https://bugs.openjdk.java.net/browse/JDK-6588409 

 

Webrev : HYPERLINK 
"http://cr.openjdk.java.net/%7Ejdv/8153943/webrev.00/"http://cr.openjdk.java.net/~jdv/8153943/webrev.00/
 

 

Issue : Some of the java.awt.image classes are missing either equals() or 
hashCode() method.

 

Solution : Add missing equals() or hashCode() methods.

 

Thanks,

Jay