There's usually some fairly lengthy processing going on
in the layout code so I think it would be too long to hold
a critical lock and not likely to show a detectable benefit.
Also I think it possible we may make some Java upcalls there ..
-phil.
On 7/28/16, 5:41 AM, Sergey Bylokhov wrote:
Looks fine.
I wander is it possible to improve it via
GetPrimitiveArrayCritical/ReleasePrimitiveArrayCritical?
On 28.07.16 1:06, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8158477
http://cr.openjdk.java.net/~prr/8158477/
Missing a call to ReleaseCharArrayElements()
With this fix the test in the bug runs happily for many minutes
without any
increase at all in virtual memory. About 1.5 million invocations of the
layout code so far.
The JNI exception checking is just something I noticed was missing ..
not
relevant to the leak.
No reg. test since it is not something you can test easily from jtreg ..
-phil.
