+1
-phil
On 7/28/16, 10:28 PM, Prasanta Sadhukhan wrote:
Yes, right. Please find the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.02/
Regards
Prasanta
On 7/28/2016 7:10 PM, Philip Race wrote:
This can now be written more succinctly (and clearly) as :
prPgRngSupported = psCurrent.isAttributeValueSupported(prAll,
docFlavor,asCurrent);
-phil.
On 7/28/16, 3:27 AM, Prasanta Sadhukhan wrote:
Trying to be extra cautious. Please find modified webrev:
http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.01/
Regards
Prasanta
On 7/27/2016 9:55 PM, Phil Race wrote:
prAll is final and initalised. So why are you testing !=null ?
-phil.
On 07/05/2016 02:08 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen "Page range
(From/To) " field is not disabled for flavors such as postscript,
image flavors.
PageRanges attribute is supported only for Service Formatted
flavors such as Pageable and Printable and so for
other flavors such as postscript, image flavors page ranges fields
must be disabled on the print dialog so as not to allow the user
to select the same
Bug: https://bugs.openjdk.java.net/browse/JDK-5080098
webrev: http://cr.openjdk.java.net/~psadhukhan/5080098/webrev.00/
Proposed fix is to check for attribute against the specified doc
flavor
and not against attribute category to decide whether to enable /
disable it.
Regards
Prasanta